Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto-instrumentation with service_name from environmental variable #2455

Merged
merged 19 commits into from
Dec 7, 2022
Merged

Auto-instrumentation with service_name from environmental variable #2455

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
0db0ed7
Shared example for environment service name
TonyCTHsu Dec 6, 2022
baf298c
Environment variable service_name for `dalli`
TonyCTHsu Dec 6, 2022
e75a528
Environment variable service_name for `aws`
TonyCTHsu Dec 6, 2022
0dcc2f8
Environment variable service_name for `elasticsearch`
TonyCTHsu Dec 6, 2022
0d613ed
Environment variable service_name for `ethon`
TonyCTHsu Dec 6, 2022
9d23cf6
Environment variable service_name for `excon`
TonyCTHsu Dec 6, 2022
1fbcfcf
Environment variable service_name for `faraday`
TonyCTHsu Dec 6, 2022
4cbd417
Environment variable service_name for `grpc`
TonyCTHsu Dec 6, 2022
0cefe92
Environment variable service_name for `http`
TonyCTHsu Dec 6, 2022
279edc9
Environment variable service_name for `httpclient`
TonyCTHsu Dec 6, 2022
3a398b7
Environment variable service_name for `httprb`
TonyCTHsu Dec 6, 2022
6e70ec1
Environment variable service_name for `mongodb`
TonyCTHsu Dec 6, 2022
b7133eb
Environment variable service_name for `mysql2`
TonyCTHsu Dec 6, 2022
3d4593f
Environment variable service_name for `pg`
TonyCTHsu Dec 6, 2022
135848f
Environment variable service_name for `redis`
TonyCTHsu Dec 6, 2022
cd1a11b
Environment variable service_name for `rest_client`
TonyCTHsu Dec 6, 2022
9cd6b98
Environment variable service_name for `presto`
TonyCTHsu Dec 6, 2022
70e2a08
Rename environment variable with `DD_TRACE_NET_HTTP_SERVICE_NAME`
TonyCTHsu Dec 7, 2022
45f4d52
Refactor fetch semantic to evaluate string immediately
TonyCTHsu Dec 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Environment variable service_name for httprb
  • Loading branch information
@TonyCTHsu
TonyCTHsu committed Dec 6, 2022
commit 3a398b7d963e246157c27da37be8f46be017f854
11 changes: 10 additions & 1 deletion lib/datadog/tracing/contrib/httprb/configuration/settings.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,16 @@ class Settings < Contrib::Configuration::Settings
end

option :distributed_tracing, default: true
option :service_name, default: Ext::DEFAULT_PEER_SERVICE_NAME

option :service_name do |o|
o.default do
ENV.fetch(Ext::ENV_SERVICE_NAME) do
Ext::DEFAULT_PEER_SERVICE_NAME
end
end
o.lazy
end

option :split_by_domain, default: false
end
end
Expand Down
1 change: 1 addition & 0 deletions lib/datadog/tracing/contrib/httprb/ext.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ module Httprb
# @public_api Changing resource names, tag names, or environment variables creates breaking changes.
module Ext
ENV_ENABLED = 'DD_TRACE_HTTPRB_ENABLED'.freeze
ENV_SERVICE_NAME = 'DD_TRACE_HTTPRB_SERVICE_NAME'.freeze
ENV_ANALYTICS_ENABLED = 'DD_TRACE_HTTPRB_ANALYTICS_ENABLED'.freeze
ENV_ANALYTICS_SAMPLE_RATE = 'DD_TRACE_EHTTPRB_ANALYTICS_SAMPLE_RATE'.freeze
DEFAULT_PEER_SERVICE_NAME = 'httprb'.freeze
Expand Down
7 changes: 7 additions & 0 deletions spec/datadog/tracing/contrib/httprb/instrumentation_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
require 'datadog/tracing/contrib/analytics_examples'
require 'datadog/tracing/contrib/integration_examples'
require 'datadog/tracing/contrib/support/spec_helper'
require 'datadog/tracing/contrib/environment_service_name_examples'
require 'spec/support/thread_helpers'

RSpec.describe Datadog::Tracing::Contrib::Httprb::Instrumentation do
Expand Down Expand Up @@ -146,6 +147,8 @@
let(:analytics_enabled_var) { Datadog::Tracing::Contrib::Httprb::Ext::ENV_ANALYTICS_ENABLED }
let(:analytics_sample_rate_var) { Datadog::Tracing::Contrib::Httprb::Ext::ENV_ANALYTICS_SAMPLE_RATE }
end

it_behaves_like 'environment service name', 'DD_TRACE_HTTPRB_SERVICE_NAME'
end

context 'response has internal server error status' do
Expand All @@ -170,6 +173,8 @@
it 'has error message' do
expect(span).to have_error_message('Error')
end

it_behaves_like 'environment service name', 'DD_TRACE_HTTPRB_SERVICE_NAME'
end

context 'response has not found status' do
Expand All @@ -194,6 +199,8 @@
it 'has error message' do
expect(span).to have_error_message('Error')
end

it_behaves_like 'environment service name', 'DD_TRACE_HTTPRB_SERVICE_NAME'
end

context 'distributed tracing default' do
Expand Down