Auto-instrumentation with service_name from environmental variable #2455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TonyCTHsu
force-pushed
the
tonycthsu/auto-instrument-with-environment-variable
branch
from
b620137
to
26637c8
Compare
TonyCTHsu
force-pushed
the
tonycthsu/auto-instrument-with-environment-variable
branch
from
26637c8
to
3d4593f
Compare
Codecov Report
@@ Coverage Diff @@
## master #2455 +/- ##
==========================================
+ Coverage 98.01% 98.03% +0.01%
==========================================
Files 1105 1109 +4
Lines 59276 59951 +675
==========================================
+ Hits 58100 58771 +671
- Misses 1176 1180 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Suggestion: rename My thought is |
marcotc
reviewed
Dec 6, 2022
marcotc
reviewed
Dec 6, 2022
| @@ -43,6 +44,7 @@ | |||
|
|
|||
| it_behaves_like 'measured span for integration' | |||
| it_behaves_like 'a peer service span' | |||
| it_behaves_like 'environment service name', 'DD_TRACE_AWS_SERVICE_NAME' | |||
There was a problem hiding this comment.
Good job on creating a shared example! Super clean! 🧹
marcotc
approved these changes
Dec 6, 2022
TonyCTHsu
deleted the
tonycthsu/auto-instrument-with-environment-variable
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allow integration service name being configured by environment variable
awsDD_TRACE_AWS_SERVICE_NAMEdalliDD_TRACE_DALLI_SERVICE_NAMEelasticsearchDD_TRACE_ELASTICSEARCH_SERVICE_NAMEethonDD_TRACE_ETHON_SERVICE_NAMEexconDD_TRACE_EXCON_SERVICE_NAMEfaradayDD_TRACE_FARADAY_SERVICE_NAMEgrpcDD_TRACE_GRPC_SERVICE_NAMEhttpDD_TRACE_NET_HTTP_SERVICE_NAMEhttpclientDD_TRACE_HTTPCLIENT_SERVICE_NAMEhttprbDD_TRACE_HTTPRB_SERVICE_NAMEmongodbDD_TRACE_MONGO_SERVICE_NAMEmysql2DD_TRACE_MYSQL2_SERVICE_NAMEpgDD_TRACE_PG_SERVICE_NAMEprestoDD_TRACE_PRESTO_SERVICE_NAMEredisDD_TRACE_REDIS_SERVICE_NAMErest-clientDD_TRACE_REST_CLIENT_SERVICE_NAME