Sampling-Propagation:Exclude problematic existing tag #2299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcotc
force-pushed
the
sampling-dm-propagation
branch
from
c6e9be0
to
6915492
Compare
marcotc
force-pushed
the
deprecated-tags
branch
from
3bf30b4
to
efe7c4c
Compare
marcotc
force-pushed
the
sampling-dm-propagation
branch
from
6915492
to
e77772d
Compare
marcotc
force-pushed
the
deprecated-tags
branch
from
efe7c4c
to
d95e180
Compare
Codecov Report
@@ Coverage Diff @@
## sampling-dm-propagation #2299 +/- ##
========================================================
Coverage 98.34% 98.34%
========================================================
Files 1102 1102
Lines 58856 58865 +9
========================================================
+ Hits 57879 57890 +11
+ Misses 977 975 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Base automatically changed from
sampling-dm-propagation
to
feat-Sampling-Propagation
November 7, 2022 21:19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #2298
The distributed tracing tag
_dd.p.upstream_serviceswas at one point populated by other language traces, but we do not need this information anymore.Although the Ruby tracer has never populated this tag, we must make sure we don't propagate this tag downstream if we ever receive it in a distributed tracing request context.