Sampling-Propagation:Export/import sampling decision through distributed trace tags #2298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcotc
force-pushed
the
sampling-dm-propagation
branch
2 times, most recently
from
c6e9be0
to
6915492
Compare
marcotc
force-pushed
the
sampling-dm-propagation
branch
from
6915492
to
e77772d
Compare
marcotc
force-pushed
the
sampling-decision
branch
2 times, most recently
from
ea3381a
to
1b02e5d
Compare
marcotc
changed the title
Base automatically changed from
sampling-decision
to
feat-Sampling-Propagation
November 7, 2022 21:18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows up from #2282.
This PR ensures theTraceOperation#sampling_mechanismpopulated in #2282 is injected and extracted during distributed tracing.This PR became trivial because the sampling decision is now considered a simple, opaque tag.
Only tests were added to cover the propagation specific tags, but not code changes are needed.