Make frequently allocated string a constant #1275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This string appears to be allocated a lot but can be moved to a constant. This only improves memory for versions below Ruby 2.3 because I belive Ruby has optimizations going forward that allow it to re-use these immutable strings.
ericmustin
approved these changes
Dec 7, 2020
|
@callumj hm it looks like circleci may have been having some issues when u made the pr, would u mind pushing a no-op commit or something to that effect to kick the ci? sorry for the hassle |
|
@marcotc @ericmustin do you know why this might fail on JRuby? |
|
Fixed it |
|
@callumj sorry about the hassle there, the CI has some flakiness we've been working on improving but still have a ways to go clearly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This string appears to be allocated a lot but can be moved to a constant. This only improves memory for versions below Ruby 2.3 because I belive Ruby has optimizations going forward that allow it to re-use these immutable strings.