Merge pull request #1275 from callumj/cj-na-freeze

Make frequently allocated string a constant
DataDog · Dec 7, 2020 · 8784076 · 8784076
2 parents 750ebd9 + 52ce4b0
commit 8784076
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/lib/ddtrace/contrib/ethon/easy_patch.rb b/lib/ddtrace/contrib/ethon/easy_patch.rb
@@ -99,7 +99,7 @@ def datadog_span_started?
 
           def datadog_tag_request
             span = @datadog_span
-            method = 'N/A'
+            method = Ext::NOT_APPLICABLE_METHOD
             if instance_variable_defined?(:@datadog_method) && !@datadog_method.nil?
               method = @datadog_method.to_s
             end

diff --git a/lib/ddtrace/contrib/ethon/ext.rb b/lib/ddtrace/contrib/ethon/ext.rb
@@ -12,6 +12,7 @@ module Ext
         SERVICE_NAME = 'ethon'.freeze
         SPAN_REQUEST = 'ethon.request'.freeze
         SPAN_MULTI_REQUEST = 'ethon.multi.request'.freeze
+        NOT_APPLICABLE_METHOD = 'N/A'.freeze
       end
     end
   end