-
Notifications
You must be signed in to change notification settings - Fork 375
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #1128 from DataDog/update_sucker_punch_tests_to_rspec
migrate sucker_punch tests from minitest to rspec
- Loading branch information
Showing
4 changed files
with
128 additions
and
115 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,128 @@ | ||
| require 'ddtrace/contrib/support/spec_helper' | ||
| require 'ddtrace/contrib/analytics_examples' | ||
| require 'sucker_punch' | ||
| require 'ddtrace' | ||
|
|
||
| RSpec.describe 'sucker_punch instrumentation' do | ||
| before do | ||
| Datadog.configure do |c| | ||
| c.use :sucker_punch | ||
| end | ||
|
|
||
| SuckerPunch::Queue.clear | ||
| SuckerPunch::RUNNING.make_true | ||
| end | ||
|
|
||
| after do | ||
| SuckerPunch::Queue.clear | ||
| end | ||
|
|
||
| around do |example| | ||
| # Reset before and after each example; don't allow global state to linger. | ||
| Datadog.registry[:sucker_punch].reset_configuration! | ||
| example.run | ||
| Datadog.registry[:sucker_punch].reset_configuration! | ||
| end | ||
|
|
||
| let(:worker_class) do | ||
| Class.new do | ||
| include SuckerPunch::Job | ||
|
|
||
| def perform(action = :none) | ||
| 1 / 0 if action == :fail | ||
| end | ||
| end | ||
| end | ||
|
|
||
| context 'successful job' do | ||
| subject(:dummy_worker_success) { worker_class.perform_async } | ||
| let(:job_span) { spans.find { |s| s.resource[/PROCESS/] } } | ||
| let(:enqueue_span) { spans.find { |s| s.resource[/ENQUEUE/] } } | ||
| let(:span) { spans.first } | ||
|
|
||
| it_behaves_like 'measured span for integration', true do | ||
| before do | ||
| dummy_worker_success | ||
| try_wait_until { fetch_spans.any? } | ||
| end | ||
| end | ||
|
|
||
| it 'should generate two spans, one for pushing to enqueue and one for the job itself' do | ||
| is_expected.to be true | ||
| try_wait_until { fetch_spans.length == 2 } | ||
| expect(spans.length).to eq(2) | ||
| end | ||
|
|
||
| it 'should instrument successful job' do | ||
| is_expected.to be true | ||
| try_wait_until { fetch_spans.length == 2 } | ||
|
|
||
| expect(job_span.service).to eq('sucker_punch') | ||
| expect(job_span.name).to eq('sucker_punch.perform') | ||
| expect(job_span.resource).to eq("PROCESS #{worker_class}") | ||
| expect(job_span.get_tag('sucker_punch.queue')).to eq(worker_class.to_s) | ||
| expect(job_span.status).not_to eq(Datadog::Ext::Errors::STATUS) | ||
| end | ||
|
|
||
| it 'should instrument successful enqueuing' do | ||
| is_expected.to be true | ||
| try_wait_until { fetch_spans.any? } | ||
|
|
||
| expect(enqueue_span.service).to eq('sucker_punch') | ||
| expect(enqueue_span.name).to eq('sucker_punch.perform_async') | ||
| expect(enqueue_span.resource).to eq("ENQUEUE #{worker_class}") | ||
| expect(enqueue_span.get_tag('sucker_punch.queue')).to eq(worker_class.to_s) | ||
| expect(enqueue_span.get_metric('_dd.measured')).to eq(1.0) | ||
| end | ||
| end | ||
|
|
||
| context 'failed job' do | ||
| subject(:dummy_worker_fail) { worker_class.perform_async(:fail) } | ||
| let(:job_span) { spans.find { |s| s.resource[/PROCESS/] } } | ||
| let(:span) { spans.first } | ||
|
|
||
| it_behaves_like 'measured span for integration', true do | ||
| before do | ||
| dummy_worker_fail | ||
| try_wait_until { fetch_spans.any? } | ||
| end | ||
| end | ||
|
|
||
| it 'should instrument a failed job' do | ||
| is_expected.to be true | ||
| try_wait_until { fetch_spans.length == 2 } | ||
|
|
||
| expect(job_span.service).to eq('sucker_punch') | ||
| expect(job_span.name).to eq('sucker_punch.perform') | ||
| expect(job_span.resource).to eq("PROCESS #{worker_class}") | ||
| expect(job_span.get_tag('sucker_punch.queue')).to eq(worker_class.to_s) | ||
| expect(job_span).to have_error | ||
| expect(job_span).to have_error_type('ZeroDivisionError') | ||
| expect(job_span).to have_error_message('divided by 0') | ||
| end | ||
| end | ||
|
|
||
| context 'delayed job' do | ||
| subject(:dummy_worker_delay) { worker_class.perform_in(0) } | ||
| let(:enqueue_span) { spans.find { |s| s.resource[/ENQUEUE/] } } | ||
| let(:span) { spans.first } | ||
|
|
||
| it_behaves_like 'measured span for integration', true do | ||
| before do | ||
| dummy_worker_delay | ||
| try_wait_until { fetch_spans.any? } | ||
| end | ||
| end | ||
|
|
||
| it 'should instrument enqueuing for a delayed job' do | ||
| is_expected.to be true | ||
| try_wait_until { fetch_spans.any? } | ||
|
|
||
| expect(enqueue_span.service).to eq('sucker_punch') | ||
| expect(enqueue_span.name).to eq('sucker_punch.perform_in') | ||
| expect(enqueue_span.resource).to eq("ENQUEUE #{worker_class}") | ||
| expect(enqueue_span.get_tag('sucker_punch.queue')).to eq(worker_class.to_s) | ||
| expect(enqueue_span.get_tag('sucker_punch.perform_in')).to eq(0) | ||
| end | ||
| end | ||
| end |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.