migrate sucker_punch tests from minitest to rspec #1128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcotc
requested changes
Jul 31, 2020
marcotc
previously approved these changes
Aug 4, 2020
|
@marcotc resolving merge conflict auto-dismissed your review, if you wouldnt mind reviewing again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves over the SuckerPunch minitest tests within the
/testsfolder to rspec spec's within the/specfolder. It tests what was covered in the minitest suite, specifically, instrumentation of enqueue and job spans from SuckerPunch worker instrumentation.