Skip to content

fix(tracer): add extra service names for all spans [backport 3.10] #13943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2025

Conversation

github-actions[bot]
Copy link
Contributor

Backport ab14f5c from #13922 to 3.10.

Add extra service names for all finished spans.

From a suggestion of @brettlangdon

APPSEC-58108

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@github-actions github-actions bot requested review from a team as code owners July 10, 2025 13:56
@brettlangdon brettlangdon force-pushed the backport-13922-to-3.10 branch from f4f4ed4 to a417350 Compare July 10, 2025 14:01
Copy link
Contributor Author

CODEOWNERS have been resolved as:

releasenotes/notes/report_extra_service_names_from_spans-b98b87fbefe97337.yaml  @DataDog/apm-python
ddtrace/_trace/processor/__init__.py                                    @DataDog/apm-sdk-api-python
tests/internal/service_name/test_extra_services_names.py                @DataDog/apm-core-python

@brettlangdon brettlangdon enabled auto-merge (squash) July 10, 2025 14:02
Copy link
Contributor Author

github-actions bot commented Jul 10, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 276 ± 4 ms.

The average import time from base is: 283 ± 5 ms.

The import time difference between this PR and base is: -6.7 ± 0.2 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 3.364 ms (1.22%)
ddtrace.bootstrap.sitecustomize 2.329 ms (0.84%)
ddtrace.bootstrap.preload 1.930 ms (0.70%)
ddtrace.internal.remoteconfig.client 0.751 ms (0.27%)
multiprocessing.sharedctypes 0.130 ms (0.05%)
multiprocessing.heap 0.130 ms (0.05%)
mmap 0.130 ms (0.05%)
ddtrace.internal.products 0.109 ms (0.04%)
importlib.metadata 0.109 ms (0.04%)
zipfile 0.109 ms (0.04%)
zipfile._path 0.109 ms (0.04%)
ddtrace.settings.dynamic_instrumentation 0.022 ms (0.01%)
ddtrace.appsec._common_module_patches 0.163 ms (0.06%)
ddtrace.appsec._asm_request_context 0.163 ms (0.06%)
ddtrace.appsec._utils 0.163 ms (0.06%)
ddtrace._trace.trace_handlers 0.085 ms (0.03%)
ddtrace._trace._inferred_proxy 0.031 ms (0.01%)
ddtrace.propagation.http 0.031 ms (0.01%)
ddtrace.internal._tagset 0.031 ms (0.01%)
ddtrace 1.034 ms (0.37%)
ddtrace._logger 0.142 ms (0.05%)
ddtrace.internal.telemetry 0.142 ms (0.05%)
ddtrace.internal.telemetry.writer 0.104 ms (0.04%)
http.client 0.104 ms (0.04%)
email.parser 0.104 ms (0.04%)
email.feedparser 0.104 ms (0.04%)
email._policybase 0.104 ms (0.04%)
email.header 0.104 ms (0.04%)
email.charset 0.104 ms (0.04%)
ddtrace.settings._agent 0.038 ms (0.01%)
socket 0.038 ms (0.01%)
_socket 0.038 ms (0.01%)
ddtrace.settings._config 0.122 ms (0.04%)
ddtrace.internal.gitmetadata 0.122 ms (0.04%)
ddtrace.ext.ci 0.122 ms (0.04%)
ddtrace.ext.git 0.122 ms (0.04%)
tempfile 0.122 ms (0.04%)
ddtrace.internal._unpatched 0.116 ms (0.04%)
subprocess 0.082 ms (0.03%)
contextlib 0.082 ms (0.03%)
json 0.034 ms (0.01%)
json.decoder 0.034 ms (0.01%)
re 0.034 ms (0.01%)
enum 0.034 ms (0.01%)
types 0.034 ms (0.01%)

@pr-commenter
Copy link

pr-commenter bot commented Jul 10, 2025

Benchmarks

Benchmark execution time: 2025-07-10 14:57:28

Comparing candidate commit a417350 in PR branch backport-13922-to-3.10 with baseline commit 68d1e96 in branch 3.10.

Found 0 performance improvements and 2 performance regressions! Performance is the same for 536 metrics, 4 unstable metrics.

scenario:iastaspects-format_map_aspect

  • 🟥 execution_time [+478.590ns; +533.033ns] or [+14.783%; +16.465%]

scenario:iastaspectsospath-ospathnormcase_aspect

  • 🟥 execution_time [+331.668ns; +411.118ns] or [+9.454%; +11.719%]

@brettlangdon brettlangdon merged commit 1f8c272 into 3.10 Jul 10, 2025
862 of 866 checks passed
@brettlangdon brettlangdon deleted the backport-13922-to-3.10 branch July 10, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants