fix(tracer): add extra service names for all spans #13922
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Circular import analysis🚨 New circular imports detected 🚨The following circular imports among modules have been detected on this PR, when compared to the base branch: Please consider refactoring your changes in accordance to the Separation of Concerns principle. |
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 279 ± 2 ms. The average import time from base is: 281 ± 2 ms. The import time difference between this PR and base is: -2.1 ± 0.1 ms. Import time breakdownThe following import paths have shrunk:
|
BenchmarksBenchmark execution time: 2025-07-10 09:55:12 Comparing candidate commit 71484bb in PR branch Found 0 performance improvements and 2 performance regressions! Performance is the same for 468 metrics, 2 unstable metrics. scenario:iastaspectsospath-ospathsplit_aspect
scenario:iastaspectsospath-ospathsplitext_aspect
|
…eport_extra_service_names_at_finish_span_time
brettlangdon
reviewed
Jul 9, 2025
emmettbutler
approved these changes
Jul 9, 2025
brettlangdon
approved these changes
Jul 9, 2025
releasenotes/notes/report_extra_service_names_from_spans-b98b87fbefe97337.yaml
Outdated
Show resolved
Hide resolved
…7fbefe97337.yaml Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com>
…es_at_finish_span_time
rachelyangdog
approved these changes
Jul 9, 2025
…es_at_finish_span_time
christophe-papazian
deleted the
christophe-papazian/report_extra_service_names_at_finish_span_time
branch
github-actions bot
pushed a commit
that referenced
this pull request
Jul 10, 2025
Add extra service names for all finished spans. From a suggestion of @brettlangdon APPSEC-58108 ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) --------- Co-authored-by: Emmett Butler <723615+emmettbutler@users.noreply.github.com> Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com> (cherry picked from commit ab14f5c)
2 tasks
brettlangdon
added a commit
that referenced
this pull request
Jul 10, 2025
…13943) Backport ab14f5c from #13922 to 3.10. Add extra service names for all finished spans. From a suggestion of @brettlangdon APPSEC-58108 ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) Co-authored-by: brettlangdon <brett.langdon@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add extra service names for all finished spans.
From a suggestion of @brettlangdon
APPSEC-58108
Checklist
Reviewer Checklist