Skip to content

ci: skip flaky gunicorn, botocore and freezegun tests #13662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 13, 2025
Merged

ci: skip flaky gunicorn, botocore and freezegun tests #13662

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f4b0f8c
ci: skip flaky gunicorn and freezegun tests
mabdinur Jun 12, 2025
d195715
fmt
mabdinur Jun 12, 2025
2e772be
add botocore skips
mabdinur Jun 12, 2025
3d06917
Merge branch 'main' into munir/skip-flaky-freeze-gun-gunicorn-tests
emmettbutler Jun 13, 2025
ce39719
skip botocore flakies intead or marking them with a timestamp
mabdinur Jun 13, 2025
52c77a0
Merge branch 'main' into munir/skip-flaky-freeze-gun-gunicorn-tests
wconti27 Jun 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions tests/contrib/botocore/test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1226,6 +1226,7 @@ def test_schematized_unspecified_service_sqs_client_v1(self):
assert spans[2].name == "aws.sqs.receive"

@mock_stepfunctions
@pytest.mark.xfail(reason="Failed to start or connect to state machine")
def test_stepfunctions_send_start_execution_trace_injection(self):
sf = self.session.create_client("stepfunctions", region_name="us-west-2", endpoint_url="http://localhost:4566")
sf.create_state_machine(
Expand All @@ -1249,6 +1250,7 @@ def test_stepfunctions_send_start_execution_trace_injection(self):
sf.delete_state_machine(stateMachineArn="arn:aws:states:us-west-2:000000000000:stateMachine:lincoln")

@mock_stepfunctions
@pytest.mark.xfail(reason="Failed to start or connect to state machine")
def test_stepfunctions_send_start_execution_trace_injection_with_array_input(self):
sf = self.session.create_client("stepfunctions", region_name="us-west-2", endpoint_url="http://localhost:4566")
sf.create_state_machine(
Expand All @@ -1270,6 +1272,7 @@ def test_stepfunctions_send_start_execution_trace_injection_with_array_input(sel
sf.delete_state_machine(stateMachineArn="arn:aws:states:us-west-2:000000000000:stateMachine:miller")

@mock_stepfunctions
@pytest.mark.xfail(reason="Failed to start or connect to state machine")
def test_stepfunctions_send_start_execution_trace_injection_with_true_input(self):
sf = self.session.create_client("stepfunctions", region_name="us-west-2", endpoint_url="http://localhost:4566")
sf.create_state_machine(
Expand Down
2 changes: 2 additions & 0 deletions tests/contrib/freezegun/test_freezegun.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
from ddtrace.internal.utils.time import StopWatch
from ddtrace.trace import tracer as dd_tracer
from tests.contrib.pytest.test_pytest import PytestTestCaseBase
from tests.utils import flaky


class TestFreezegunTestCase:
Expand Down Expand Up @@ -71,6 +72,7 @@ def test_freezegun_configure_default_ignore_list_continues_to_ignore_ddtrace(sel


class PytestFreezegunTestCase(PytestTestCaseBase):
@flaky(1759346444)
def test_freezegun_pytest_plugin(self):
"""Tests that pytest's patching of freezegun in the v1 plugin version works"""
import sys
Expand Down
2 changes: 2 additions & 0 deletions tests/contrib/gunicorn/test_gunicorn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
import pytest

from ddtrace.internal.utils.retry import RetryError # noqa:F401
from tests.utils import flaky
from tests.utils import snapshot_context
from tests.webclient import Client

Expand Down Expand Up @@ -165,6 +166,7 @@ def gunicorn_server(gunicorn_server_settings, tmp_path):
)


@flaky(1759346444, reason="Server startup is flaky in CI. It is unclear whether the server fails to start or shutdown.")
@pytest.mark.skipif(sys.version_info >= (3, 11), reason="Gunicorn is only supported up to 3.10")
def test_no_known_errors_occur(tmp_path):
for gunicorn_server_settings in [
Expand Down
Loading