Skip to content

ci: skip flaky gunicorn, botocore and freezegun tests #13662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 13, 2025

Conversation

mabdinur
Copy link
Contributor

@mabdinur mabdinur commented Jun 12, 2025

Recent Failures on main:

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

github-actions bot commented Jun 12, 2025

CODEOWNERS have been resolved as:

tests/contrib/botocore/test.py                                          @DataDog/apm-core-python @DataDog/apm-idm-python
tests/contrib/freezegun/test_freezegun.py                               @DataDog/ci-app-libraries
tests/contrib/gunicorn/test_gunicorn.py                                 @DataDog/apm-core-python @DataDog/apm-idm-python

@mabdinur mabdinur changed the title ci: skip flaky gunicorn and freezegun tests ci: skip flaky gunicorn, botocore and freezegun tests Jun 12, 2025
@mabdinur mabdinur added the changelog/no-changelog A changelog entry is not required for this PR. label Jun 12, 2025
Copy link
Contributor

github-actions bot commented Jun 13, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 285 ± 4 ms.

The average import time from base is: 289 ± 4 ms.

The import time difference between this PR and base is: -4.3 ± 0.2 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 2.219 ms (0.78%)
ddtrace.bootstrap.sitecustomize 1.526 ms (0.54%)
ddtrace.bootstrap.preload 1.526 ms (0.54%)
ddtrace.internal.remoteconfig.client 0.677 ms (0.24%)
ddtrace 0.693 ms (0.24%)
ddtrace.internal._unpatched 0.035 ms (0.01%)
json 0.035 ms (0.01%)
json.decoder 0.035 ms (0.01%)
re 0.035 ms (0.01%)
enum 0.035 ms (0.01%)
types 0.035 ms (0.01%)

@pr-commenter
Copy link

pr-commenter bot commented Jun 13, 2025

Benchmarks

Benchmark execution time: 2025-06-13 17:32:52

Comparing candidate commit 52c77a0 in PR branch munir/skip-flaky-freeze-gun-gunicorn-tests with baseline commit 02341fe in branch main.

Found 0 performance improvements and 2 performance regressions! Performance is the same for 559 metrics, 3 unstable metrics.

scenario:iastaspectssplit-splitlines_aspect

  • 🟥 execution_time [+115.485ns; +150.746ns] or [+7.855%; +10.253%]

scenario:telemetryaddmetric-1-gauge-metric-1-times

  • 🟥 execution_time [+211.279ns; +249.905ns] or [+9.674%; +11.443%]

Copy link
Collaborator

@emmettbutler emmettbutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@emmettbutler emmettbutler enabled auto-merge (squash) June 13, 2025 13:10
@mabdinur mabdinur force-pushed the munir/skip-flaky-freeze-gun-gunicorn-tests branch from 18782a3 to ce39719 Compare June 13, 2025 16:32
@brettlangdon brettlangdon disabled auto-merge June 13, 2025 17:58
@brettlangdon brettlangdon merged commit 9df7110 into main Jun 13, 2025
380 checks passed
@brettlangdon brettlangdon deleted the munir/skip-flaky-freeze-gun-gunicorn-tests branch June 13, 2025 17:59
github-actions bot pushed a commit that referenced this pull request Jun 13, 2025
Recent Failures on main:
- Freezegun:
https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-py/-/jobs/980088085
- gunicorn:
https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-py/-/jobs/977203066
- botocore:
https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-py/-/jobs/980093469

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

---------

Co-authored-by: Emmett Butler <723615+emmettbutler@users.noreply.github.com>
Co-authored-by: William Conti <58711692+wconti27@users.noreply.github.com>
(cherry picked from commit 9df7110)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.21 changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants