Skip to content

refactor(di): rename upload_flush_interval to upload_interval_seconds #13645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2025

Conversation

tylfin
Copy link
Contributor

@tylfin tylfin commented Jun 11, 2025

Rename upload_flush_interval to upload_interval_seconds

  • Rename upload_flush_interval config to upload_interval_seconds
  • Add deprecation support for old upload.flush_interval config key
  • Update uploader to use new config attribute name
  • Deprecated config will be removed in version 4.0
  • Add a release note documenting the change

Using the old option will raise the following warning:

DeprecationWarning: DD_DYNAMIC_INSTRUMENTATION_UPLOAD_FLUSH_INTERVAL has been deprecated and will be removed in version 4.0. Use DD_DYNAMIC_INSTRUMENTATION_UPLOAD_INTERVAL_SECONDS instead

Refs: DEBUG-3997

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

github-actions bot commented Jun 11, 2025

CODEOWNERS have been resolved as:

releasenotes/notes/refactor-di-upload-interval-env-var-fea1f3a2d6ba6e52.yaml  @DataDog/apm-python
ddtrace/debugging/_uploader.py                                          @DataDog/debugger-python
ddtrace/settings/dynamic_instrumentation.py                             @DataDog/debugger-python
tests/telemetry/test_writer.py                                          @DataDog/apm-python

@tylfin tylfin force-pushed the tyler.finethy/DEBUG-3997 branch from a5a0e2b to 212cdea Compare June 11, 2025 16:56
@tylfin tylfin marked this pull request as ready for review June 11, 2025 16:59
@tylfin tylfin requested review from a team as code owners June 11, 2025 16:59
@tylfin tylfin requested review from taegyunkim and tabgok June 11, 2025 16:59
@tylfin tylfin force-pushed the tyler.finethy/DEBUG-3997 branch from 212cdea to b4dfbe1 Compare June 11, 2025 16:59
Copy link
Contributor

github-actions bot commented Jun 11, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 275 ± 2 ms.

The average import time from base is: 277 ± 2 ms.

The import time difference between this PR and base is: -2.3 ± 0.1 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 2.044 ms (0.74%)
ddtrace.bootstrap.sitecustomize 1.361 ms (0.50%)
ddtrace.bootstrap.preload 1.361 ms (0.50%)
ddtrace.internal.remoteconfig.client 0.647 ms (0.24%)
ddtrace 0.683 ms (0.25%)
ddtrace.internal._unpatched 0.032 ms (0.01%)
json 0.032 ms (0.01%)
json.decoder 0.032 ms (0.01%)
re 0.032 ms (0.01%)
enum 0.032 ms (0.01%)
types 0.032 ms (0.01%)

…nds`

- Rename upload_flush_interval config to upload_interval_seconds
- Add deprecation support for old upload.flush_interval config key
- Update uploader to use new config attribute name
- Deprecated config will be removed in version 4.0
- Add a release note documenting the change

Refs: DEBUG-3997
@tylfin tylfin force-pushed the tyler.finethy/DEBUG-3997 branch from b4dfbe1 to 1eb27ab Compare June 11, 2025 17:45
@pr-commenter
Copy link

pr-commenter bot commented Jun 11, 2025

Benchmarks

Benchmark execution time: 2025-06-11 18:38:34

Comparing candidate commit 1eb27ab in PR branch tyler.finethy/DEBUG-3997 with baseline commit fae0efb in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 561 metrics, 3 unstable metrics.

@tylfin tylfin requested a review from P403n1x87 June 11, 2025 19:07
@tylfin tylfin merged commit 1d0d5b3 into main Jun 11, 2025
367 of 368 checks passed
@tylfin tylfin deleted the tyler.finethy/DEBUG-3997 branch June 11, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants