refactor(di): rename upload_flush_interval to upload_interval_seconds

- Rename upload_flush_interval config to upload_interval_seconds
- Add deprecation support for old upload.flush_interval config key
- Update uploader to use new config attribute name
- Deprecated config will be removed in version 4.0
- Add a release note documenting the change

Refs: DEBUG-3997

Author: tylfin

ddtrace/debugging/_uploader.py

@@ -45,7 +45,7 @@ class LogsIntakeUploaderV1(ForksafeAwakeablePeriodicService):
     RETRY_ATTEMPTS = 3
 
     def __init__(self, interval: Optional[float] = None) -> None:
-        super().__init__(interval if interval is not None else di_config.upload_flush_interval)
+        super().__init__(interval if interval is not None else di_config.upload_interval_seconds)
 
         self._queue = self.__queue__(encoder=LogSignalJsonEncoder(di_config.service_name), on_full=self._on_buffer_full)
         self._collector = self.__collector__(self._queue)

ddtrace/settings/dynamic_instrumentation.py

@@ -86,12 +86,13 @@ class DynamicInstrumentationConfig(DDConfig):
         help="Timeout in seconds for uploading Dynamic Instrumentation payloads",
     )
 
-    upload_flush_interval = DDConfig.v(
+    upload_interval_seconds = DDConfig.v(
         float,
-        "upload.flush_interval",
+        "upload.interval_seconds",
         default=1.0,  # seconds
         help_type="Float",
         help="Interval in seconds for flushing the dynamic logs upload queue",
+        deprecations=[("upload.flush_interval", None, "4.0")],
     )
 
     diagnostics_interval = DDConfig.v(

releasenotes/notes/refactor-di-upload-interval-env-var-fea1f3a2d6ba6e52.yaml

@@ -0,0 +1,6 @@
+---
+deprecations:
+  - |
+    dynamic instrumentation: The ``DD_DYNAMIC_INSTRUMENTATION_UPLOAD_FLUSH_INTERVAL`` environment variable has been
+    deprecated in favor of ``DD_DYNAMIC_INSTRUMENTATION_UPLOAD_INTERVAL_SECONDS``. The old environment variable will be
+    removed in a future major release.