-
Notifications
You must be signed in to change notification settings - Fork 339
test: clean up usage of agent.assertTelemetryReceived #5883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Overall package sizeSelf size: 9.66 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.6.0 | 30.47 MB | 30.47 MB | | @datadog/native-appsec | 8.5.2 | 19.33 MB | 19.34 MB | | @datadog/native-iast-taint-tracking | 4.0.0 | 11.72 MB | 11.73 MB | | @datadog/pprof | 5.8.2 | 9.56 MB | 9.93 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.5.3 | 2.95 MB | 5.6 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.14.0 | 120.58 kB | 841.68 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | istanbul-lib-coverage | 3.2.2 | 34.37 kB | 34.37 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | dc-polyfill | 0.1.9 | 25.11 kB | 25.11 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.2 | 23.54 kB | 23.54 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.4 | 3.96 kB | 3.96 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5883 +/- ##
=======================================
Coverage 80.74% 80.74%
=======================================
Files 462 462
Lines 19905 19905
=======================================
Hits 16073 16073
Misses 3832 3832 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3c01f75
to
cb78aba
Compare
BenchmarksBenchmark execution time: 2025-06-13 08:41:46 Comparing candidate commit 76ce8d0 in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 1271 metrics, 51 unstable metrics. scenario:shimmer-runtime-declared-wrap-20
|
Datadog ReportBranch report: ✅ 0 Failed, 1256 Passed, 0 Skipped, 21m 55.97s Total Time |
f81c6d6
to
7c86640
Compare
Ensure that: - We always await calls to `agent.assertTelemetryReceived` (instead of either ignoring the promise, or chaining a `.then()` call) - We always use a reasonable timeout. Addionally, `agent.assertTelemetryReceived` is updated to allow the function to be optional. A bug in `assertObjectContains` is also fixed to allow arrays to be checked.
7c86640
to
90e1615
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ensure that: - We always await calls to `agent.assertTelemetryReceived` (instead of either ignoring the promise, or chaining a `.then()` call) - We always use a reasonable timeout. Additionally, `agent.assertTelemetryReceived` is updated to allow the function to be optional. A bug in `assertObjectContains` is also fixed to allow arrays to be checked. * Address review comments
What does this PR do?
Ensure that:
agent.assertTelemetryReceived
(instead of either ignoring the promise, or chaining a.then()
call)Addionally,
agent.assertTelemetryReceived
is updated to allow the function to be optional.A bug in
assertObjectContains
is also fixed to allow arrays to be checked.Motivation
This is essentially a follow up PR to: #5374
In the cases where the promise was ignored, the test would time out if the content of the function ever threw, instead of actually showing the thrown error.
I also wanted a chance to fix the bug in
assertObjectContains
.Plugin Checklist
Additional Notes