v5.57.0 proposal #5893
Draft
v5.57.0 proposal #5893
+4,340
−1,464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dd-trace-js[bot]](https://avatars.githubusercontent.com/in/1216021?s=60&v=4){kind=small}
…imental (#5865) * Deprecate DD_TRACE_EXPERIMENTAL_RUNTIME_ID_ENABLED for DD_RUNTIME_METRICS_RUNTIME_ID_ENABLED
* Add blocking for fastify query and body * query params channel name * sort channels * add fastify appsec test * fix http header fingerprint * change rules name * fix fingerprint test * add schema validation tests * linter
Overall package sizeSelf size: 9.74 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.7.0 | 35.02 MB | 35.02 MB | | @datadog/native-appsec | 8.5.2 | 19.33 MB | 19.34 MB | | @datadog/native-iast-taint-tracking | 4.0.0 | 11.72 MB | 11.73 MB | | @datadog/pprof | 5.8.2 | 9.56 MB | 9.93 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.5.3 | 2.95 MB | 5.6 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.14.0 | 120.58 kB | 841.68 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | istanbul-lib-coverage | 3.2.2 | 34.37 kB | 34.37 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | dc-polyfill | 0.1.9 | 25.11 kB | 25.11 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.2 | 23.54 kB | 23.54 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.4 | 3.96 kB | 3.96 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v5.x #5893 +/- ##
=======================================
Coverage ? 79.90%
=======================================
Files ? 450
Lines ? 19571
Branches ? 0
=======================================
Hits ? 15638
Misses ? 3933
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Datadog ReportBranch report: ✅ 0 Failed, 1016 Passed, 0 Skipped, 12m 42.63s Total Time |
BenchmarksBenchmark execution time: 2025-06-24 05:19:46 Comparing candidate commit e1074ca in PR branch Found 0 performance improvements and 7 performance regressions! Performance is the same for 1270 metrics, 46 unstable metrics. scenario:startup-with-tracer-18
scenario:startup-with-tracer-20
scenario:startup-with-tracer-22
|
Without this fix the `requirements_json_test` test in GitLab would fail due to issues with the version of Go being used. The automated script that updates this file hasn't yet been fixed, so we're updating this file manually for now to unblock eveyone.
Ensure that: - We always await calls to `agent.assertTelemetryReceived` (instead of either ignoring the promise, or chaining a `.then()` call) - We always use a reasonable timeout. Additionally, `agent.assertTelemetryReceived` is updated to allow the function to be optional. A bug in `assertObjectContains` is also fixed to allow arrays to be checked. * Address review comments
dd-trace-js
bot
force-pushed
the
v5.57.0-proposal
branch
from
fc27f7a to
0053d9c
Compare
dd-trace-js
bot
force-pushed
the
v5.57.0-proposal
branch
from
0053d9c to
8b0167f
Compare
…t of dependencies in TIA (#5885)
Fix __dirname and __filename in esbuild + esm by adding globals to the banner option.
dd-trace-js
bot
force-pushed
the
v5.57.0-proposal
branch
from
8b0167f to
4833fe3
Compare
Allow blocking on fastify path params
dd-trace-js
bot
force-pushed
the
v5.57.0-proposal
branch
from
4833fe3 to
01f82b7
Compare
Co-authored-by: John Huffsmith <johnhuffsmith@gmail.com>
Co-authored-by: Jean Cornic <jean.cornic@gmail.com>
* Update mocha to ^v11.6.0 * Make sure we use old mocha for guardrails and update version range This allows to update mocha for our main tests still supporting the guardrails properly. On top of that, update the guardrails version range to run on newer versions and reduce obsolete entries.
…5901) * Detect destructuring process.env and use the config-helper instead * Add missing configuration * Add two more missing configurations and rename testing env
dd-trace-js
bot
force-pushed
the
v5.57.0-proposal
branch
from
01f82b7 to
6ef4328
Compare
Use private members and predefined private fields instead of prefixing with an underscore.
If a given log level isn't active, reduce the amount of work required to call it, by fully utilizing either the delegate feature or the support for printf-style log messages.
When an error is logged, its message is redacted unless it's originating
from with the tracer.
Previously it would only detect it as coming from within the tracer if
the filepath was within the `packages` directory. This meant that some
errors originating from the tracer would be redacted even though they
shouldn't.
This problem can be traced back to the following PR:
#3593
Co-authored-by: Ugaitz Urien <ugaitz.urien@datadoghq.com>
dd-trace-js
bot
force-pushed
the
v5.57.0-proposal
branch
from
6ef4328 to
82a857f
Compare
* feat(tracer): implement process discovery feature Resolves [APMAPI-1071]
…egative (#5923) If the tracer was configured with a negative `flushInterval`, it would never flush its internal state to the agent and would keep consuming memory indefinitely until either the process exited naturally, or ran out of memory. Other minor code changes: - Once a timer has fired, there's no need to call `clearTimeout` on it. - Additionally, the fact that `clearTimeout` returns `undefined`, is just because it doesn't return anything. So if we want to set the reference to the timer to `undefined`, just do so directly instead of relying on the return value of `clearTimeout`.
Next to the prisma instrumentation this is also improving the way externals is able to install additional dependencies in our test setup. The dependency version may now be pinned to the main dependency version to align these by specifying the main dependency as `dep`. --------- Co-authored-by: Thomas Hunter II <tlhunter@datadog.com> Co-authored-by: Crystal Magloire <crys.magloire@gmail.com> Co-authored-by: Ruben Bridgewater <ruben.bridgewater@datadoghq.com> Co-authored-by: Roch Devost <roch.devost@datadoghq.com>
…#5934) * fix hook function * add test * call hook function only if it exists
dd-trace-js
bot
force-pushed
the
v5.57.0-proposal
branch
from
82a857f to
e1074ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
29704cf1d3] - (SEMVER-PATCH) fix(esbuild): call the hook function properly in the bundler register (Sam Brenner) #5934205a001804] - (SEMVER-MINOR) Enable log injection by default for structured loggers (Ida Liu) #5859fc288e787f] - (SEMVER-PATCH) Update .gitlab/one-pipeline.locked.yml (Pawel Chojnacki) #5932b269a7265f] - (SEMVER-MINOR) Support for Prisma client library (Bowen Brooks) #56059f9568b531] - (SEMVER-PATCH) docs: fix bug in docs related to running tests (Thomas Watson) #59264e420cb097] - (SEMVER-PATCH) Ensure collected data is sent to the agent even if flushInterval is negative (Thomas Watson) #5923a65d07496b] - (SEMVER-PATCH) Code cleanup: Improve calculation of number of bytes in string (Thomas Watson) #5924fbbccfcba5] - (SEMVER-PATCH) feat(tracer): implement process discovery feature (Damien Mehala) #5782edc2adadee] - (SEMVER-PATCH) [DI] Improve internal timer performance (Thomas Watson) #592242ce94b5b8] - (SEMVER-PATCH) Fix detection of stacks originating from dd-trace (Thomas Watson) #5773f7ab8518f4] - (SEMVER-PATCH) ci(langchain): skip latest langchain in ci until mocking is fixed (Sam Brenner) #59192ce554fc81] - (SEMVER-PATCH) Reduce computation overhead for inactive complex log messages (Thomas Watson) #591627eb1c81ca] - (SEMVER-PATCH) Clean up code in Crashtracker class (Thomas Watson) #5917a408cd7251] - (SEMVER-PATCH) Detect destructuring process.env and use the config-helper instead (Ruben Bridgewater) #590166dede60bc] - (SEMVER-PATCH) Update mocha to ^v11.6.0 (Ruben Bridgewater) #59082f99f419bf] - (SEMVER-PATCH) Simplify config.js by removing _setValue helper (Ruben Bridgewater) #5855d3ab99e957] - (SEMVER-PATCH) fix: Add mongo heartbeatEnabled param to tracer entrypoint (Ruben Bridgewater) #5912b263285831] - (SEMVER-PATCH) wrapCommandQueueClass fix super call (Ruben Bridgewater) #5911c2c9f5090e] - (SEMVER-MINOR) Support schema extraction in fastify response objects (Ilyas Shabi) #5894020c925d41] - (SEMVER-MINOR) Allow blocking on fastify path params (Ilyas Shabi) #5889f88b9af3b1] - (SEMVER-PATCH) Fix flakiness detection script typo (Roch Devost) #5907778def8b0e] - (SEMVER-PATCH) update flakiness report with min occurrences and merge matrix runs (Roch Devost) #590065e18d06b0] - (SEMVER-PATCH) Improve support for esbuild + esm with DD_BUILD_ESM env var (Ugaitz Urien) #58887e544f6a92] - (SEMVER-PATCH) Remove explicit AbortSignal reason (Carles Capell) #59049f903dd3f9] - (SEMVER-PATCH) [test-optimization] [SDTEST-1060] Add mocked files of Jest to the list of dependencies in TIA (Mario Vidal Domínguez) #588507e9939bd8] - (SEMVER-MINOR) Revert "Revert "Update to libdatadog-nodejs 0.7.0 (Update to libdatadog-nodejs 0.7.0 #5896)" (Revert "Update to libdatadog-nodejs 0.7.0 (#5896)" #5902)" (Attila Szegedi) #5905bf64a9cb1e] - (SEMVER-PATCH) test: sort config value assertions (Thomas Watson) #58999b3d7fdec6] - (SEMVER-PATCH) [test optimization] Improve flakiness of performance overhead test (Juan Antonio Fernández de Alba) #5898e9b2b58bc6] - (SEMVER-MINOR) [test optimization] Update test optimization spec (Juan Antonio Fernández de Alba) #5897a8b71852b5] - (SEMVER-PATCH) Revert "Update to libdatadog-nodejs 0.7.0 (Update to libdatadog-nodejs 0.7.0 #5896)" (Thomas Watson) #5902b4cfa7fff2] - (SEMVER-PATCH) [test-optimization] [SDTEST-2163] Check framework version in capabilities tagging (Mario Vidal Domínguez) #5876024282b2c1] - (SEMVER-PATCH) Fix router not working with deeply nested middleware (Ruben Bridgewater) #58909a8a6ec87b] - (SEMVER-MINOR) Update to libdatadog-nodejs 0.7.0 (Attila Szegedi) #58967e95984d09] - (SEMVER-PATCH) test: clean up usage of agent.assertTelemetryReceived (Thomas Watson) #5883b9e0157602] - (SEMVER-PATCH) ci: fix bug with GitLab CI (Thomas Watson) #5895b800822fab] - (SEMVER-PATCH) add explicit main ref when checking out system tests in workflow (Roch Devost) #58920b3ab0c4c6] - (SEMVER-MINOR) chore(ssi): send injection and instrumentation telemetry (Munir Abdinur) #572172597c5433] - (SEMVER-MINOR) Add blocking for fastify query and body (Ilyas Shabi) #5806b249c2e4d1] - (SEMVER-MINOR) Reduce false positives when unvalidated redirect vulnerability is detected (Ugaitz Urien) #5880601885daa2] - (SEMVER-MINOR) feat: add config DD_RUNTIME_METRICS_RUNTIME_ID_ENABLED / remove experimental (Anna) #5865