Skip to content

feat: add config DD_TRACE_RUNTIME_ID_ENABLED / remove experimental #5865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 12, 2025

Conversation

anna-git
Copy link
Contributor

@anna-git anna-git commented Jun 10, 2025

What does this PR do?

Add the additional envar DD_RUNTIME_METRICS_RUNTIME_ID_ENABLED to enable the config runtime_metrics.experimental_runtime_id_enabled as we want to move this out of being an experimental feature.

Motivation

This is useful for tracking runtime metrics across multiple processes. Previously, this was DD_TRACE_EXPERIMENTAL_RUNTIME_ID_ENABLED.

Plugin Checklist

Additional Notes

Copy link

github-actions bot commented Jun 10, 2025

Overall package size

Self size: 9.64 MB
Deduped: 104.59 MB
No deduping: 105.11 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.6.0 | 30.47 MB | 30.47 MB | | @datadog/native-appsec | 8.5.2 | 19.33 MB | 19.34 MB | | @datadog/pprof | 5.8.0 | 12.55 MB | 12.92 MB | | @datadog/native-iast-taint-tracking | 4.0.0 | 11.72 MB | 11.73 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.5.3 | 2.95 MB | 5.6 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.14.0 | 120.58 kB | 841.68 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | istanbul-lib-coverage | 3.2.2 | 34.37 kB | 34.37 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | dc-polyfill | 0.1.9 | 25.11 kB | 25.11 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.2 | 23.54 kB | 23.54 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.4 | 3.96 kB | 3.96 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Jun 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.75%. Comparing base (145dcd7) to head (9fca8a3).
Report is 19 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5865      +/-   ##
==========================================
+ Coverage   80.71%   80.75%   +0.03%     
==========================================
  Files         464      464              
  Lines       19875    19911      +36     
==========================================
+ Hits        16043    16080      +37     
+ Misses       3832     3831       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link

pr-commenter bot commented Jun 10, 2025

Benchmarks

Benchmark execution time: 2025-06-11 14:08:08

Comparing candidate commit 9fca8a3 in PR branch anna/remove-experimental-runtime-id with baseline commit 145dcd7 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1268 metrics, 55 unstable metrics.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jun 10, 2025

Datadog Report

Branch report: anna/remove-experimental-runtime-id
Commit report: de72f3a
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 1255 Passed, 0 Skipped, 21m 21.58s Total Time

@anna-git anna-git force-pushed the anna/remove-experimental-runtime-id branch from cb9f3f0 to 98f49d4 Compare June 11, 2025 09:40
Copy link
Collaborator

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just had a brief look and this is almost LGTM. I guess this could be changed to a PR or is it intentionally still a draft to change more?

I just left some minor improvement suggestions.

@anna-git anna-git marked this pull request as ready for review June 11, 2025 13:48
@anna-git anna-git requested a review from a team as a code owner June 11, 2025 13:48
anna-git and others added 3 commits June 11, 2025 15:49
Copy link
Collaborator

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@BridgeAR BridgeAR merged commit 601885d into master Jun 12, 2025
535 checks passed
@BridgeAR BridgeAR deleted the anna/remove-experimental-runtime-id branch June 12, 2025 11:11
dd-trace-js bot pushed a commit that referenced this pull request Jun 13, 2025
…imental (#5865)

* Deprecate  DD_TRACE_EXPERIMENTAL_RUNTIME_ID_ENABLED for DD_RUNTIME_METRICS_RUNTIME_ID_ENABLED
@dd-trace-js dd-trace-js bot mentioned this pull request Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants