Skip to content

Test profiling sample context propagation through promises #5740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 16, 2025
Merged

Test profiling sample context propagation through promises #5740

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d10b0df
Test sample context propagation through promises too
szegedi May 15, 2025
0e511ea
Merge branch 'master' into szegedi/test-promise-sample-context
szegedi May 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions integration-tests/profiler/codehotspots.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ function runBusySpans () {
for (let i = 0; i < 3; ++i) {
const z = i
tracer.trace('y' + i, (_, done2) => {
setTimeout(() => {
const busyWork = () => {
busyLoop()
done2()
if (z === 2) {
Expand All @@ -43,7 +43,17 @@ function runBusySpans () {
}
done()
}
}, 0)
}
if (i === 1) {
// Exercise sample context propagation through a promise
const p = new Promise((resolve) => {
setTimeout(resolve, 0)
})
p.then(busyWork)
} else {
// Exercise sample context propagation through a timeout
setTimeout(busyWork, 0)
}
})
}
})
Expand Down