Skip to content

Conversation

@szegedi
Copy link
Contributor

@szegedi szegedi commented May 16, 2025

What does this PR do?

Of three internal iterations in traces in codehotspots.js test program, make the middle one use promises instead of a timeout for asynchronous work chaining.

Motivation

Our integration test wasn't verifying that profiler sample context is correctly preserved across promise chains. No bug is being fixed – this works, I just wanted to increase functionality coverage.

@github-actions
Copy link

github-actions bot commented May 16, 2025

Overall package size

Self size: 9.37 MB
Deduped: 103.4 MB
No deduping: 103.92 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.5.1 | 29.73 MB | 29.73 MB | | @datadog/native-appsec | 8.5.2 | 19.33 MB | 19.34 MB | | @datadog/pprof | 5.8.0 | 12.55 MB | 12.92 MB | | @datadog/native-iast-taint-tracking | 4.0.0 | 11.72 MB | 11.73 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.4.0 | 2.77 MB | 5.42 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.13.1 | 117.64 kB | 839.26 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | dc-polyfill | 0.1.8 | 25.08 kB | 25.08 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.2 | 23.54 kB | 23.54 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@szegedi szegedi changed the title Test sample context propagation through promises too Test profiling sample context propagation through promises May 16, 2025
@codecov
Copy link

codecov bot commented May 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.98%. Comparing base (0672b4d) to head (0e511ea).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5740      +/-   ##
==========================================
- Coverage   79.04%   78.98%   -0.07%     
==========================================
  Files         515      514       -1     
  Lines       23589    23517      -72     
==========================================
- Hits        18647    18574      -73     
- Misses       4942     4943       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented May 16, 2025

Datadog Report

Branch report: szegedi/test-promise-sample-context
Commit report: be94d5c
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 987 Passed, 0 Skipped, 15m 19.72s Total Time

@szegedi szegedi enabled auto-merge (squash) May 16, 2025 11:02
@szegedi szegedi merged commit 295edf4 into master May 16, 2025
480 of 485 checks passed
@szegedi szegedi deleted the szegedi/test-promise-sample-context branch May 16, 2025 11:08
ghost pushed a commit that referenced this pull request May 17, 2025
@ghost ghost mentioned this pull request May 17, 2025
ghost pushed a commit that referenced this pull request May 20, 2025
@ghost ghost mentioned this pull request May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants