Skip to content

chore(ssi): send injection and instrumentation telemetry #5721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2025

Conversation

mabdinur
Copy link
Contributor

@mabdinur mabdinur commented May 13, 2025

What does this PR do?

Submits the value of DD_INJECT_FORCE and DD_INJECTION_ENABLED (set by the injector) to the instrumentation telemetry platform.

Compute DD_INSTRUMENTATION_SOURCE, this configuration will track whether a processes was successfully instrumented via ssi. This PR adds the values ssi and unknown.

A future PR will track whether the ddtrace products were enabled manually (via imports) or set up only using command line arguments + env_vars (via --require dd-trace/init).

Motivation

We a mechanism to track how services were instrumented, this will allow us to better troubleshoot customer setups and provide meaningful remediation.

Plugin Checklist

Additional Notes

Copy link

github-actions bot commented May 13, 2025

Overall package size

Self size: 9.65 MB
Deduped: 101.6 MB
No deduping: 102.12 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.6.0 | 30.47 MB | 30.47 MB | | @datadog/native-appsec | 8.5.2 | 19.33 MB | 19.34 MB | | @datadog/native-iast-taint-tracking | 4.0.0 | 11.72 MB | 11.73 MB | | @datadog/pprof | 5.8.2 | 9.56 MB | 9.93 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.5.3 | 2.95 MB | 5.6 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.14.0 | 120.58 kB | 841.68 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | istanbul-lib-coverage | 3.2.2 | 34.37 kB | 34.37 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | dc-polyfill | 0.1.9 | 25.11 kB | 25.11 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.2 | 23.54 kB | 23.54 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.4 | 3.96 kB | 3.96 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented May 13, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.67%. Comparing base (b249c2e) to head (dfe847e).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
packages/dd-trace/src/config.js 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5721      +/-   ##
==========================================
+ Coverage   80.51%   80.67%   +0.16%     
==========================================
  Files         459      453       -6     
  Lines       19752    19677      -75     
==========================================
- Hits        15903    15875      -28     
+ Misses       3849     3802      -47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link

pr-commenter bot commented Jun 4, 2025

Benchmarks

Benchmark execution time: 2025-06-11 14:55:27

Comparing candidate commit 719b545 in PR branch munir/track-ssi-instrumentation-source with baseline commit 3c8fe63 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1277 metrics, 46 unstable metrics.

@mabdinur mabdinur force-pushed the munir/track-ssi-instrumentation-source branch 3 times, most recently from bfceda7 to 1917390 Compare June 4, 2025 17:23
@mabdinur mabdinur force-pushed the munir/track-ssi-instrumentation-source branch 2 times, most recently from 097e53c to 4356637 Compare June 4, 2025 17:45
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jun 4, 2025

Datadog Report

Branch report: munir/track-ssi-instrumentation-source
Commit report: 0bde856
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 1257 Passed, 0 Skipped, 20m 51.91s Total Time

@mabdinur mabdinur force-pushed the munir/track-ssi-instrumentation-source branch 5 times, most recently from be1db6a to c6d3f40 Compare June 4, 2025 19:54
@mabdinur mabdinur marked this pull request as ready for review June 6, 2025 17:01
@mabdinur mabdinur requested a review from a team as a code owner June 6, 2025 17:01
@mabdinur mabdinur requested review from BridgeAR and khanayan123 June 6, 2025 17:01
Copy link
Collaborator

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is mainly LGTM. I believe I overlook something in the tests and have a question around the array being passed through now.

@mabdinur mabdinur force-pushed the munir/track-ssi-instrumentation-source branch from 1034ac8 to 719b545 Compare June 11, 2025 14:48
@mabdinur mabdinur requested a review from BridgeAR June 11, 2025 14:48
Copy link
Collaborator

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@BridgeAR BridgeAR enabled auto-merge (squash) June 12, 2025 13:14
@mabdinur mabdinur force-pushed the munir/track-ssi-instrumentation-source branch from 719b545 to 8dc5a6b Compare June 12, 2025 14:26
@mabdinur mabdinur force-pushed the munir/track-ssi-instrumentation-source branch from dcde24d to dfe847e Compare June 12, 2025 14:33
@BridgeAR BridgeAR merged commit 0b3ab0c into master Jun 12, 2025
406 of 412 checks passed
@BridgeAR BridgeAR deleted the munir/track-ssi-instrumentation-source branch June 12, 2025 14:45
@dd-trace-js dd-trace-js bot mentioned this pull request Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants