Skip to content

Add some checks to avoid runtime errors #4945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 16, 2024
Merged

Conversation

iunanua
Copy link
Contributor

@iunanua iunanua commented Nov 26, 2024

What does this PR do?

Protect some places in the code to prevent access to undefined values

Motivation

Plugin Checklist

Additional Notes

Copy link

github-actions bot commented Nov 26, 2024

Overall package size

Self size: 8.26 MB
Deduped: 94.55 MB
No deduping: 95.07 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.2.2 | 29.27 MB | 29.27 MB | | @datadog/native-appsec | 8.3.0 | 19.37 MB | 19.38 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.4.1 | 9.76 MB | 10.13 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.6.0 | 2.58 MB | 2.72 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.0.1 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@pr-commenter
Copy link

pr-commenter bot commented Nov 26, 2024

Benchmarks

Benchmark execution time: 2024-12-16 11:01:02

Comparing candidate commit 563830e in PR branch igor/check-undefined-values with baseline commit 75865b4 in branch master.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 729 metrics, 18 unstable metrics.

scenario:plugin-graphql-with-async-hooks-22

  • 🟥 max_rss_usage [+98.487MB; +129.389MB] or [+18.341%; +24.096%]

@iunanua iunanua marked this pull request as ready for review November 26, 2024 15:38
@iunanua iunanua requested review from a team as code owners November 26, 2024 15:38
uurien
uurien previously approved these changes Dec 3, 2024
Copy link
Collaborator

@uurien uurien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but it would be worth having another reviewer.

bengl
bengl previously approved these changes Dec 12, 2024
@bengl
Copy link
Collaborator

bengl commented Dec 12, 2024

@iunanua looks like there's a conflict

@iunanua iunanua dismissed stale reviews from bengl and uurien via dcf586b December 13, 2024 08:10
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 12.50000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 64.33%. Comparing base (823cfd4) to head (563830e).
Report is 38 commits behind head on master.

Files with missing lines Patch % Lines
...ace/src/profiling/profilers/event_plugins/event.js 0.00% 6 Missing ⚠️
packages/dd-trace/src/plugins/tracing.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4945      +/-   ##
==========================================
- Coverage   65.05%   64.33%   -0.72%     
==========================================
  Files         304      306       +2     
  Lines       13950    13968      +18     
==========================================
- Hits         9075     8987      -88     
- Misses       4875     4981     +106     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iunanua iunanua merged commit 02fba54 into master Dec 16, 2024
307 checks passed
@iunanua iunanua deleted the igor/check-undefined-values branch December 16, 2024 11:09
@rochdev rochdev mentioned this pull request Dec 17, 2024
rochdev pushed a commit that referenced this pull request Dec 17, 2024
* Add some checks to avoid runtime errors

* check span

* linter
@rochdev rochdev mentioned this pull request Dec 17, 2024
rochdev pushed a commit that referenced this pull request Dec 17, 2024
* Add some checks to avoid runtime errors

* check span

* linter
rochdev pushed a commit that referenced this pull request Dec 18, 2024
* Add some checks to avoid runtime errors

* check span

* linter
rochdev pushed a commit that referenced this pull request Dec 18, 2024
* Add some checks to avoid runtime errors

* check span

* linter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants