Add some checks to avoid runtime errors (#4945)

* Add some checks to avoid runtime errors

* check span

* linter

Author: iunanua

packages/datadog-plugin-avsc/src/schema_iterator.js

@@ -108,10 +108,15 @@ class SchemaExtractor {
       if (!builder.shouldExtractSchema(schemaName, depth)) {
         return false
       }
-      for (const field of schema.fields) {
-        if (!this.extractProperty(field, schemaName, field.name, builder, depth)) {
-          log.warn('DSM: Unable to extract field with name: %s from Avro schema with name: %s', field.name, schemaName)
+      if (schema.fields?.[Symbol.iterator]) {
+        for (const field of schema.fields) {
+          if (!this.extractProperty(field, schemaName, field.name, builder, depth)) {
+            log.warn('DSM: Unable to extract field with name: %s from Avro schema with name: %s', field.name,
+              schemaName)
+          }
         }
+      } else {
+        log.warn('DSM: schema.fields is not iterable from Avro schema with name: %s', schemaName)
       }
     }
     return true

packages/datadog-plugin-grpc/src/client.js

@@ -62,7 +62,7 @@ class GrpcClientPlugin extends ClientPlugin {
     return parentStore
   }
 
-  error ({ span, error }) {
+  error ({ span = this.activeSpan, error }) {
     this.addCode(span, error.code)
     if (error.code && !this._tracerConfig.grpc.client.error.statuses.includes(error.code)) {
       return
@@ -108,7 +108,7 @@ class GrpcClientPlugin extends ClientPlugin {
   }
 
   addCode (span, code) {
-    if (code !== undefined) {
+    if (code !== undefined && span) {
       span.setTag('grpc.status.code', code)
     }
   }

packages/dd-trace/src/opentracing/propagation/text_map.js

@@ -499,7 +499,7 @@ class TextMapPropagator {
   }
 
   _extractGenericContext (carrier, traceKey, spanKey, radix) {
-    if (carrier[traceKey] && carrier[spanKey]) {
+    if (carrier && carrier[traceKey] && carrier[spanKey]) {
       if (invalidSegment.test(carrier[traceKey])) return null
 
       return new DatadogSpanContext({

packages/dd-trace/src/plugins/tracing.js

@@ -94,7 +94,7 @@ class TracingPlugin extends Plugin {
   }
 
   addError (error, span = this.activeSpan) {
-    if (!span._spanContext._tags.error) {
+    if (span && !span._spanContext._tags.error) {
       // Errors may be wrapped in a context.
       error = (error && error.error) || error
       span.setTag('error', error || 1)

packages/dd-trace/src/profiling/profilers/event_plugins/event.js

@@ -21,11 +21,17 @@ class EventPlugin extends TracingPlugin {
   }
 
   error () {
-    this.store.getStore().error = true
+    const store = this.store.getStore()
+    if (store) {
+      store.error = true
+    }
   }
 
   finish () {
-    const { startEvent, startTime, error } = this.store.getStore()
+    const store = this.store.getStore()
+    if (!store) return
+
+    const { startEvent, startTime, error } = store
     if (error) {
       return // don't emit perf events for failed operations
     }