-
Notifications
You must be signed in to change notification settings - Fork 311
Improve comment for mule instrumentation #8772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 66 metrics, 5 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.50.0-SNAPSHOT~cb6fc686f1, baseline=1.49.0-SNAPSHOT~5bfab6549b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.009 s) : 0, 1009213
Total [baseline] (10.504 s) : 0, 10504359
Agent [candidate] (1.016 s) : 0, 1015724
Total [candidate] (10.49 s) : 0, 10489875
section appsec
Agent [baseline] (1.148 s) : 0, 1148083
Total [baseline] (10.674 s) : 0, 10673884
Agent [candidate] (1.155 s) : 0, 1154512
Total [candidate] (10.731 s) : 0, 10731417
section iast
Agent [baseline] (1.139 s) : 0, 1139277
Total [baseline] (10.813 s) : 0, 10813089
Agent [candidate] (1.141 s) : 0, 1140637
Total [candidate] (10.904 s) : 0, 10903875
section profiling
Agent [baseline] (1.27 s) : 0, 1269912
Total [baseline] (10.856 s) : 0, 10856412
Agent [candidate] (1.256 s) : 0, 1255986
Total [candidate] (10.779 s) : 0, 10779365
gantt
title petclinic - break down per module: candidate=1.50.0-SNAPSHOT~cb6fc686f1, baseline=1.49.0-SNAPSHOT~5bfab6549b
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (671.568 ms) : 0, 671568
BytebuddyAgent [candidate] (676.729 ms) : 0, 676729
GlobalTracer [baseline] (240.256 ms) : 0, 240256
GlobalTracer [candidate] (241.876 ms) : 0, 241876
AppSec [baseline] (54.781 ms) : 0, 54781
AppSec [candidate] (54.656 ms) : 0, 54656
Debugger [baseline] (7.657 ms) : 0, 7657
Debugger [candidate] (8.451 ms) : 0, 8451
Remote Config [baseline] (699.417 µs) : 0, 699
Remote Config [candidate] (694.152 µs) : 0, 694
Telemetry [baseline] (10.72 ms) : 0, 10720
Telemetry [candidate] (9.777 ms) : 0, 9777
section appsec
BytebuddyAgent [baseline] (687.921 ms) : 0, 687921
BytebuddyAgent [candidate] (692.5 ms) : 0, 692500
GlobalTracer [baseline] (236.316 ms) : 0, 236316
GlobalTracer [candidate] (237.524 ms) : 0, 237524
AppSec [baseline] (175.283 ms) : 0, 175283
AppSec [candidate] (175.661 ms) : 0, 175661
Debugger [baseline] (5.85 ms) : 0, 5850
Debugger [candidate] (5.874 ms) : 0, 5874
Remote Config [baseline] (633.948 µs) : 0, 634
Remote Config [candidate] (637.686 µs) : 0, 638
Telemetry [baseline] (7.783 ms) : 0, 7783
Telemetry [candidate] (7.801 ms) : 0, 7801
IAST [baseline] (21.8 ms) : 0, 21800
IAST [candidate] (21.934 ms) : 0, 21934
section iast
BytebuddyAgent [baseline] (791.611 ms) : 0, 791611
BytebuddyAgent [candidate] (792.522 ms) : 0, 792522
GlobalTracer [baseline] (230.483 ms) : 0, 230483
GlobalTracer [candidate] (230.859 ms) : 0, 230859
AppSec [baseline] (56.589 ms) : 0, 56589
AppSec [candidate] (56.522 ms) : 0, 56522
Debugger [baseline] (5.916 ms) : 0, 5916
Debugger [candidate] (5.898 ms) : 0, 5898
Remote Config [baseline] (585.278 µs) : 0, 585
Remote Config [candidate] (595.301 µs) : 0, 595
Telemetry [baseline] (7.876 ms) : 0, 7876
Telemetry [candidate] (7.888 ms) : 0, 7888
IAST [baseline] (22.749 ms) : 0, 22749
IAST [candidate] (22.874 ms) : 0, 22874
section profiling
BytebuddyAgent [baseline] (669.72 ms) : 0, 669720
BytebuddyAgent [candidate] (661.789 ms) : 0, 661789
GlobalTracer [baseline] (381.895 ms) : 0, 381895
GlobalTracer [candidate] (378.959 ms) : 0, 378959
AppSec [baseline] (55.297 ms) : 0, 55297
AppSec [candidate] (53.745 ms) : 0, 53745
Debugger [baseline] (6.275 ms) : 0, 6275
Debugger [candidate] (6.168 ms) : 0, 6168
Remote Config [baseline] (667.039 µs) : 0, 667
Remote Config [candidate] (645.904 µs) : 0, 646
Telemetry [baseline] (8.363 ms) : 0, 8363
Telemetry [candidate] (8.181 ms) : 0, 8181
ProfilingAgent [baseline] (97.003 ms) : 0, 97003
ProfilingAgent [candidate] (96.322 ms) : 0, 96322
Profiling [baseline] (97.026 ms) : 0, 97026
Profiling [candidate] (96.346 ms) : 0, 96346
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.50.0-SNAPSHOT~cb6fc686f1, baseline=1.49.0-SNAPSHOT~5bfab6549b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.006 s) : 0, 1006277
Total [baseline] (8.622 s) : 0, 8621978
Agent [candidate] (1.008 s) : 0, 1008365
Total [candidate] (8.623 s) : 0, 8623185
section iast
Agent [baseline] (1.15 s) : 0, 1149587
Total [baseline] (9.229 s) : 0, 9228572
Agent [candidate] (1.139 s) : 0, 1139288
Total [candidate] (9.193 s) : 0, 9192701
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.137 s) : 0, 1137368
Total [baseline] (9.211 s) : 0, 9211269
Agent [candidate] (1.139 s) : 0, 1139036
Total [candidate] (9.172 s) : 0, 9171526
section iast_TELEMETRY_OFF
Agent [baseline] (1.135 s) : 0, 1134872
Total [baseline] (9.171 s) : 0, 9171327
Agent [candidate] (1.135 s) : 0, 1134653
Total [candidate] (9.183 s) : 0, 9182922
gantt
title insecure-bank - break down per module: candidate=1.50.0-SNAPSHOT~cb6fc686f1, baseline=1.49.0-SNAPSHOT~5bfab6549b
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (670.539 ms) : 0, 670539
BytebuddyAgent [candidate] (671.25 ms) : 0, 671250
GlobalTracer [baseline] (239.733 ms) : 0, 239733
GlobalTracer [candidate] (240.076 ms) : 0, 240076
AppSec [baseline] (54.448 ms) : 0, 54448
AppSec [candidate] (54.693 ms) : 0, 54693
Debugger [baseline] (6.931 ms) : 0, 6931
Debugger [candidate] (7.672 ms) : 0, 7672
Remote Config [baseline] (696.979 µs) : 0, 697
Remote Config [candidate] (700.011 µs) : 0, 700
Telemetry [baseline] (10.531 ms) : 0, 10531
Telemetry [candidate] (10.529 ms) : 0, 10529
section iast
BytebuddyAgent [baseline] (797.998 ms) : 0, 797998
BytebuddyAgent [candidate] (791.572 ms) : 0, 791572
GlobalTracer [baseline] (233.157 ms) : 0, 233157
GlobalTracer [candidate] (230.709 ms) : 0, 230709
AppSec [baseline] (57.077 ms) : 0, 57077
AppSec [candidate] (56.231 ms) : 0, 56231
Debugger [baseline] (5.94 ms) : 0, 5940
Debugger [candidate] (5.93 ms) : 0, 5930
Remote Config [baseline] (605.437 µs) : 0, 605
Remote Config [candidate] (590.73 µs) : 0, 591
Telemetry [baseline] (8.078 ms) : 0, 8078
Telemetry [candidate] (7.92 ms) : 0, 7920
IAST [baseline] (23.163 ms) : 0, 23163
IAST [candidate] (22.867 ms) : 0, 22867
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (790.252 ms) : 0, 790252
BytebuddyAgent [candidate] (791.132 ms) : 0, 791132
GlobalTracer [baseline] (230.145 ms) : 0, 230145
GlobalTracer [candidate] (230.881 ms) : 0, 230881
AppSec [baseline] (56.348 ms) : 0, 56348
AppSec [candidate] (56.346 ms) : 0, 56346
Debugger [baseline] (5.843 ms) : 0, 5843
Debugger [candidate] (5.894 ms) : 0, 5894
Remote Config [baseline] (579.927 µs) : 0, 580
Remote Config [candidate] (592.785 µs) : 0, 593
Telemetry [baseline] (7.854 ms) : 0, 7854
Telemetry [candidate] (7.895 ms) : 0, 7895
IAST [baseline] (22.871 ms) : 0, 22871
IAST [candidate] (22.821 ms) : 0, 22821
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (787.833 ms) : 0, 787833
BytebuddyAgent [candidate] (787.797 ms) : 0, 787797
GlobalTracer [baseline] (230.631 ms) : 0, 230631
GlobalTracer [candidate] (230.738 ms) : 0, 230738
AppSec [baseline] (56.258 ms) : 0, 56258
AppSec [candidate] (56.03 ms) : 0, 56030
Debugger [baseline] (5.904 ms) : 0, 5904
Debugger [candidate] (5.964 ms) : 0, 5964
Remote Config [baseline] (608.418 µs) : 0, 608
Remote Config [candidate] (609.975 µs) : 0, 610
Telemetry [baseline] (7.772 ms) : 0, 7772
Telemetry [candidate] (7.802 ms) : 0, 7802
IAST [baseline] (22.436 ms) : 0, 22436
IAST [candidate] (22.303 ms) : 0, 22303
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 18 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~cb6fc686f1, baseline=1.49.0-SNAPSHOT~5bfab6549b
dateFormat X
axisFormat %s
section baseline
no_agent (382.417 µs) : 362, 403
. : milestone, 382,
iast (531.663 µs) : 509, 555
. : milestone, 532,
iast_FULL (738.236 µs) : 715, 762
. : milestone, 738,
iast_GLOBAL (573.67 µs) : 550, 597
. : milestone, 574,
iast_HARDCODED_SECRET_DISABLED (525.679 µs) : 503, 548
. : milestone, 526,
iast_INACTIVE (470.251 µs) : 448, 493
. : milestone, 470,
iast_TELEMETRY_OFF (517.285 µs) : 494, 541
. : milestone, 517,
tracing (464.678 µs) : 442, 487
. : milestone, 465,
section candidate
no_agent (382.106 µs) : 362, 402
. : milestone, 382,
iast (518.365 µs) : 494, 542
. : milestone, 518,
iast_FULL (747.402 µs) : 724, 771
. : milestone, 747,
iast_GLOBAL (579.713 µs) : 556, 603
. : milestone, 580,
iast_HARDCODED_SECRET_DISABLED (531.041 µs) : 508, 554
. : milestone, 531,
iast_INACTIVE (472.093 µs) : 450, 494
. : milestone, 472,
iast_TELEMETRY_OFF (504.08 µs) : 482, 527
. : milestone, 504,
tracing (458.231 µs) : 436, 480
. : milestone, 458,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~cb6fc686f1, baseline=1.49.0-SNAPSHOT~5bfab6549b
dateFormat X
axisFormat %s
section baseline
no_agent (1.377 ms) : 1358, 1397
. : milestone, 1377,
appsec (1.738 ms) : 1714, 1762
. : milestone, 1738,
appsec_no_iast (1.736 ms) : 1712, 1760
. : milestone, 1736,
code_origins (1.669 ms) : 1642, 1696
. : milestone, 1669,
iast (1.512 ms) : 1487, 1536
. : milestone, 1512,
profiling (1.548 ms) : 1522, 1573
. : milestone, 1548,
tracing (1.504 ms) : 1480, 1529
. : milestone, 1504,
section candidate
no_agent (1.378 ms) : 1358, 1398
. : milestone, 1378,
appsec (1.746 ms) : 1722, 1770
. : milestone, 1746,
appsec_no_iast (1.735 ms) : 1712, 1759
. : milestone, 1735,
code_origins (1.699 ms) : 1672, 1726
. : milestone, 1699,
iast (1.527 ms) : 1502, 1552
. : milestone, 1527,
profiling (1.533 ms) : 1510, 1557
. : milestone, 1533,
tracing (1.515 ms) : 1490, 1540
. : milestone, 1515,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~cb6fc686f1, baseline=1.49.0-SNAPSHOT~5bfab6549b
dateFormat X
axisFormat %s
section baseline
no_agent (1.482 ms) : 1470, 1493
. : milestone, 1482,
appsec (2.418 ms) : 2368, 2467
. : milestone, 2418,
iast (2.19 ms) : 2128, 2252
. : milestone, 2190,
iast_GLOBAL (2.241 ms) : 2178, 2303
. : milestone, 2241,
profiling (2.053 ms) : 2002, 2103
. : milestone, 2053,
tracing (2.023 ms) : 1975, 2071
. : milestone, 2023,
section candidate
no_agent (1.484 ms) : 1472, 1496
. : milestone, 1484,
appsec (2.417 ms) : 2368, 2466
. : milestone, 2417,
iast (2.201 ms) : 2139, 2264
. : milestone, 2201,
iast_GLOBAL (2.231 ms) : 2169, 2294
. : milestone, 2231,
profiling (2.061 ms) : 2010, 2112
. : milestone, 2061,
tracing (2.015 ms) : 1967, 2063
. : milestone, 2015,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~cb6fc686f1, baseline=1.49.0-SNAPSHOT~5bfab6549b
dateFormat X
axisFormat %s
section baseline
no_agent (15.557 s) : 15557000, 15557000
. : milestone, 15557000,
appsec (14.918 s) : 14918000, 14918000
. : milestone, 14918000,
iast (18.816 s) : 18816000, 18816000
. : milestone, 18816000,
iast_GLOBAL (18.181 s) : 18181000, 18181000
. : milestone, 18181000,
profiling (14.992 s) : 14992000, 14992000
. : milestone, 14992000,
tracing (15.225 s) : 15225000, 15225000
. : milestone, 15225000,
section candidate
no_agent (14.747 s) : 14747000, 14747000
. : milestone, 14747000,
appsec (14.946 s) : 14946000, 14946000
. : milestone, 14946000,
iast (18.835 s) : 18835000, 18835000
. : milestone, 18835000,
iast_GLOBAL (17.685 s) : 17685000, 17685000
. : milestone, 17685000,
profiling (15.489 s) : 15489000, 15489000
. : milestone, 15489000,
tracing (15.129 s) : 15129000, 15129000
. : milestone, 15129000,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the improved doc!
What Does This Do
Improve comment in the
build.gradle
file for mule instrumentation.Motivation
I made the original comment in #8731 and think it can be improved.
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]