Skip to content

Revert "Update config line to account for large binary files" #8731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 25, 2025
Merged

Revert "Update config line to account for large binary files" #8731

merged 3 commits into from
Apr 25, 2025

Conversation

sarahchen6
Copy link
Contributor

@sarahchen6 sarahchen6 commented Apr 24, 2025 •
edited
Loading

Reverts #8709

This change is unnecessary given our excluding extra classes in the latest byte-buddy upgrade. It also caused us to miss some testing on PRs, namely with #8720 (resolved by #8728).

@sarahchen6 sarahchen6 requested a review from nayeem-kamal April 24, 2025 20:05
@sarahchen6 sarahchen6 marked this pull request as ready for review April 24, 2025 20:21
@sarahchen6 sarahchen6 requested a review from a team as a code owner April 24, 2025 20:21
@github-actions GitHub Actions
Copy link
Contributor

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

@pr-commenter
Copy link

pr-commenter bot commented Apr 24, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master revert-8709-sarahchen6/update-config-for-large-binary-files
git_commit_date 1745582823 1745607823
git_commit_sha 75634fe 621a4a1
release_version 1.49.0-SNAPSHOT~75634fe423 1.49.0-SNAPSHOT~621a4a1559
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1745610996 1745610996
ci_job_id 913572768 913572768
ci_pipeline_id 63389345 63389345
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-uvgw7qef-project-304-concurrent-1-x4cgkudm 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-uvgw7qef-project-304-concurrent-1-x4cgkudm 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 67 metrics, 4 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.49.0-SNAPSHOT~621a4a1559, baseline=1.49.0-SNAPSHOT~75634fe423

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.012 s) : 0, 1012192
Total [baseline] (10.499 s) : 0, 10499109
Agent [candidate] (1.005 s) : 0, 1005380
Total [candidate] (10.488 s) : 0, 10488446
section appsec
Agent [baseline] (1.154 s) : 0, 1154403
Total [baseline] (10.694 s) : 0, 10694224
Agent [candidate] (1.148 s) : 0, 1148382
Total [candidate] (10.686 s) : 0, 10686097
section iast
Agent [baseline] (1.146 s) : 0, 1145733
Total [baseline] (10.788 s) : 0, 10788477
Agent [candidate] (1.139 s) : 0, 1138683
Total [candidate] (10.818 s) : 0, 10817913
section profiling
Agent [baseline] (1.252 s) : 0, 1251796
Total [baseline] (10.788 s) : 0, 10787985
Agent [candidate] (1.254 s) : 0, 1254127
Total [candidate] (10.792 s) : 0, 10791904
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.012 s -
Agent appsec 1.154 s 142.211 ms (14.0%)
Agent iast 1.146 s 133.54 ms (13.2%)
Agent profiling 1.252 s 239.603 ms (23.7%)
Total tracing 10.499 s -
Total appsec 10.694 s 195.115 ms (1.9%)
Total iast 10.788 s 289.367 ms (2.8%)
Total profiling 10.788 s 288.876 ms (2.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.005 s -
Agent appsec 1.148 s 143.002 ms (14.2%)
Agent iast 1.139 s 133.303 ms (13.3%)
Agent profiling 1.254 s 248.747 ms (24.7%)
Total tracing 10.488 s -
Total appsec 10.686 s 197.652 ms (1.9%)
Total iast 10.818 s 329.468 ms (3.1%)
Total profiling 10.792 s 303.459 ms (2.9%) 
gantt
    title petclinic - break down per module: candidate=1.49.0-SNAPSHOT~621a4a1559, baseline=1.49.0-SNAPSHOT~75634fe423

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (674.878 ms) : 0, 674878
BytebuddyAgent [candidate] (671.198 ms) : 0, 671198
GlobalTracer [baseline] (241.504 ms) : 0, 241504
GlobalTracer [candidate] (240.136 ms) : 0, 240136
AppSec [baseline] (54.724 ms) : 0, 54724
AppSec [candidate] (54.611 ms) : 0, 54611
Debugger [baseline] (6.174 ms) : 0, 6174
Debugger [candidate] (6.135 ms) : 0, 6135
Remote Config [baseline] (722.111 µs) : 0, 722
Remote Config [candidate] (736.301 µs) : 0, 736
Telemetry [baseline] (10.56 ms) : 0, 10560
Telemetry [candidate] (9.243 ms) : 0, 9243
section appsec
BytebuddyAgent [baseline] (692.92 ms) : 0, 692920
BytebuddyAgent [candidate] (687.781 ms) : 0, 687781
GlobalTracer [baseline] (236.941 ms) : 0, 236941
GlobalTracer [candidate] (236.525 ms) : 0, 236525
AppSec [baseline] (175.745 ms) : 0, 175745
AppSec [candidate] (175.222 ms) : 0, 175222
Debugger [baseline] (5.912 ms) : 0, 5912
Debugger [candidate] (5.886 ms) : 0, 5886
Remote Config [baseline] (649.84 µs) : 0, 650
Remote Config [candidate] (639.432 µs) : 0, 639
Telemetry [baseline] (7.845 ms) : 0, 7845
Telemetry [candidate] (8.094 ms) : 0, 8094
IAST [baseline] (21.864 ms) : 0, 21864
IAST [candidate] (21.715 ms) : 0, 21715
section iast
BytebuddyAgent [baseline] (796.945 ms) : 0, 796945
BytebuddyAgent [candidate] (791.834 ms) : 0, 791834
GlobalTracer [baseline] (231.172 ms) : 0, 231172
GlobalTracer [candidate] (230.144 ms) : 0, 230144
AppSec [baseline] (56.675 ms) : 0, 56675
AppSec [candidate] (56.242 ms) : 0, 56242
Debugger [baseline] (5.882 ms) : 0, 5882
Debugger [candidate] (5.902 ms) : 0, 5902
Remote Config [baseline] (612.079 µs) : 0, 612
Remote Config [candidate] (611.957 µs) : 0, 612
Telemetry [baseline] (7.856 ms) : 0, 7856
Telemetry [candidate] (7.883 ms) : 0, 7883
IAST [baseline] (23.081 ms) : 0, 23081
IAST [candidate] (22.602 ms) : 0, 22602
section profiling
BytebuddyAgent [baseline] (661.365 ms) : 0, 661365
BytebuddyAgent [candidate] (662.245 ms) : 0, 662245
GlobalTracer [baseline] (375.006 ms) : 0, 375006
GlobalTracer [candidate] (375.827 ms) : 0, 375827
AppSec [baseline] (54.274 ms) : 0, 54274
AppSec [candidate] (53.724 ms) : 0, 53724
Debugger [baseline] (6.128 ms) : 0, 6128
Debugger [candidate] (6.126 ms) : 0, 6126
Remote Config [baseline] (664.875 µs) : 0, 665
Remote Config [candidate] (654.104 µs) : 0, 654
Telemetry [baseline] (8.167 ms) : 0, 8167
Telemetry [candidate] (8.155 ms) : 0, 8155
ProfilingAgent [baseline] (96.176 ms) : 0, 96176
ProfilingAgent [candidate] (97.308 ms) : 0, 97308
Profiling [baseline] (96.2 ms) : 0, 96200
Profiling [candidate] (97.332 ms) : 0, 97332
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.49.0-SNAPSHOT~621a4a1559, baseline=1.49.0-SNAPSHOT~75634fe423

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.008 s) : 0, 1008187
Total [baseline] (8.659 s) : 0, 8659244
Agent [candidate] (1.003 s) : 0, 1002568
Total [candidate] (8.629 s) : 0, 8629258
section iast
Agent [baseline] (1.137 s) : 0, 1136565
Total [baseline] (9.187 s) : 0, 9187037
Agent [candidate] (1.139 s) : 0, 1139217
Total [candidate] (9.204 s) : 0, 9204044
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.135 s) : 0, 1134811
Total [baseline] (9.137 s) : 0, 9137243
Agent [candidate] (1.145 s) : 0, 1145281
Total [candidate] (9.234 s) : 0, 9234327
section iast_TELEMETRY_OFF
Agent [baseline] (1.133 s) : 0, 1133391
Total [baseline] (9.169 s) : 0, 9168806
Agent [candidate] (1.131 s) : 0, 1130535
Total [candidate] (9.177 s) : 0, 9176883
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.008 s -
Agent iast 1.137 s 128.379 ms (12.7%)
Agent iast_HARDCODED_SECRET_DISABLED 1.135 s 126.624 ms (12.6%)
Agent iast_TELEMETRY_OFF 1.133 s 125.205 ms (12.4%)
Total tracing 8.659 s -
Total iast 9.187 s 527.793 ms (6.1%)
Total iast_HARDCODED_SECRET_DISABLED 9.137 s 477.999 ms (5.5%)
Total iast_TELEMETRY_OFF 9.169 s 509.562 ms (5.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.003 s -
Agent iast 1.139 s 136.649 ms (13.6%)
Agent iast_HARDCODED_SECRET_DISABLED 1.145 s 142.713 ms (14.2%)
Agent iast_TELEMETRY_OFF 1.131 s 127.967 ms (12.8%)
Total tracing 8.629 s -
Total iast 9.204 s 574.786 ms (6.7%)
Total iast_HARDCODED_SECRET_DISABLED 9.234 s 605.069 ms (7.0%)
Total iast_TELEMETRY_OFF 9.177 s 547.625 ms (6.3%) 
gantt
    title insecure-bank - break down per module: candidate=1.49.0-SNAPSHOT~621a4a1559, baseline=1.49.0-SNAPSHOT~75634fe423

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (672.316 ms) : 0, 672316
BytebuddyAgent [candidate] (669.064 ms) : 0, 669064
GlobalTracer [baseline] (240.622 ms) : 0, 240622
GlobalTracer [candidate] (239.399 ms) : 0, 239399
AppSec [baseline] (54.609 ms) : 0, 54609
AppSec [candidate] (54.486 ms) : 0, 54486
Debugger [baseline] (6.211 ms) : 0, 6211
Debugger [candidate] (6.141 ms) : 0, 6141
Remote Config [baseline] (713.521 µs) : 0, 714
Remote Config [candidate] (713.096 µs) : 0, 713
Telemetry [baseline] (10.041 ms) : 0, 10041
Telemetry [candidate] (9.237 ms) : 0, 9237
section iast
BytebuddyAgent [baseline] (789.631 ms) : 0, 789631
BytebuddyAgent [candidate] (790.939 ms) : 0, 790939
GlobalTracer [baseline] (230.089 ms) : 0, 230089
GlobalTracer [candidate] (231.094 ms) : 0, 231094
AppSec [baseline] (56.37 ms) : 0, 56370
AppSec [candidate] (56.599 ms) : 0, 56599
Debugger [baseline] (5.892 ms) : 0, 5892
Debugger [candidate] (5.901 ms) : 0, 5901
Remote Config [baseline] (588.132 µs) : 0, 588
Remote Config [candidate] (601.061 µs) : 0, 601
Telemetry [baseline] (7.893 ms) : 0, 7893
Telemetry [candidate] (7.9 ms) : 0, 7900
IAST [baseline] (22.747 ms) : 0, 22747
IAST [candidate] (22.824 ms) : 0, 22824
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (788.211 ms) : 0, 788211
BytebuddyAgent [candidate] (795.464 ms) : 0, 795464
GlobalTracer [baseline] (229.741 ms) : 0, 229741
GlobalTracer [candidate] (231.829 ms) : 0, 231829
AppSec [baseline] (56.431 ms) : 0, 56431
AppSec [candidate] (56.988 ms) : 0, 56988
Debugger [baseline] (5.885 ms) : 0, 5885
Debugger [candidate] (5.912 ms) : 0, 5912
Remote Config [baseline] (587.384 µs) : 0, 587
Remote Config [candidate] (599.973 µs) : 0, 600
Telemetry [baseline] (7.863 ms) : 0, 7863
Telemetry [candidate] (7.984 ms) : 0, 7984
IAST [baseline] (22.734 ms) : 0, 22734
IAST [candidate] (23.102 ms) : 0, 23102
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (785.899 ms) : 0, 785899
BytebuddyAgent [candidate] (784.653 ms) : 0, 784653
GlobalTracer [baseline] (230.484 ms) : 0, 230484
GlobalTracer [candidate] (229.54 ms) : 0, 229540
AppSec [baseline] (56.825 ms) : 0, 56825
AppSec [candidate] (56.38 ms) : 0, 56380
Debugger [baseline] (5.899 ms) : 0, 5899
Debugger [candidate] (5.945 ms) : 0, 5945
Remote Config [baseline] (594.238 µs) : 0, 594
Remote Config [candidate] (596.056 µs) : 0, 596
Telemetry [baseline] (7.895 ms) : 0, 7895
Telemetry [candidate] (7.824 ms) : 0, 7824
IAST [baseline] (22.445 ms) : 0, 22445
IAST [candidate] (22.291 ms) : 0, 22291
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-04-25T19:24:58 2025-04-25T19:32:41
git_branch master revert-8709-sarahchen6/update-config-for-large-binary-files
git_commit_date 1745582823 1745607823
git_commit_sha 75634fe 621a4a1
release_version 1.49.0-SNAPSHOT~75634fe423 1.49.0-SNAPSHOT~621a4a1559
start_time 2025-04-25T19:24:44 2025-04-25T19:32:27
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1745609958 1745609958
ci_job_id 913572769 913572769
ci_pipeline_id 63389345 63389345
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-nsrtnna7-project-304-concurrent-0-r88ky28x 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-nsrtnna7-project-304-concurrent-0-r88ky28x 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 18 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.49.0-SNAPSHOT~621a4a1559, baseline=1.49.0-SNAPSHOT~75634fe423
    dateFormat X
    axisFormat %s
section baseline
no_agent (377.778 µs) : 357, 399
.   : milestone, 378,
iast (508.591 µs) : 485, 532
.   : milestone, 509,
iast_FULL (732.676 µs) : 709, 756
.   : milestone, 733,
iast_GLOBAL (556.518 µs) : 533, 580
.   : milestone, 557,
iast_HARDCODED_SECRET_DISABLED (512.278 µs) : 489, 535
.   : milestone, 512,
iast_INACTIVE (465.498 µs) : 443, 488
.   : milestone, 465,
iast_TELEMETRY_OFF (499.026 µs) : 476, 522
.   : milestone, 499,
tracing (457.613 µs) : 436, 480
.   : milestone, 458,
section candidate
no_agent (376.022 µs) : 356, 396
.   : milestone, 376,
iast (523.951 µs) : 501, 547
.   : milestone, 524,
iast_FULL (732.149 µs) : 709, 755
.   : milestone, 732,
iast_GLOBAL (568.172 µs) : 545, 592
.   : milestone, 568,
iast_HARDCODED_SECRET_DISABLED (522.464 µs) : 500, 545
.   : milestone, 522,
iast_INACTIVE (470.044 µs) : 447, 493
.   : milestone, 470,
iast_TELEMETRY_OFF (499.643 µs) : 477, 522
.   : milestone, 500,
tracing (458.987 µs) : 437, 481
.   : milestone, 459,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 377.778 µs [356.981 µs, 398.575 µs] -
iast 508.591 µs [485.439 µs, 531.743 µs] 130.813 µs (34.6%)
iast_FULL 732.676 µs [709.034 µs, 756.317 µs] 354.897 µs (93.9%)
iast_GLOBAL 556.518 µs [533.26 µs, 579.776 µs] 178.739 µs (47.3%)
iast_HARDCODED_SECRET_DISABLED 512.278 µs [489.485 µs, 535.071 µs] 134.5 µs (35.6%)
iast_INACTIVE 465.498 µs [442.809 µs, 488.186 µs] 87.719 µs (23.2%)
iast_TELEMETRY_OFF 499.026 µs [476.232 µs, 521.821 µs] 121.248 µs (32.1%)
tracing 457.613 µs [435.691 µs, 479.534 µs] 79.834 µs (21.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 376.022 µs [356.044 µs, 396.0 µs] -
iast 523.951 µs [501.186 µs, 546.717 µs] 147.929 µs (39.3%)
iast_FULL 732.149 µs [709.066 µs, 755.232 µs] 356.127 µs (94.7%)
iast_GLOBAL 568.172 µs [544.608 µs, 591.735 µs] 192.15 µs (51.1%)
iast_HARDCODED_SECRET_DISABLED 522.464 µs [499.643 µs, 545.286 µs] 146.442 µs (38.9%)
iast_INACTIVE 470.044 µs [447.114 µs, 492.975 µs] 94.022 µs (25.0%)
iast_TELEMETRY_OFF 499.643 µs [477.37 µs, 521.916 µs] 123.621 µs (32.9%)
tracing 458.987 µs [437.153 µs, 480.821 µs] 82.965 µs (22.1%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.49.0-SNAPSHOT~621a4a1559, baseline=1.49.0-SNAPSHOT~75634fe423
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.372 ms) : 1353, 1391
.   : milestone, 1372,
appsec (1.728 ms) : 1705, 1752
.   : milestone, 1728,
appsec_no_iast (1.74 ms) : 1717, 1763
.   : milestone, 1740,
code_origins (1.676 ms) : 1649, 1703
.   : milestone, 1676,
iast (1.524 ms) : 1500, 1549
.   : milestone, 1524,
profiling (1.505 ms) : 1482, 1529
.   : milestone, 1505,
tracing (1.504 ms) : 1480, 1529
.   : milestone, 1504,
section candidate
no_agent (1.361 ms) : 1342, 1380
.   : milestone, 1361,
appsec (1.73 ms) : 1705, 1754
.   : milestone, 1730,
appsec_no_iast (1.73 ms) : 1707, 1753
.   : milestone, 1730,
code_origins (1.682 ms) : 1654, 1709
.   : milestone, 1682,
iast (1.529 ms) : 1504, 1554
.   : milestone, 1529,
profiling (1.497 ms) : 1474, 1520
.   : milestone, 1497,
tracing (1.495 ms) : 1470, 1520
.   : milestone, 1495,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.372 ms [1.353 ms, 1.391 ms] -
appsec 1.728 ms [1.705 ms, 1.752 ms] 356.623 µs (26.0%)
appsec_no_iast 1.74 ms [1.717 ms, 1.763 ms] 368.015 µs (26.8%)
code_origins 1.676 ms [1.649 ms, 1.703 ms] 304.359 µs (22.2%)
iast 1.524 ms [1.5 ms, 1.549 ms] 152.477 µs (11.1%)
profiling 1.505 ms [1.482 ms, 1.529 ms] 133.648 µs (9.7%)
tracing 1.504 ms [1.48 ms, 1.529 ms] 132.653 µs (9.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.361 ms [1.342 ms, 1.38 ms] -
appsec 1.73 ms [1.705 ms, 1.754 ms] 368.743 µs (27.1%)
appsec_no_iast 1.73 ms [1.707 ms, 1.753 ms] 368.977 µs (27.1%)
code_origins 1.682 ms [1.654 ms, 1.709 ms] 320.666 µs (23.6%)
iast 1.529 ms [1.504 ms, 1.554 ms] 168.01 µs (12.3%)
profiling 1.497 ms [1.474 ms, 1.52 ms] 135.843 µs (10.0%)
tracing 1.495 ms [1.47 ms, 1.52 ms] 134.48 µs (9.9%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master revert-8709-sarahchen6/update-config-for-large-binary-files
git_commit_date 1745582823 1745607823
git_commit_sha 75634fe 621a4a1
release_version 1.49.0-SNAPSHOT~75634fe423 1.49.0-SNAPSHOT~621a4a1559
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1745610491 1745610491
ci_job_id 913572770 913572770
ci_pipeline_id 63389345 63389345
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-uvgw7qef-project-304-concurrent-2-4ebie6na 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-uvgw7qef-project-304-concurrent-2-4ebie6na 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.49.0-SNAPSHOT~621a4a1559, baseline=1.49.0-SNAPSHOT~75634fe423
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.944 s) : 14944000, 14944000
.   : milestone, 14944000,
appsec (14.812 s) : 14812000, 14812000
.   : milestone, 14812000,
iast (18.414 s) : 18414000, 18414000
.   : milestone, 18414000,
iast_GLOBAL (17.586 s) : 17586000, 17586000
.   : milestone, 17586000,
profiling (15.208 s) : 15208000, 15208000
.   : milestone, 15208000,
tracing (15.17 s) : 15170000, 15170000
.   : milestone, 15170000,
section candidate
no_agent (15.183 s) : 15183000, 15183000
.   : milestone, 15183000,
appsec (14.745 s) : 14745000, 14745000
.   : milestone, 14745000,
iast (18.593 s) : 18593000, 18593000
.   : milestone, 18593000,
iast_GLOBAL (17.658 s) : 17658000, 17658000
.   : milestone, 17658000,
profiling (15.224 s) : 15224000, 15224000
.   : milestone, 15224000,
tracing (15.243 s) : 15243000, 15243000
.   : milestone, 15243000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.944 s [14.944 s, 14.944 s] -
appsec 14.812 s [14.812 s, 14.812 s] -132.0 ms (-0.9%)
iast 18.414 s [18.414 s, 18.414 s] 3.47 s (23.2%)
iast_GLOBAL 17.586 s [17.586 s, 17.586 s] 2.642 s (17.7%)
profiling 15.208 s [15.208 s, 15.208 s] 264.0 ms (1.8%)
tracing 15.17 s [15.17 s, 15.17 s] 226.0 ms (1.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.183 s [15.183 s, 15.183 s] -
appsec 14.745 s [14.745 s, 14.745 s] -438.0 ms (-2.9%)
iast 18.593 s [18.593 s, 18.593 s] 3.41 s (22.5%)
iast_GLOBAL 17.658 s [17.658 s, 17.658 s] 2.475 s (16.3%)
profiling 15.224 s [15.224 s, 15.224 s] 41.0 ms (0.3%)
tracing 15.243 s [15.243 s, 15.243 s] 60.0 ms (0.4%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.49.0-SNAPSHOT~621a4a1559, baseline=1.49.0-SNAPSHOT~75634fe423
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.479 ms) : 1468, 1491
.   : milestone, 1479,
appsec (2.386 ms) : 2340, 2433
.   : milestone, 2386,
iast (2.161 ms) : 2101, 2220
.   : milestone, 2161,
iast_GLOBAL (2.216 ms) : 2157, 2276
.   : milestone, 2216,
profiling (2.457 ms) : 2286, 2628
.   : milestone, 2457,
tracing (1.994 ms) : 1949, 2040
.   : milestone, 1994,
section candidate
no_agent (1.477 ms) : 1466, 1489
.   : milestone, 1477,
appsec (2.387 ms) : 2340, 2434
.   : milestone, 2387,
iast (2.166 ms) : 2107, 2225
.   : milestone, 2166,
iast_GLOBAL (2.209 ms) : 2150, 2269
.   : milestone, 2209,
profiling (2.029 ms) : 1981, 2077
.   : milestone, 2029,
tracing (2.003 ms) : 1957, 2049
.   : milestone, 2003,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.479 ms [1.468 ms, 1.491 ms] -
appsec 2.386 ms [2.34 ms, 2.433 ms] 906.854 µs (61.3%)
iast 2.161 ms [2.101 ms, 2.22 ms] 681.162 µs (46.0%)
iast_GLOBAL 2.216 ms [2.157 ms, 2.276 ms] 736.897 µs (49.8%)
profiling 2.457 ms [2.286 ms, 2.628 ms] 977.415 µs (66.1%)
tracing 1.994 ms [1.949 ms, 2.04 ms] 514.926 µs (34.8%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.477 ms [1.466 ms, 1.489 ms] -
appsec 2.387 ms [2.34 ms, 2.434 ms] 909.865 µs (61.6%)
iast 2.166 ms [2.107 ms, 2.225 ms] 688.936 µs (46.6%)
iast_GLOBAL 2.209 ms [2.15 ms, 2.269 ms] 732.188 µs (49.6%)
profiling 2.029 ms [1.981 ms, 2.077 ms] 551.66 µs (37.3%)
tracing 2.003 ms [1.957 ms, 2.049 ms] 526.118 µs (35.6%)

@PerfectSlayer PerfectSlayer added the tag: no release notes Changes to exclude from release notes label Apr 25, 2025
@sarahchen6 sarahchen6 force-pushed the revert-8709-sarahchen6/update-config-for-large-binary-files branch from 0df2192 to 184af96 Compare April 25, 2025 13:22
@sarahchen6 sarahchen6 requested a review from a team as a code owner April 25, 2025 14:10
sarahchen6
sarahchen6 commented Apr 25, 2025
View reviewed changes
...src/testFixtures/groovy/datadog/trace/instrumentation/spark/AbstractSparkListenerTest.groovy
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test was missed in CI due to the change that this PR is trying to revert. See here for its failures on master.

@sarahchen6 sarahchen6 requested a review from a team as a code owner April 25, 2025 19:06
@sarahchen6 sarahchen6 merged commit 4d01d58 into master Apr 25, 2025
459 checks passed
@sarahchen6 sarahchen6 deleted the revert-8709-sarahchen6/update-config-for-large-binary-files branch April 25, 2025 20:44
@github-actions github-actions bot added this to the 1.49.0 milestone Apr 25, 2025
@sarahchen6 sarahchen6 mentioned this pull request Apr 25, 2025
Closed
@sarahchen6 sarahchen6 mentioned this pull request May 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcculls mcculls mcculls approved these changes

@nayeem-kamal nayeem-kamal nayeem-kamal approved these changes

Assignees
No one assigned
Labels
comp: tooling Build & Tooling tag: no release notes Changes to exclude from release notes type: bug
Projects
None yet
Milestone
1.49.0
Development

Successfully merging this pull request may close these issues.
4 participants
@sarahchen6 @mcculls @nayeem-kamal @PerfectSlayer