Skip to content

Swap original StrictContextStorage with simple wrapper when embedding #7201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2024
Merged

Swap original StrictContextStorage with simple wrapper when embedding #7201

merged 1 commit into from
Jun 17, 2024

Conversation

@mcculls
Copy link
Contributor

@mcculls mcculls commented Jun 16, 2024

Backport of #7200 for v1.35.1

@mcculls mcculls added tag: no release notes Changes to exclude from release notes comp: native-image GraalVM native-image inst: opentelemetry OpenTelemetry instrumentation labels Jun 16, 2024
@mcculls mcculls added this to the 1.35.1 milestone Jun 16, 2024
@mcculls mcculls requested a review from a team as a code owner June 16, 2024 22:04
@mcculls mcculls requested review from PerfectSlayer and am312 June 16, 2024 22:04
@pr-commenter
Copy link

pr-commenter bot commented Jun 16, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/support-otel-extensions-when-building-native-images-v1.35.1
git_commit_date 1718615602 1718615810
git_commit_sha 19753bb b6ef02a
release_version 1.36.0-SNAPSHOT~19753bb1b2 1.36.0-SNAPSHOT~b6ef02ad67
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1718618884 1718618884
ci_job_id 544844353 544844353
ci_pipeline_id 36875963 36875963
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 55 metrics, 16 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.36.0-SNAPSHOT~b6ef02ad67, baseline=1.36.0-SNAPSHOT~19753bb1b2

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.069 s) : 0, 1068502
Total [baseline] (8.581 s) : 0, 8581070
Agent [candidate] (1.062 s) : 0, 1062169
Total [candidate] (8.529 s) : 0, 8529091
section iast
Agent [baseline] (1.167 s) : 0, 1167445
Total [baseline] (8.968 s) : 0, 8967772
Agent [candidate] (1.167 s) : 0, 1166760
Total [candidate] (8.986 s) : 0, 8986019
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.17 s) : 0, 1169822
Total [baseline] (8.969 s) : 0, 8968981
Agent [candidate] (1.17 s) : 0, 1169770
Total [candidate] (8.974 s) : 0, 8974179
section iast_TELEMETRY_OFF
Agent [baseline] (1.166 s) : 0, 1165895
Total [baseline] (9.012 s) : 0, 9011983
Agent [candidate] (1.168 s) : 0, 1167594
Total [candidate] (9.011 s) : 0, 9011143
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.069 s -
Agent iast 1.167 s 98.943 ms (9.3%)
Agent iast_HARDCODED_SECRET_DISABLED 1.17 s 101.32 ms (9.5%)
Agent iast_TELEMETRY_OFF 1.166 s 97.393 ms (9.1%)
Total tracing 8.581 s -
Total iast 8.968 s 386.702 ms (4.5%)
Total iast_HARDCODED_SECRET_DISABLED 8.969 s 387.91 ms (4.5%)
Total iast_TELEMETRY_OFF 9.012 s 430.913 ms (5.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.062 s -
Agent iast 1.167 s 104.591 ms (9.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.17 s 107.601 ms (10.1%)
Agent iast_TELEMETRY_OFF 1.168 s 105.425 ms (9.9%)
Total tracing 8.529 s -
Total iast 8.986 s 456.928 ms (5.4%)
Total iast_HARDCODED_SECRET_DISABLED 8.974 s 445.088 ms (5.2%)
Total iast_TELEMETRY_OFF 9.011 s 482.052 ms (5.7%) 
gantt
    title insecure-bank - break down per module: candidate=1.36.0-SNAPSHOT~b6ef02ad67, baseline=1.36.0-SNAPSHOT~19753bb1b2

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (669.112 ms) : 0, 669112
BytebuddyAgent [candidate] (665.327 ms) : 0, 665327
GlobalTracer [baseline] (305.729 ms) : 0, 305729
GlobalTracer [candidate] (303.661 ms) : 0, 303661
AppSec [baseline] (50.65 ms) : 0, 50650
AppSec [candidate] (50.178 ms) : 0, 50178
Logs Intake [baseline] (333.701 µs) : 0, 334
Logs Intake [candidate] (418.885 µs) : 0, 419
Remote Config [baseline] (668.32 µs) : 0, 668
Remote Config [candidate] (656.909 µs) : 0, 657
Telemetry [baseline] (7.64 ms) : 0, 7640
Telemetry [candidate] (7.553 ms) : 0, 7553
section iast
BytebuddyAgent [baseline] (778.625 ms) : 0, 778625
BytebuddyAgent [candidate] (777.621 ms) : 0, 777621
GlobalTracer [baseline] (292.544 ms) : 0, 292544
GlobalTracer [candidate] (292.649 ms) : 0, 292649
AppSec [baseline] (46.959 ms) : 0, 46959
AppSec [candidate] (46.755 ms) : 0, 46755
Logs Intake [baseline] (307.238 µs) : 0, 307
Logs Intake [candidate] (298.586 µs) : 0, 299
Remote Config [baseline] (615.95 µs) : 0, 616
Remote Config [candidate] (3.556 ms) : 0, 3556
Telemetry [baseline] (7.606 ms) : 0, 7606
Telemetry [candidate] (6.946 ms) : 0, 6946
IAST [baseline] (27.528 ms) : 0, 27528
IAST [candidate] (25.659 ms) : 0, 25659
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (779.895 ms) : 0, 779895
BytebuddyAgent [candidate] (780.598 ms) : 0, 780598
GlobalTracer [baseline] (293.098 ms) : 0, 293098
GlobalTracer [candidate] (294.036 ms) : 0, 294036
AppSec [baseline] (47.334 ms) : 0, 47334
AppSec [candidate] (46.929 ms) : 0, 46929
Logs Intake [baseline] (310.505 µs) : 0, 311
Logs Intake [candidate] (304.876 µs) : 0, 305
Remote Config [baseline] (597.719 µs) : 0, 598
Remote Config [candidate] (572.92 µs) : 0, 573
Telemetry [baseline] (6.95 ms) : 0, 6950
Telemetry [candidate] (6.918 ms) : 0, 6918
IAST [baseline] (28.328 ms) : 0, 28328
IAST [candidate] (27.095 ms) : 0, 27095
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (776.434 ms) : 0, 776434
BytebuddyAgent [candidate] (776.278 ms) : 0, 776278
GlobalTracer [baseline] (293.33 ms) : 0, 293330
GlobalTracer [candidate] (295.444 ms) : 0, 295444
AppSec [baseline] (47.203 ms) : 0, 47203
AppSec [candidate] (46.705 ms) : 0, 46705
Logs Intake [baseline] (311.164 µs) : 0, 311
Logs Intake [candidate] (306.3 µs) : 0, 306
Remote Config [baseline] (583.54 µs) : 0, 584
Remote Config [candidate] (565.396 µs) : 0, 565
Telemetry [baseline] (6.819 ms) : 0, 6819
Telemetry [candidate] (8.255 ms) : 0, 8255
IAST [baseline] (27.92 ms) : 0, 27920
IAST [candidate] (26.726 ms) : 0, 26726
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.36.0-SNAPSHOT~b6ef02ad67, baseline=1.36.0-SNAPSHOT~19753bb1b2

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.061 s) : 0, 1060979
Total [baseline] (10.312 s) : 0, 10312429
Agent [candidate] (1.063 s) : 0, 1062833
Total [candidate] (10.365 s) : 0, 10365320
section appsec
Agent [baseline] (1.191 s) : 0, 1190721
Total [baseline] (10.484 s) : 0, 10484436
Agent [candidate] (1.181 s) : 0, 1180575
Total [candidate] (10.478 s) : 0, 10477938
section iast
Agent [baseline] (1.172 s) : 0, 1172145
Total [baseline] (10.674 s) : 0, 10673831
Agent [candidate] (1.17 s) : 0, 1169595
Total [candidate] (10.681 s) : 0, 10681393
section profiling
Agent [baseline] (1.261 s) : 0, 1261462
Total [baseline] (10.639 s) : 0, 10639448
Agent [candidate] (1.258 s) : 0, 1257526
Total [candidate] (10.608 s) : 0, 10607808
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.061 s -
Agent appsec 1.191 s 129.742 ms (12.2%)
Agent iast 1.172 s 111.166 ms (10.5%)
Agent profiling 1.261 s 200.484 ms (18.9%)
Total tracing 10.312 s -
Total appsec 10.484 s 172.008 ms (1.7%)
Total iast 10.674 s 361.402 ms (3.5%)
Total profiling 10.639 s 327.019 ms (3.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.063 s -
Agent appsec 1.181 s 117.742 ms (11.1%)
Agent iast 1.17 s 106.763 ms (10.0%)
Agent profiling 1.258 s 194.694 ms (18.3%)
Total tracing 10.365 s -
Total appsec 10.478 s 112.617 ms (1.1%)
Total iast 10.681 s 316.072 ms (3.0%)
Total profiling 10.608 s 242.487 ms (2.3%) 
gantt
    title petclinic - break down per module: candidate=1.36.0-SNAPSHOT~b6ef02ad67, baseline=1.36.0-SNAPSHOT~19753bb1b2

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (664.924 ms) : 0, 664924
BytebuddyAgent [candidate] (665.457 ms) : 0, 665457
GlobalTracer [baseline] (303.263 ms) : 0, 303263
GlobalTracer [candidate] (303.982 ms) : 0, 303982
AppSec [baseline] (49.913 ms) : 0, 49913
AppSec [candidate] (50.362 ms) : 0, 50362
Logs Intake [baseline] (328.349 µs) : 0, 328
Logs Intake [candidate] (378.798 µs) : 0, 379
Remote Config [baseline] (665.415 µs) : 0, 665
Remote Config [candidate] (679.353 µs) : 0, 679
Telemetry [baseline] (7.525 ms) : 0, 7525
Telemetry [candidate] (7.559 ms) : 0, 7559
section appsec
BytebuddyAgent [baseline] (681.901 ms) : 0, 681901
BytebuddyAgent [candidate] (675.461 ms) : 0, 675461
GlobalTracer [baseline] (298.432 ms) : 0, 298432
GlobalTracer [candidate] (297.157 ms) : 0, 297157
AppSec [baseline] (154.669 ms) : 0, 154669
AppSec [candidate] (152.758 ms) : 0, 152758
IAST [baseline] (22.388 ms) : 0, 22388
IAST [candidate] (21.695 ms) : 0, 21695
Logs Intake [baseline] (329.077 µs) : 0, 329
Logs Intake [candidate] (336.73 µs) : 0, 337
Remote Config [baseline] (616.124 µs) : 0, 616
Remote Config [candidate] (634.916 µs) : 0, 635
Telemetry [baseline] (8.779 ms) : 0, 8779
Telemetry [candidate] (9.024 ms) : 0, 9024
section iast
BytebuddyAgent [baseline] (781.173 ms) : 0, 781173
BytebuddyAgent [candidate] (779.857 ms) : 0, 779857
GlobalTracer [baseline] (293.889 ms) : 0, 293889
GlobalTracer [candidate] (293.563 ms) : 0, 293563
AppSec [baseline] (47.091 ms) : 0, 47091
AppSec [candidate] (47.229 ms) : 0, 47229
IAST [baseline] (28.785 ms) : 0, 28785
IAST [candidate] (27.088 ms) : 0, 27088
Logs Intake [baseline] (320.646 µs) : 0, 321
Logs Intake [candidate] (304.367 µs) : 0, 304
Remote Config [baseline] (658.92 µs) : 0, 659
Remote Config [candidate] (578.76 µs) : 0, 579
Telemetry [baseline] (6.932 ms) : 0, 6932
Telemetry [candidate] (7.672 ms) : 0, 7672
section profiling
BytebuddyAgent [baseline] (662.03 ms) : 0, 662030
BytebuddyAgent [candidate] (660.853 ms) : 0, 660853
GlobalTracer [baseline] (385.222 ms) : 0, 385222
GlobalTracer [candidate] (384.943 ms) : 0, 384943
AppSec [baseline] (51.492 ms) : 0, 51492
AppSec [candidate] (50.68 ms) : 0, 50680
Logs Intake [baseline] (333.293 µs) : 0, 333
Logs Intake [candidate] (324.802 µs) : 0, 325
Remote Config [baseline] (701.708 µs) : 0, 702
Remote Config [candidate] (741.036 µs) : 0, 741
Telemetry [baseline] (7.365 ms) : 0, 7365
Telemetry [candidate] (7.288 ms) : 0, 7288
ProfilingAgent [baseline] (97.319 ms) : 0, 97319
ProfilingAgent [candidate] (95.753 ms) : 0, 95753
Profiling [baseline] (97.344 ms) : 0, 97344
Profiling [candidate] (95.778 ms) : 0, 95778
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-06-17T09:38:53 2024-06-17T09:45:46
git_branch master mcculls/support-otel-extensions-when-building-native-images-v1.35.1
git_commit_date 1718615602 1718615810
git_commit_sha 19753bb b6ef02a
release_version 1.36.0-SNAPSHOT~19753bb1b2 1.36.0-SNAPSHOT~b6ef02ad67
start_time 2024-06-17T09:38:40 2024-06-17T09:45:33
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1718617891 1718617891
ci_job_id 544844354 544844354
ci_pipeline_id 36875963 36875963
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 17 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:petclinic:profiling better
[-95.753µs; -41.571µs] or [-6.160%; -2.674%]		 unstable
[-479.250op/s; +707.170op/s] or [-16.175%; +23.867%]		 1.486ms 3076.923op/s 1.555ms 2962.963op/s
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~b6ef02ad67, baseline=1.36.0-SNAPSHOT~19753bb1b2
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.377 ms) : 1356, 1397
.   : milestone, 1377,
appsec (1.742 ms) : 1718, 1766
.   : milestone, 1742,
appsec_no_iast (1.729 ms) : 1705, 1754
.   : milestone, 1729,
iast (1.498 ms) : 1475, 1521
.   : milestone, 1498,
profiling (1.555 ms) : 1529, 1580
.   : milestone, 1555,
tracing (1.474 ms) : 1450, 1498
.   : milestone, 1474,
section candidate
no_agent (1.343 ms) : 1324, 1363
.   : milestone, 1343,
appsec (1.736 ms) : 1712, 1760
.   : milestone, 1736,
appsec_no_iast (1.738 ms) : 1713, 1762
.   : milestone, 1738,
iast (1.476 ms) : 1454, 1499
.   : milestone, 1476,
profiling (1.486 ms) : 1461, 1511
.   : milestone, 1486,
tracing (1.453 ms) : 1430, 1477
.   : milestone, 1453,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.377 ms [1.356 ms, 1.397 ms] -
appsec 1.742 ms [1.718 ms, 1.766 ms] 365.625 µs (26.6%)
appsec_no_iast 1.729 ms [1.705 ms, 1.754 ms] 352.689 µs (25.6%)
iast 1.498 ms [1.475 ms, 1.521 ms] 121.112 µs (8.8%)
profiling 1.555 ms [1.529 ms, 1.58 ms] 178.001 µs (12.9%)
tracing 1.474 ms [1.45 ms, 1.498 ms] 97.686 µs (7.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.343 ms [1.324 ms, 1.363 ms] -
appsec 1.736 ms [1.712 ms, 1.76 ms] 392.952 µs (29.3%)
appsec_no_iast 1.738 ms [1.713 ms, 1.762 ms] 394.627 µs (29.4%)
iast 1.476 ms [1.454 ms, 1.499 ms] 133.199 µs (9.9%)
profiling 1.486 ms [1.461 ms, 1.511 ms] 142.76 µs (10.6%)
tracing 1.453 ms [1.43 ms, 1.477 ms] 110.259 µs (8.2%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~b6ef02ad67, baseline=1.36.0-SNAPSHOT~19753bb1b2
    dateFormat X
    axisFormat %s
section baseline
no_agent (376.28 µs) : 357, 396
.   : milestone, 376,
iast (487.117 µs) : 466, 508
.   : milestone, 487,
iast_FULL (550.579 µs) : 530, 572
.   : milestone, 551,
iast_GLOBAL (509.989 µs) : 489, 531
.   : milestone, 510,
iast_HARDCODED_SECRET_DISABLED (486.098 µs) : 465, 507
.   : milestone, 486,
iast_INACTIVE (459.162 µs) : 437, 482
.   : milestone, 459,
iast_TELEMETRY_OFF (476.211 µs) : 455, 497
.   : milestone, 476,
tracing (451.472 µs) : 430, 473
.   : milestone, 451,
section candidate
no_agent (367.892 µs) : 348, 388
.   : milestone, 368,
iast (484.763 µs) : 464, 506
.   : milestone, 485,
iast_FULL (556.715 µs) : 535, 578
.   : milestone, 557,
iast_GLOBAL (513.328 µs) : 492, 535
.   : milestone, 513,
iast_HARDCODED_SECRET_DISABLED (484.234 µs) : 463, 506
.   : milestone, 484,
iast_INACTIVE (456.777 µs) : 435, 478
.   : milestone, 457,
iast_TELEMETRY_OFF (469.491 µs) : 448, 491
.   : milestone, 469,
tracing (449.618 µs) : 429, 470
.   : milestone, 450,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 376.28 µs [356.797 µs, 395.763 µs] -
iast 487.117 µs [466.142 µs, 508.091 µs] 110.837 µs (29.5%)
iast_FULL 550.579 µs [529.523 µs, 571.634 µs] 174.299 µs (46.3%)
iast_GLOBAL 509.989 µs [488.736 µs, 531.242 µs] 133.709 µs (35.5%)
iast_HARDCODED_SECRET_DISABLED 486.098 µs [465.079 µs, 507.116 µs] 109.818 µs (29.2%)
iast_INACTIVE 459.162 µs [436.813 µs, 481.511 µs] 82.882 µs (22.0%)
iast_TELEMETRY_OFF 476.211 µs [455.08 µs, 497.342 µs] 99.931 µs (26.6%)
tracing 451.472 µs [429.817 µs, 473.127 µs] 75.192 µs (20.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 367.892 µs [348.265 µs, 387.518 µs] -
iast 484.763 µs [463.546 µs, 505.979 µs] 116.871 µs (31.8%)
iast_FULL 556.715 µs [535.422 µs, 578.009 µs] 188.823 µs (51.3%)
iast_GLOBAL 513.328 µs [492.053 µs, 534.604 µs] 145.436 µs (39.5%)
iast_HARDCODED_SECRET_DISABLED 484.234 µs [462.671 µs, 505.797 µs] 116.342 µs (31.6%)
iast_INACTIVE 456.777 µs [435.275 µs, 478.28 µs] 88.886 µs (24.2%)
iast_TELEMETRY_OFF 469.491 µs [447.951 µs, 491.032 µs] 101.599 µs (27.6%)
tracing 449.618 µs [428.744 µs, 470.492 µs] 81.726 µs (22.2%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/support-otel-extensions-when-building-native-images-v1.35.1
git_commit_date 1718616811 1718615810
git_commit_sha e375af2 b6ef02a
release_version 1.36.0-SNAPSHOT~e375af2238 1.36.0-SNAPSHOT~b6ef02ad67
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1718618491 1718618491
ci_job_id 544844355 544844355
ci_pipeline_id 36875963 36875963
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~b6ef02ad67, baseline=1.36.0-SNAPSHOT~e375af2238
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.457 ms) : 1446, 1469
.   : milestone, 1457,
appsec (2.201 ms) : 2168, 2235
.   : milestone, 2201,
iast (1.967 ms) : 1925, 2008
.   : milestone, 1967,
iast_GLOBAL (2.002 ms) : 1961, 2042
.   : milestone, 2002,
profiling (1.856 ms) : 1822, 1889
.   : milestone, 1856,
tracing (1.82 ms) : 1788, 1851
.   : milestone, 1820,
section candidate
no_agent (1.469 ms) : 1457, 1481
.   : milestone, 1469,
appsec (2.209 ms) : 2174, 2243
.   : milestone, 2209,
iast (1.954 ms) : 1913, 1994
.   : milestone, 1954,
iast_GLOBAL (1.994 ms) : 1954, 2035
.   : milestone, 1994,
profiling (1.847 ms) : 1814, 1880
.   : milestone, 1847,
tracing (1.842 ms) : 1809, 1874
.   : milestone, 1842,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.457 ms [1.446 ms, 1.469 ms] -
appsec 2.201 ms [2.168 ms, 2.235 ms] 743.873 µs (51.0%)
iast 1.967 ms [1.925 ms, 2.008 ms] 509.293 µs (34.9%)
iast_GLOBAL 2.002 ms [1.961 ms, 2.042 ms] 544.453 µs (37.4%)
profiling 1.856 ms [1.822 ms, 1.889 ms] 398.082 µs (27.3%)
tracing 1.82 ms [1.788 ms, 1.851 ms] 362.202 µs (24.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.469 ms [1.457 ms, 1.481 ms] -
appsec 2.209 ms [2.174 ms, 2.243 ms] 740.069 µs (50.4%)
iast 1.954 ms [1.913 ms, 1.994 ms] 485.025 µs (33.0%)
iast_GLOBAL 1.994 ms [1.954 ms, 2.035 ms] 525.474 µs (35.8%)
profiling 1.847 ms [1.814 ms, 1.88 ms] 377.874 µs (25.7%)
tracing 1.842 ms [1.809 ms, 1.874 ms] 372.912 µs (25.4%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~b6ef02ad67, baseline=1.36.0-SNAPSHOT~e375af2238
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.543 s) : 15543000, 15543000
.   : milestone, 15543000,
appsec (14.856 s) : 14856000, 14856000
.   : milestone, 14856000,
iast (18.959 s) : 18959000, 18959000
.   : milestone, 18959000,
iast_GLOBAL (17.944 s) : 17944000, 17944000
.   : milestone, 17944000,
profiling (15.218 s) : 15218000, 15218000
.   : milestone, 15218000,
tracing (14.954 s) : 14954000, 14954000
.   : milestone, 14954000,
section candidate
no_agent (15.48 s) : 15480000, 15480000
.   : milestone, 15480000,
appsec (14.699 s) : 14699000, 14699000
.   : milestone, 14699000,
iast (18.74 s) : 18740000, 18740000
.   : milestone, 18740000,
iast_GLOBAL (18.11 s) : 18110000, 18110000
.   : milestone, 18110000,
profiling (15.336 s) : 15336000, 15336000
.   : milestone, 15336000,
tracing (15.139 s) : 15139000, 15139000
.   : milestone, 15139000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.543 s [15.543 s, 15.543 s] -
appsec 14.856 s [14.856 s, 14.856 s] -687.0 ms (-4.4%)
iast 18.959 s [18.959 s, 18.959 s] 3.416 s (22.0%)
iast_GLOBAL 17.944 s [17.944 s, 17.944 s] 2.401 s (15.4%)
profiling 15.218 s [15.218 s, 15.218 s] -325.0 ms (-2.1%)
tracing 14.954 s [14.954 s, 14.954 s] -589.0 ms (-3.8%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.48 s [15.48 s, 15.48 s] -
appsec 14.699 s [14.699 s, 14.699 s] -781.0 ms (-5.0%)
iast 18.74 s [18.74 s, 18.74 s] 3.26 s (21.1%)
iast_GLOBAL 18.11 s [18.11 s, 18.11 s] 2.63 s (17.0%)
profiling 15.336 s [15.336 s, 15.336 s] -144.0 ms (-0.9%)
tracing 15.139 s [15.139 s, 15.139 s] -341.0 ms (-2.2%)

@mcculls mcculls force-pushed the mcculls/support-otel-extensions-when-building-native-images-v1.35.1 branch from 3e1819e to b6ef02a Compare June 17, 2024 09:17
PerfectSlayer
PerfectSlayer approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same review as #7200

@mcculls mcculls merged commit 9c5c8ab into release/v1.35.x Jun 17, 2024
@mcculls mcculls deleted the mcculls/support-otel-extensions-when-building-native-images-v1.35.1 branch June 17, 2024 10:13
@mcculls mcculls modified the milestones: 1.35.1, 1.35.2 Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@am312 am312 Awaiting requested review from am312 am312 is a code owner automatically assigned from DataDog/apm-java

Assignees

No one assigned

Labels

comp: native-image GraalVM native-image inst: opentelemetry OpenTelemetry instrumentation tag: no release notes Changes to exclude from release notes

Projects

None yet

Milestone

1.35.2

Development

Successfully merging this pull request may close these issues.

3 participants

@mcculls @PerfectSlayer