Skip to content

Swap original StrictContextStorage with simple wrapper when embedding #7200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2024
Merged

Swap original StrictContextStorage with simple wrapper when embedding #7200

merged 1 commit into from
Jun 17, 2024

Conversation

@mcculls
Copy link
Contributor

@mcculls mcculls commented Jun 16, 2024

What Does This Do

Replaces the original class with a simple wrapper to avoid missing reference issue on native-image.

Motivation

The original class is only used for testing purposes when a particular property is set, but native-image follows the reference in LazyStorage and attempts to load everything it touches, including some types we are not embedding. This simple replacement fixes this issue.

@mcculls mcculls added tag: no release notes Changes to exclude from release notes comp: native-image GraalVM native-image inst: opentelemetry OpenTelemetry instrumentation labels Jun 16, 2024
@mcculls mcculls requested a review from a team as a code owner June 16, 2024 22:01
@mcculls mcculls requested review from dougqh and ygree June 16, 2024 22:01
@mcculls mcculls mentioned this pull request Jun 16, 2024
Merged
@pr-commenter
Copy link

pr-commenter bot commented Jun 16, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/support-otel-extensions-when-building-native-images
git_commit_date 1718615602 1718615746
git_commit_sha 19753bb 235b5c3
release_version 1.36.0-SNAPSHOT~19753bb1b2 1.36.0-SNAPSHOT~235b5c326a
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1718618775 1718618775
ci_job_id 544843254 544843254
ci_pipeline_id 36875928 36875928
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 19 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.36.0-SNAPSHOT~235b5c326a, baseline=1.36.0-SNAPSHOT~19753bb1b2

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.062 s) : 0, 1061595
Total [baseline] (10.292 s) : 0, 10291790
Agent [candidate] (1.063 s) : 0, 1062948
Total [candidate] (10.277 s) : 0, 10276624
section appsec
Agent [baseline] (1.18 s) : 0, 1179698
Total [baseline] (10.436 s) : 0, 10436113
Agent [candidate] (1.179 s) : 0, 1178693
Total [candidate] (10.414 s) : 0, 10413947
section iast
Agent [baseline] (1.178 s) : 0, 1178137
Total [baseline] (10.686 s) : 0, 10686359
Agent [candidate] (1.17 s) : 0, 1170176
Total [candidate] (10.696 s) : 0, 10695980
section profiling
Agent [baseline] (1.261 s) : 0, 1260606
Total [baseline] (10.719 s) : 0, 10718988
Agent [candidate] (1.262 s) : 0, 1262240
Total [candidate] (10.62 s) : 0, 10619633
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.062 s -
Agent appsec 1.18 s 118.103 ms (11.1%)
Agent iast 1.178 s 116.542 ms (11.0%)
Agent profiling 1.261 s 199.011 ms (18.7%)
Total tracing 10.292 s -
Total appsec 10.436 s 144.323 ms (1.4%)
Total iast 10.686 s 394.569 ms (3.8%)
Total profiling 10.719 s 427.198 ms (4.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.063 s -
Agent appsec 1.179 s 115.745 ms (10.9%)
Agent iast 1.17 s 107.228 ms (10.1%)
Agent profiling 1.262 s 199.292 ms (18.7%)
Total tracing 10.277 s -
Total appsec 10.414 s 137.322 ms (1.3%)
Total iast 10.696 s 419.355 ms (4.1%)
Total profiling 10.62 s 343.009 ms (3.3%) 
gantt
    title petclinic - break down per module: candidate=1.36.0-SNAPSHOT~235b5c326a, baseline=1.36.0-SNAPSHOT~19753bb1b2

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (665.603 ms) : 0, 665603
BytebuddyAgent [candidate] (665.236 ms) : 0, 665236
GlobalTracer [baseline] (303.219 ms) : 0, 303219
GlobalTracer [candidate] (304.454 ms) : 0, 304454
AppSec [baseline] (49.872 ms) : 0, 49872
AppSec [candidate] (50.279 ms) : 0, 50279
Logs Intake [baseline] (329.458 µs) : 0, 329
Logs Intake [candidate] (343.971 µs) : 0, 344
Remote Config [baseline] (661.544 µs) : 0, 662
Remote Config [candidate] (662.052 µs) : 0, 662
Telemetry [baseline] (7.552 ms) : 0, 7552
Telemetry [candidate] (7.565 ms) : 0, 7565
section appsec
BytebuddyAgent [baseline] (674.427 ms) : 0, 674427
BytebuddyAgent [candidate] (674.296 ms) : 0, 674296
GlobalTracer [baseline] (296.558 ms) : 0, 296558
GlobalTracer [candidate] (296.251 ms) : 0, 296251
AppSec [baseline] (153.887 ms) : 0, 153887
AppSec [candidate] (153.597 ms) : 0, 153597
Logs Intake [baseline] (330.301 µs) : 0, 330
Logs Intake [candidate] (328.35 µs) : 0, 328
Remote Config [baseline] (608.963 µs) : 0, 609
Remote Config [candidate] (605.672 µs) : 0, 606
Telemetry [baseline] (9.648 ms) : 0, 9648
Telemetry [candidate] (8.149 ms) : 0, 8149
IAST [baseline] (19.698 ms) : 0, 19698
IAST [candidate] (22.287 ms) : 0, 22287
section iast
BytebuddyAgent [baseline] (786.735 ms) : 0, 786735
BytebuddyAgent [candidate] (779.607 ms) : 0, 779607
GlobalTracer [baseline] (295.522 ms) : 0, 295522
GlobalTracer [candidate] (293.258 ms) : 0, 293258
AppSec [baseline] (47.361 ms) : 0, 47361
AppSec [candidate] (47.252 ms) : 0, 47252
Logs Intake [baseline] (306.837 µs) : 0, 307
Logs Intake [candidate] (322.812 µs) : 0, 323
Remote Config [baseline] (623.157 µs) : 0, 623
Remote Config [candidate] (633.772 µs) : 0, 634
Telemetry [baseline] (6.938 ms) : 0, 6938
Telemetry [candidate] (7.605 ms) : 0, 7605
IAST [baseline] (27.221 ms) : 0, 27221
IAST [candidate] (28.193 ms) : 0, 28193
section profiling
BytebuddyAgent [baseline] (662.886 ms) : 0, 662886
BytebuddyAgent [candidate] (663.322 ms) : 0, 663322
GlobalTracer [baseline] (385.656 ms) : 0, 385656
GlobalTracer [candidate] (385.689 ms) : 0, 385689
AppSec [baseline] (51.381 ms) : 0, 51381
AppSec [candidate] (51.474 ms) : 0, 51474
Logs Intake [baseline] (342.612 µs) : 0, 343
Logs Intake [candidate] (338.7 µs) : 0, 339
Remote Config [baseline] (724.65 µs) : 0, 725
Remote Config [candidate] (720.438 µs) : 0, 720
Telemetry [baseline] (7.431 ms) : 0, 7431
Telemetry [candidate] (7.377 ms) : 0, 7377
ProfilingAgent [baseline] (95.272 ms) : 0, 95272
ProfilingAgent [candidate] (96.243 ms) : 0, 96243
Profiling [baseline] (95.297 ms) : 0, 95297
Profiling [candidate] (96.268 ms) : 0, 96268
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.36.0-SNAPSHOT~235b5c326a, baseline=1.36.0-SNAPSHOT~19753bb1b2

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.061 s) : 0, 1061070
Total [baseline] (8.53 s) : 0, 8530111
Agent [candidate] (1.059 s) : 0, 1058653
Total [candidate] (8.528 s) : 0, 8528373
section iast
Agent [baseline] (1.175 s) : 0, 1175102
Total [baseline] (9.036 s) : 0, 9035601
Agent [candidate] (1.166 s) : 0, 1166008
Total [candidate] (8.99 s) : 0, 8990105
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.169 s) : 0, 1168696
Total [baseline] (8.95 s) : 0, 8949661
Agent [candidate] (1.168 s) : 0, 1168300
Total [candidate] (8.969 s) : 0, 8969455
section iast_TELEMETRY_OFF
Agent [baseline] (1.163 s) : 0, 1162585
Total [baseline] (8.979 s) : 0, 8978747
Agent [candidate] (1.164 s) : 0, 1164158
Total [candidate] (8.975 s) : 0, 8974588
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.061 s -
Agent iast 1.175 s 114.032 ms (10.7%)
Agent iast_HARDCODED_SECRET_DISABLED 1.169 s 107.625 ms (10.1%)
Agent iast_TELEMETRY_OFF 1.163 s 101.515 ms (9.6%)
Total tracing 8.53 s -
Total iast 9.036 s 505.489 ms (5.9%)
Total iast_HARDCODED_SECRET_DISABLED 8.95 s 419.55 ms (4.9%)
Total iast_TELEMETRY_OFF 8.979 s 448.635 ms (5.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.059 s -
Agent iast 1.166 s 107.354 ms (10.1%)
Agent iast_HARDCODED_SECRET_DISABLED 1.168 s 109.647 ms (10.4%)
Agent iast_TELEMETRY_OFF 1.164 s 105.504 ms (10.0%)
Total tracing 8.528 s -
Total iast 8.99 s 461.732 ms (5.4%)
Total iast_HARDCODED_SECRET_DISABLED 8.969 s 441.082 ms (5.2%)
Total iast_TELEMETRY_OFF 8.975 s 446.215 ms (5.2%) 
gantt
    title insecure-bank - break down per module: candidate=1.36.0-SNAPSHOT~235b5c326a, baseline=1.36.0-SNAPSHOT~19753bb1b2

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (664.859 ms) : 0, 664859
BytebuddyAgent [candidate] (663.417 ms) : 0, 663417
GlobalTracer [baseline] (303.011 ms) : 0, 303011
GlobalTracer [candidate] (302.461 ms) : 0, 302461
AppSec [baseline] (50.066 ms) : 0, 50066
AppSec [candidate] (49.954 ms) : 0, 49954
Logs Intake [baseline] (331.001 µs) : 0, 331
Logs Intake [candidate] (336.35 µs) : 0, 336
Remote Config [baseline] (660.207 µs) : 0, 660
Remote Config [candidate] (669.661 µs) : 0, 670
Telemetry [baseline] (7.63 ms) : 0, 7630
Telemetry [candidate] (7.561 ms) : 0, 7561
section iast
BytebuddyAgent [baseline] (783.344 ms) : 0, 783344
BytebuddyAgent [candidate] (777.815 ms) : 0, 777815
GlobalTracer [baseline] (294.896 ms) : 0, 294896
GlobalTracer [candidate] (292.231 ms) : 0, 292231
AppSec [baseline] (47.391 ms) : 0, 47391
AppSec [candidate] (46.891 ms) : 0, 46891
IAST [baseline] (28.173 ms) : 0, 28173
IAST [candidate] (27.966 ms) : 0, 27966
Logs Intake [baseline] (319.002 µs) : 0, 319
Logs Intake [candidate] (310.844 µs) : 0, 311
Remote Config [baseline] (689.683 µs) : 0, 690
Remote Config [candidate] (613.91 µs) : 0, 614
Telemetry [baseline] (6.965 ms) : 0, 6965
Telemetry [candidate] (6.897 ms) : 0, 6897
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (779.647 ms) : 0, 779647
BytebuddyAgent [candidate] (778.551 ms) : 0, 778551
GlobalTracer [baseline] (293.243 ms) : 0, 293243
GlobalTracer [candidate] (293.376 ms) : 0, 293376
AppSec [baseline] (47.304 ms) : 0, 47304
AppSec [candidate] (47.057 ms) : 0, 47057
IAST [baseline] (27.238 ms) : 0, 27238
IAST [candidate] (27.478 ms) : 0, 27478
Logs Intake [baseline] (315.959 µs) : 0, 316
Logs Intake [candidate] (305.584 µs) : 0, 306
Remote Config [baseline] (646.44 µs) : 0, 646
Remote Config [candidate] (592.656 µs) : 0, 593
Telemetry [baseline] (6.995 ms) : 0, 6995
Telemetry [candidate] (7.629 ms) : 0, 7629
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (775.087 ms) : 0, 775087
BytebuddyAgent [candidate] (776.493 ms) : 0, 776493
GlobalTracer [baseline] (292.672 ms) : 0, 292672
GlobalTracer [candidate] (292.507 ms) : 0, 292507
AppSec [baseline] (46.872 ms) : 0, 46872
AppSec [candidate] (47.052 ms) : 0, 47052
IAST [baseline] (25.396 ms) : 0, 25396
IAST [candidate] (25.4 ms) : 0, 25400
Logs Intake [baseline] (306.301 µs) : 0, 306
Logs Intake [candidate] (307.462 µs) : 0, 307
Remote Config [baseline] (574.9 µs) : 0, 575
Remote Config [candidate] (597.379 µs) : 0, 597
Telemetry [baseline] (8.372 ms) : 0, 8372
Telemetry [candidate] (8.453 ms) : 0, 8453
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-06-17T09:37:11 2024-06-17T09:44:01
git_branch master mcculls/support-otel-extensions-when-building-native-images
git_commit_date 1718615602 1718615746
git_commit_sha 19753bb 235b5c3
release_version 1.36.0-SNAPSHOT~19753bb1b2 1.36.0-SNAPSHOT~235b5c326a
start_time 2024-06-17T09:36:58 2024-06-17T09:43:48
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1718617787 1718617787
ci_job_id 544843255 544843255
ci_pipeline_id 36875928 36875928
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~235b5c326a, baseline=1.36.0-SNAPSHOT~19753bb1b2
    dateFormat X
    axisFormat %s
section baseline
no_agent (368.22 µs) : 349, 388
.   : milestone, 368,
iast (483.898 µs) : 463, 505
.   : milestone, 484,
iast_FULL (547.42 µs) : 526, 568
.   : milestone, 547,
iast_GLOBAL (511.072 µs) : 489, 533
.   : milestone, 511,
iast_HARDCODED_SECRET_DISABLED (486.644 µs) : 465, 508
.   : milestone, 487,
iast_INACTIVE (454.137 µs) : 432, 476
.   : milestone, 454,
iast_TELEMETRY_OFF (471.619 µs) : 451, 493
.   : milestone, 472,
tracing (443.338 µs) : 422, 464
.   : milestone, 443,
section candidate
no_agent (368.749 µs) : 349, 388
.   : milestone, 369,
iast (483.472 µs) : 462, 505
.   : milestone, 483,
iast_FULL (553.217 µs) : 532, 574
.   : milestone, 553,
iast_GLOBAL (510.587 µs) : 490, 532
.   : milestone, 511,
iast_HARDCODED_SECRET_DISABLED (483.918 µs) : 462, 506
.   : milestone, 484,
iast_INACTIVE (454.181 µs) : 432, 476
.   : milestone, 454,
iast_TELEMETRY_OFF (470.036 µs) : 449, 491
.   : milestone, 470,
tracing (439.037 µs) : 419, 459
.   : milestone, 439,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 368.22 µs [348.562 µs, 387.878 µs] -
iast 483.898 µs [462.75 µs, 505.045 µs] 115.678 µs (31.4%)
iast_FULL 547.42 µs [526.368 µs, 568.472 µs] 179.2 µs (48.7%)
iast_GLOBAL 511.072 µs [489.028 µs, 533.116 µs] 142.852 µs (38.8%)
iast_HARDCODED_SECRET_DISABLED 486.644 µs [464.895 µs, 508.392 µs] 118.424 µs (32.2%)
iast_INACTIVE 454.137 µs [432.415 µs, 475.859 µs] 85.917 µs (23.3%)
iast_TELEMETRY_OFF 471.619 µs [450.669 µs, 492.57 µs] 103.399 µs (28.1%)
tracing 443.338 µs [422.351 µs, 464.325 µs] 75.118 µs (20.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 368.749 µs [349.343 µs, 388.155 µs] -
iast 483.472 µs [461.575 µs, 505.369 µs] 114.723 µs (31.1%)
iast_FULL 553.217 µs [532.006 µs, 574.427 µs] 184.468 µs (50.0%)
iast_GLOBAL 510.587 µs [489.542 µs, 531.633 µs] 141.838 µs (38.5%)
iast_HARDCODED_SECRET_DISABLED 483.918 µs [462.288 µs, 505.549 µs] 115.169 µs (31.2%)
iast_INACTIVE 454.181 µs [432.474 µs, 475.887 µs] 85.432 µs (23.2%)
iast_TELEMETRY_OFF 470.036 µs [448.874 µs, 491.199 µs] 101.287 µs (27.5%)
tracing 439.037 µs [418.751 µs, 459.324 µs] 70.288 µs (19.1%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~235b5c326a, baseline=1.36.0-SNAPSHOT~19753bb1b2
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.345 ms) : 1325, 1364
.   : milestone, 1345,
appsec (1.734 ms) : 1710, 1758
.   : milestone, 1734,
appsec_no_iast (1.709 ms) : 1684, 1734
.   : milestone, 1709,
iast (1.486 ms) : 1464, 1507
.   : milestone, 1486,
profiling (1.542 ms) : 1516, 1569
.   : milestone, 1542,
tracing (1.455 ms) : 1430, 1480
.   : milestone, 1455,
section candidate
no_agent (1.324 ms) : 1304, 1345
.   : milestone, 1324,
appsec (1.74 ms) : 1715, 1764
.   : milestone, 1740,
appsec_no_iast (1.702 ms) : 1677, 1728
.   : milestone, 1702,
iast (1.474 ms) : 1453, 1496
.   : milestone, 1474,
profiling (1.535 ms) : 1509, 1561
.   : milestone, 1535,
tracing (1.477 ms) : 1452, 1501
.   : milestone, 1477,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.345 ms [1.325 ms, 1.364 ms] -
appsec 1.734 ms [1.71 ms, 1.758 ms] 389.202 µs (28.9%)
appsec_no_iast 1.709 ms [1.684 ms, 1.734 ms] 364.258 µs (27.1%)
iast 1.486 ms [1.464 ms, 1.507 ms] 140.77 µs (10.5%)
profiling 1.542 ms [1.516 ms, 1.569 ms] 197.407 µs (14.7%)
tracing 1.455 ms [1.43 ms, 1.48 ms] 110.06 µs (8.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.324 ms [1.304 ms, 1.345 ms] -
appsec 1.74 ms [1.715 ms, 1.764 ms] 415.175 µs (31.3%)
appsec_no_iast 1.702 ms [1.677 ms, 1.728 ms] 377.856 µs (28.5%)
iast 1.474 ms [1.453 ms, 1.496 ms] 149.99 µs (11.3%)
profiling 1.535 ms [1.509 ms, 1.561 ms] 210.67 µs (15.9%)
tracing 1.477 ms [1.452 ms, 1.501 ms] 152.397 µs (11.5%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/support-otel-extensions-when-building-native-images
git_commit_date 1718615602 1718615746
git_commit_sha 19753bb 235b5c3
release_version 1.36.0-SNAPSHOT~19753bb1b2 1.36.0-SNAPSHOT~235b5c326a
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1718618399 1718618399
ci_job_id 544843256 544843256
ci_pipeline_id 36875928 36875928
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~235b5c326a, baseline=1.36.0-SNAPSHOT~19753bb1b2
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.461 ms) : 1449, 1472
.   : milestone, 1461,
appsec (2.207 ms) : 2173, 2241
.   : milestone, 2207,
iast (1.962 ms) : 1921, 2002
.   : milestone, 1962,
iast_GLOBAL (2.01 ms) : 1969, 2051
.   : milestone, 2010,
profiling (1.854 ms) : 1820, 1889
.   : milestone, 1854,
tracing (1.838 ms) : 1805, 1870
.   : milestone, 1838,
section candidate
no_agent (1.46 ms) : 1448, 1471
.   : milestone, 1460,
appsec (2.22 ms) : 2186, 2255
.   : milestone, 2220,
iast (1.975 ms) : 1933, 2016
.   : milestone, 1975,
iast_GLOBAL (2.02 ms) : 1978, 2062
.   : milestone, 2020,
profiling (1.86 ms) : 1827, 1894
.   : milestone, 1860,
tracing (1.832 ms) : 1800, 1864
.   : milestone, 1832,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.461 ms [1.449 ms, 1.472 ms] -
appsec 2.207 ms [2.173 ms, 2.241 ms] 746.15 µs (51.1%)
iast 1.962 ms [1.921 ms, 2.002 ms] 500.785 µs (34.3%)
iast_GLOBAL 2.01 ms [1.969 ms, 2.051 ms] 549.022 µs (37.6%)
profiling 1.854 ms [1.82 ms, 1.889 ms] 393.261 µs (26.9%)
tracing 1.838 ms [1.805 ms, 1.87 ms] 376.768 µs (25.8%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.46 ms [1.448 ms, 1.471 ms] -
appsec 2.22 ms [2.186 ms, 2.255 ms] 760.622 µs (52.1%)
iast 1.975 ms [1.933 ms, 2.016 ms] 515.095 µs (35.3%)
iast_GLOBAL 2.02 ms [1.978 ms, 2.062 ms] 559.994 µs (38.4%)
profiling 1.86 ms [1.827 ms, 1.894 ms] 400.366 µs (27.4%)
tracing 1.832 ms [1.8 ms, 1.864 ms] 372.278 µs (25.5%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~235b5c326a, baseline=1.36.0-SNAPSHOT~19753bb1b2
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.998 s) : 14998000, 14998000
.   : milestone, 14998000,
appsec (14.833 s) : 14833000, 14833000
.   : milestone, 14833000,
iast (18.552 s) : 18552000, 18552000
.   : milestone, 18552000,
iast_GLOBAL (17.866 s) : 17866000, 17866000
.   : milestone, 17866000,
profiling (15.344 s) : 15344000, 15344000
.   : milestone, 15344000,
tracing (14.916 s) : 14916000, 14916000
.   : milestone, 14916000,
section candidate
no_agent (14.849 s) : 14849000, 14849000
.   : milestone, 14849000,
appsec (14.999 s) : 14999000, 14999000
.   : milestone, 14999000,
iast (18.747 s) : 18747000, 18747000
.   : milestone, 18747000,
iast_GLOBAL (17.883 s) : 17883000, 17883000
.   : milestone, 17883000,
profiling (15.136 s) : 15136000, 15136000
.   : milestone, 15136000,
tracing (15.09 s) : 15090000, 15090000
.   : milestone, 15090000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.998 s [14.998 s, 14.998 s] -
appsec 14.833 s [14.833 s, 14.833 s] -165.0 ms (-1.1%)
iast 18.552 s [18.552 s, 18.552 s] 3.554 s (23.7%)
iast_GLOBAL 17.866 s [17.866 s, 17.866 s] 2.868 s (19.1%)
profiling 15.344 s [15.344 s, 15.344 s] 346.0 ms (2.3%)
tracing 14.916 s [14.916 s, 14.916 s] -82.0 ms (-0.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.849 s [14.849 s, 14.849 s] -
appsec 14.999 s [14.999 s, 14.999 s] 150.0 ms (1.0%)
iast 18.747 s [18.747 s, 18.747 s] 3.898 s (26.3%)
iast_GLOBAL 17.883 s [17.883 s, 17.883 s] 3.034 s (20.4%)
profiling 15.136 s [15.136 s, 15.136 s] 287.0 ms (1.9%)
tracing 15.09 s [15.09 s, 15.09 s] 241.0 ms (1.6%)

@mcculls mcculls force-pushed the mcculls/support-otel-extensions-when-building-native-images branch from 50ec0b4 to 235b5c3 Compare June 17, 2024 09:16
PerfectSlayer
PerfectSlayer approved these changes Jun 17, 2024
View reviewed changes
.../otel-bootstrap/src/main/java/datadog/trace/bootstrap/otel/context/StrictContextStorage.java
Comment on lines +10 to +12
* <p>The original class is only used for testing purposes when a particular property is set, but
* native-image follows the reference in {@code LazyStorage} and attempts to load everything it
* touches, including some types we are not embedding. This simple replacement fixes this issue.
Copy link
Contributor

@PerfectSlayer PerfectSlayer Jun 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for documenting the original reason 👍

@mcculls mcculls merged commit 3f9b2ae into master Jun 17, 2024
@mcculls mcculls deleted the mcculls/support-otel-extensions-when-building-native-images branch June 17, 2024 10:11
@github-actions github-actions bot added this to the 1.35.1 milestone Jun 17, 2024
@PerfectSlayer PerfectSlayer modified the milestones: 1.35.1, 1.36.0 Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@dougqh dougqh Awaiting requested review from dougqh dougqh was automatically assigned from DataDog/apm-java

@ygree ygree Awaiting requested review from ygree ygree was automatically assigned from DataDog/apm-java

Assignees

No one assigned

Labels

comp: native-image GraalVM native-image inst: opentelemetry OpenTelemetry instrumentation tag: no release notes Changes to exclude from release notes

Projects

None yet

Milestone

1.36.0

Development

Successfully merging this pull request may close these issues.

3 participants

@mcculls @PerfectSlayer