[WIP] Merge of remote sampling rules and new sampling mechanism #6991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed RULE -> LOCAL_USER_RULE Added REMOTE_USER_RULE and REMOTE_ADAPTIVE_RULE
Adding mechanism to SamplingRule Relaying mechanism from rule to the span
Adding comments explaining the metainfo logic Since I found the logic less than intuitive, I wanted to make it easier on the next person
… mcculls/handle-remote-sampling-rules_MERGE
mcculls
force-pushed
the
mcculls/handle-remote-sampling-rules_MERGE
branch
from
aedbe1b to
cb12ad7
Compare
dougqh
reviewed
May 6, 2024
| rule.getTags(), | ||
| new DeterministicSampler.TraceSampler(rule.getSampleRate())); | ||
| new DeterministicSampler.TraceSampler(rule.getSampleRate()), | ||
| samplingMechanism(rule.getProvenance())); |
dougqh
reviewed
May 6, 2024
| final SamplingRule samplingRule = | ||
| new ServiceSamplingRule( | ||
| final RateSamplingRule samplingRule = | ||
| new RateSamplingRule.ServiceSamplingRule( |
Contributor
There was a problem hiding this comment.
I couldn't quite decide what I wanted to do with ServiceSamplingRule and OperationSamplingRule. I thought about explicitly specifying the mechanism just to make the logic more clear, but I'll leave it to you to decide.
Contributor
Author
|
Testing complete, PRs will be merged separately |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Merge of #6987 and #6989 for testing purposes
Motivation
Forthcoming changes will allow rules to be set via remote configuration.
Once rules can be either locally or remotely, we want the decision maker to reflect the source of the rule.
Additional Notes
Change makes extensive changes to the sampling rule tests - previously these tests weren't checking the decision maker tag
Jira ticket: AIT-9975