Skip to content

Adding sampling provenance/mechanism to SamplingRules #6989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
May 6, 2024
Merged

Adding sampling provenance/mechanism to SamplingRules #6989

merged 13 commits into from
May 6, 2024

Conversation

@dougqh
Copy link
Contributor

@dougqh dougqh commented May 3, 2024 •
edited by atlassian bot
Loading

What Does This Do

Adds samplingMechanism information to TraceSamplingRule objects

Motivation

Forthcoming changes will allow rules to be set via remote configuration.
Once rules can be either locally or remotely, we want the decision maker to reflect the source of the rule.

Additional Notes

Change makes extensive changes to the sampling rule tests - previously these tests weren't checking the decision maker tag

Jira ticket: AIT-9975

@dougqh dougqh requested a review from a team as a code owner May 3, 2024 19:23
dougqh
dougqh commented May 3, 2024
View reviewed changes
dd-trace-core/src/main/java/datadog/trace/common/sampling/RuleBasedTraceSampler.java Outdated
rule.getTags(),
new DeterministicSampler.TraceSampler(rule.getSampleRate()));
new DeterministicSampler.TraceSampler(rule.getSampleRate()),
SamplingMechanism.LOCAL_USER_RULE);
Copy link
Contributor Author

@dougqh dougqh May 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While there's a SamplingMechanism field on SamplingRule, I didn't modify the operation & service rules to require it. We might want to revisit that when we marry this changeset with the remote config code.

Copy link
Contributor

@mcculls mcculls May 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now the old operation and service rules use the deprecated constructor which defaults to LOCAL provenance - I'm ok with that, because we don't expect those rules to be supplied by remote-config.

dougqh
dougqh commented May 3, 2024
View reviewed changes
dd-trace-core/src/main/java/datadog/trace/common/sampling/RuleBasedTraceSampler.java Outdated
if (defaultRate != null) {
final SamplingRule samplingRule =
new AlwaysMatchesSamplingRule(new DeterministicSampler.TraceSampler(defaultRate));
new AlwaysMatchesSamplingRule(
Copy link
Contributor Author

@dougqh dougqh May 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went ahead and made LOCAL_USER_RULE explicit here.
I think it was an oversight in the spec that we don't mark this as REMOTE_USER_RULE when the default global rate comes from remote config. We may want to update this in the future.

Copy link
Contributor

@mcculls mcculls May 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense - we can update it once we have agreement in the updated spec.

dougqh
dougqh commented May 3, 2024
View reviewed changes
internal-api/src/main/java/datadog/trace/api/sampling/SamplingMechanism.java
public static final byte REMOTE_AUTO_RATE = 2;
/** Sampling rule or sampling rate based on tracer config */
public static final byte RULE = 3;
public static final byte LOCAL_USER_RULE = 3;
Copy link
Contributor Author

@dougqh dougqh May 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed to make distinction clear

dougqh
dougqh commented May 3, 2024
View reviewed changes
internal-api/src/main/java/datadog/trace/api/sampling/SamplingMechanism.java
/** Data Jobs */
public static final byte DATA_JOBS = 10;

public static final byte REMOTE_USER_RULE = 11;
Copy link
Contributor Author

@dougqh dougqh May 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New values to be used by remote configuration
Not used yet, but did check that they flow through properly

dougqh
dougqh commented May 3, 2024
View reviewed changes
dd-trace-core/src/test/groovy/datadog/trace/common/sampling/RuleBasedSamplingTest.groovy
// Matching neither passes through to rate based sampler
"xx:1" | null | null | null | null | 1.0 | SAMPLER_KEEP
null | "xx:1" | null | null | null | 1.0 | SAMPLER_KEEP
"xx:1" | null | null | AGENT_RATE | SAMPLER_KEEP | null | null | 1.0
Copy link
Contributor Author

@dougqh dougqh May 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added checking of decision maker to all the rule tests

@dougqh
Adding comments
1a97821 
Adding comments explaining the metainfo logic
Since I found the logic less than intuitive, I wanted to make it easier on the next person
@mcculls mcculls mentioned this pull request May 5, 2024
Closed
@dougqh dougqh changed the title Dougqh/sampling provenance Adding sampling provenance/mechanism to SamplingRules May 6, 2024
mcculls
mcculls approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@mcculls mcculls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 verified TestDynamicConfigSamplingRules passes with these changes

@pr-commenter
Copy link

pr-commenter bot commented May 6, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master dougqh/sampling-provenance
git_commit_date 1715017090 1715017556
git_commit_sha 7b141be 4025045
release_version 1.34.0-SNAPSHOT~7b141beb4e 1.34.0-SNAPSHOT~402504505c
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1715020330 1715020330
ci_job_id 505343671 505343671
ci_pipeline_id 33690570 33690570
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 13 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.34.0-SNAPSHOT~402504505c, baseline=1.34.0-SNAPSHOT~7b141beb4e

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.078 s) : 0, 1077633
Total [baseline] (8.577 s) : 0, 8577178
Agent [candidate] (1.077 s) : 0, 1076878
Total [candidate] (8.55 s) : 0, 8550072
section iast
Agent [baseline] (1.203 s) : 0, 1203323
Total [baseline] (9.008 s) : 0, 9008000
Agent [candidate] (1.202 s) : 0, 1201730
Total [candidate] (9.002 s) : 0, 9002028
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.204 s) : 0, 1203543
Total [baseline] (9.012 s) : 0, 9012301
Agent [candidate] (1.204 s) : 0, 1203604
Total [candidate] (8.985 s) : 0, 8984700
section iast_TELEMETRY_OFF
Agent [baseline] (1.202 s) : 0, 1202307
Total [baseline] (9.011 s) : 0, 9010585
Agent [candidate] (1.209 s) : 0, 1208775
Total [candidate] (8.994 s) : 0, 8993850
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.078 s -
Agent iast 1.203 s 125.69 ms (11.7%)
Agent iast_HARDCODED_SECRET_DISABLED 1.204 s 125.91 ms (11.7%)
Agent iast_TELEMETRY_OFF 1.202 s 124.674 ms (11.6%)
Total tracing 8.577 s -
Total iast 9.008 s 430.823 ms (5.0%)
Total iast_HARDCODED_SECRET_DISABLED 9.012 s 435.123 ms (5.1%)
Total iast_TELEMETRY_OFF 9.011 s 433.407 ms (5.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.077 s -
Agent iast 1.202 s 124.852 ms (11.6%)
Agent iast_HARDCODED_SECRET_DISABLED 1.204 s 126.726 ms (11.8%)
Agent iast_TELEMETRY_OFF 1.209 s 131.897 ms (12.2%)
Total tracing 8.55 s -
Total iast 9.002 s 451.955 ms (5.3%)
Total iast_HARDCODED_SECRET_DISABLED 8.985 s 434.628 ms (5.1%)
Total iast_TELEMETRY_OFF 8.994 s 443.778 ms (5.2%) 
gantt
    title insecure-bank - break down per module: candidate=1.34.0-SNAPSHOT~402504505c, baseline=1.34.0-SNAPSHOT~7b141beb4e

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (675.199 ms) : 0, 675199
BytebuddyAgent [candidate] (674.369 ms) : 0, 674369
GlobalTracer [baseline] (310.516 ms) : 0, 310516
GlobalTracer [candidate] (310.332 ms) : 0, 310332
AppSec [baseline] (49.347 ms) : 0, 49347
AppSec [candidate] (49.546 ms) : 0, 49546
Remote Config [baseline] (661.627 µs) : 0, 662
Remote Config [candidate] (658.997 µs) : 0, 659
Telemetry [baseline] (7.536 ms) : 0, 7536
Telemetry [candidate] (7.603 ms) : 0, 7603
section iast
BytebuddyAgent [baseline] (796.588 ms) : 0, 796588
BytebuddyAgent [candidate] (795.152 ms) : 0, 795152
GlobalTracer [baseline] (290.255 ms) : 0, 290255
GlobalTracer [candidate] (290.205 ms) : 0, 290205
AppSec [baseline] (50.297 ms) : 0, 50297
AppSec [candidate] (51.449 ms) : 0, 51449
Remote Config [baseline] (560.565 µs) : 0, 561
Remote Config [candidate] (583.629 µs) : 0, 584
Telemetry [baseline] (6.533 ms) : 0, 6533
Telemetry [candidate] (7.438 ms) : 0, 7438
IAST [baseline] (24.637 ms) : 0, 24637
IAST [candidate] (22.451 ms) : 0, 22451
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (796.265 ms) : 0, 796265
BytebuddyAgent [candidate] (796.294 ms) : 0, 796294
GlobalTracer [baseline] (290.213 ms) : 0, 290213
GlobalTracer [candidate] (291.033 ms) : 0, 291033
AppSec [baseline] (49.5 ms) : 0, 49500
AppSec [candidate] (48.866 ms) : 0, 48866
Remote Config [baseline] (580.993 µs) : 0, 581
Remote Config [candidate] (571.523 µs) : 0, 572
Telemetry [baseline] (7.374 ms) : 0, 7374
Telemetry [candidate] (6.585 ms) : 0, 6585
IAST [baseline] (25.139 ms) : 0, 25139
IAST [candidate] (25.82 ms) : 0, 25820
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (794.415 ms) : 0, 794415
BytebuddyAgent [candidate] (799.702 ms) : 0, 799702
GlobalTracer [baseline] (290.936 ms) : 0, 290936
GlobalTracer [candidate] (292.342 ms) : 0, 292342
AppSec [baseline] (53.731 ms) : 0, 53731
AppSec [candidate] (51.979 ms) : 0, 51979
Remote Config [baseline] (590.032 µs) : 0, 590
Remote Config [candidate] (628.753 µs) : 0, 629
Telemetry [baseline] (6.625 ms) : 0, 6625
Telemetry [candidate] (6.621 ms) : 0, 6621
IAST [baseline] (21.576 ms) : 0, 21576
IAST [candidate] (22.936 ms) : 0, 22936
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.34.0-SNAPSHOT~402504505c, baseline=1.34.0-SNAPSHOT~7b141beb4e

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.079 s) : 0, 1079155
Total [baseline] (10.478 s) : 0, 10478357
Agent [candidate] (1.084 s) : 0, 1084000
Total [candidate] (10.433 s) : 0, 10433317
section appsec
Agent [baseline] (1.194 s) : 0, 1194113
Total [baseline] (10.54 s) : 0, 10539944
Agent [candidate] (1.192 s) : 0, 1191841
Total [candidate] (10.472 s) : 0, 10472350
section iast
Agent [baseline] (1.203 s) : 0, 1203160
Total [baseline] (10.734 s) : 0, 10733875
Agent [candidate] (1.214 s) : 0, 1213580
Total [candidate] (10.753 s) : 0, 10752952
section profiling
Agent [baseline] (1.279 s) : 0, 1279092
Total [baseline] (10.71 s) : 0, 10709952
Agent [candidate] (1.274 s) : 0, 1273737
Total [candidate] (10.669 s) : 0, 10668813
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.079 s -
Agent appsec 1.194 s 114.958 ms (10.7%)
Agent iast 1.203 s 124.004 ms (11.5%)
Agent profiling 1.279 s 199.937 ms (18.5%)
Total tracing 10.478 s -
Total appsec 10.54 s 61.587 ms (0.6%)
Total iast 10.734 s 255.518 ms (2.4%)
Total profiling 10.71 s 231.595 ms (2.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.084 s -
Agent appsec 1.192 s 107.841 ms (9.9%)
Agent iast 1.214 s 129.579 ms (12.0%)
Agent profiling 1.274 s 189.737 ms (17.5%)
Total tracing 10.433 s -
Total appsec 10.472 s 39.033 ms (0.4%)
Total iast 10.753 s 319.635 ms (3.1%)
Total profiling 10.669 s 235.495 ms (2.3%) 
gantt
    title petclinic - break down per module: candidate=1.34.0-SNAPSHOT~402504505c, baseline=1.34.0-SNAPSHOT~7b141beb4e

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (676.102 ms) : 0, 676102
BytebuddyAgent [candidate] (678.628 ms) : 0, 678628
GlobalTracer [baseline] (310.876 ms) : 0, 310876
GlobalTracer [candidate] (312.533 ms) : 0, 312533
AppSec [baseline] (49.446 ms) : 0, 49446
AppSec [candidate] (49.927 ms) : 0, 49927
Remote Config [baseline] (665.178 µs) : 0, 665
Remote Config [candidate] (665.426 µs) : 0, 665
Telemetry [baseline] (7.601 ms) : 0, 7601
Telemetry [candidate] (7.65 ms) : 0, 7650
section appsec
BytebuddyAgent [baseline] (698.737 ms) : 0, 698737
BytebuddyAgent [candidate] (696.354 ms) : 0, 696354
GlobalTracer [baseline] (293.236 ms) : 0, 293236
GlobalTracer [candidate] (293.027 ms) : 0, 293027
AppSec [baseline] (148.913 ms) : 0, 148913
AppSec [candidate] (149.026 ms) : 0, 149026
Remote Config [baseline] (618.192 µs) : 0, 618
Remote Config [candidate] (618.107 µs) : 0, 618
Telemetry [baseline] (8.502 ms) : 0, 8502
Telemetry [candidate] (8.768 ms) : 0, 8768
IAST [baseline] (19.25 ms) : 0, 19250
IAST [candidate] (19.276 ms) : 0, 19276
section iast
BytebuddyAgent [baseline] (796.295 ms) : 0, 796295
BytebuddyAgent [candidate] (803.042 ms) : 0, 803042
GlobalTracer [baseline] (290.419 ms) : 0, 290419
GlobalTracer [candidate] (292.945 ms) : 0, 292945
AppSec [baseline] (51.641 ms) : 0, 51641
AppSec [candidate] (51.938 ms) : 0, 51938
Remote Config [baseline] (579.557 µs) : 0, 580
Remote Config [candidate] (571.633 µs) : 0, 572
Telemetry [baseline] (6.595 ms) : 0, 6595
Telemetry [candidate] (6.682 ms) : 0, 6682
IAST [baseline] (23.277 ms) : 0, 23277
IAST [candidate] (23.65 ms) : 0, 23650
section profiling
BytebuddyAgent [baseline] (683.811 ms) : 0, 683811
BytebuddyAgent [candidate] (679.092 ms) : 0, 679092
GlobalTracer [baseline] (383.713 ms) : 0, 383713
GlobalTracer [candidate] (383.14 ms) : 0, 383140
AppSec [baseline] (50.49 ms) : 0, 50490
AppSec [candidate] (50.325 ms) : 0, 50325
Remote Config [baseline] (709.535 µs) : 0, 710
Remote Config [candidate] (714.261 µs) : 0, 714
Telemetry [baseline] (7.457 ms) : 0, 7457
Telemetry [candidate] (7.532 ms) : 0, 7532
ProfilingAgent [baseline] (96.056 ms) : 0, 96056
ProfilingAgent [candidate] (96.408 ms) : 0, 96408
Profiling [baseline] (96.08 ms) : 0, 96080
Profiling [candidate] (96.432 ms) : 0, 96432
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-05-06T18:02:45 2024-05-06T18:09:34
git_branch master dougqh/sampling-provenance
git_commit_date 1715017090 1715017556
git_commit_sha 7b141be 4025045
release_version 1.34.0-SNAPSHOT~7b141beb4e 1.34.0-SNAPSHOT~402504505c
start_time 2024-05-06T18:02:32 2024-05-06T18:09:21
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1715019318 1715019318
ci_job_id 505343673 505343673
ci_pipeline_id 33690570 33690570
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.34.0-SNAPSHOT~402504505c, baseline=1.34.0-SNAPSHOT~7b141beb4e
    dateFormat X
    axisFormat %s
section baseline
no_agent (371.552 µs) : 351, 392
.   : milestone, 372,
iast (471.992 µs) : 451, 492
.   : milestone, 472,
iast_FULL (536.204 µs) : 516, 557
.   : milestone, 536,
iast_GLOBAL (493.693 µs) : 473, 514
.   : milestone, 494,
iast_HARDCODED_SECRET_DISABLED (471.702 µs) : 451, 492
.   : milestone, 472,
iast_INACTIVE (446.08 µs) : 425, 467
.   : milestone, 446,
iast_TELEMETRY_OFF (466.987 µs) : 446, 488
.   : milestone, 467,
tracing (446.637 µs) : 424, 469
.   : milestone, 447,
section candidate
no_agent (370.757 µs) : 351, 390
.   : milestone, 371,
iast (472.211 µs) : 452, 493
.   : milestone, 472,
iast_FULL (537.712 µs) : 517, 559
.   : milestone, 538,
iast_GLOBAL (491.803 µs) : 471, 513
.   : milestone, 492,
iast_HARDCODED_SECRET_DISABLED (470.835 µs) : 450, 491
.   : milestone, 471,
iast_INACTIVE (440.371 µs) : 420, 461
.   : milestone, 440,
iast_TELEMETRY_OFF (467.663 µs) : 446, 489
.   : milestone, 468,
tracing (445.4 µs) : 425, 466
.   : milestone, 445,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 371.552 µs [351.21 µs, 391.894 µs] -
iast 471.992 µs [451.497 µs, 492.487 µs] 100.44 µs (27.0%)
iast_FULL 536.204 µs [515.707 µs, 556.702 µs] 164.652 µs (44.3%)
iast_GLOBAL 493.693 µs [473.181 µs, 514.205 µs] 122.14 µs (32.9%)
iast_HARDCODED_SECRET_DISABLED 471.702 µs [451.148 µs, 492.255 µs] 100.149 µs (27.0%)
iast_INACTIVE 446.08 µs [425.429 µs, 466.732 µs] 74.528 µs (20.1%)
iast_TELEMETRY_OFF 466.987 µs [446.149 µs, 487.825 µs] 95.434 µs (25.7%)
tracing 446.637 µs [424.395 µs, 468.878 µs] 75.085 µs (20.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 370.757 µs [351.079 µs, 390.435 µs] -
iast 472.211 µs [451.692 µs, 492.73 µs] 101.454 µs (27.4%)
iast_FULL 537.712 µs [516.908 µs, 558.516 µs] 166.955 µs (45.0%)
iast_GLOBAL 491.803 µs [470.908 µs, 512.699 µs] 121.047 µs (32.6%)
iast_HARDCODED_SECRET_DISABLED 470.835 µs [450.298 µs, 491.371 µs] 100.078 µs (27.0%)
iast_INACTIVE 440.371 µs [420.151 µs, 460.592 µs] 69.614 µs (18.8%)
iast_TELEMETRY_OFF 467.663 µs [446.016 µs, 489.31 µs] 96.906 µs (26.1%)
tracing 445.4 µs [424.698 µs, 466.102 µs] 74.643 µs (20.1%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.34.0-SNAPSHOT~402504505c, baseline=1.34.0-SNAPSHOT~7b141beb4e
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.352 ms) : 1332, 1372
.   : milestone, 1352,
appsec (1.734 ms) : 1711, 1757
.   : milestone, 1734,
appsec_no_iast (1.706 ms) : 1682, 1730
.   : milestone, 1706,
iast (1.474 ms) : 1452, 1496
.   : milestone, 1474,
profiling (1.5 ms) : 1475, 1524
.   : milestone, 1500,
tracing (1.502 ms) : 1477, 1527
.   : milestone, 1502,
section candidate
no_agent (1.355 ms) : 1337, 1374
.   : milestone, 1355,
appsec (1.729 ms) : 1705, 1752
.   : milestone, 1729,
appsec_no_iast (1.713 ms) : 1689, 1738
.   : milestone, 1713,
iast (1.489 ms) : 1466, 1512
.   : milestone, 1489,
profiling (1.546 ms) : 1520, 1571
.   : milestone, 1546,
tracing (1.476 ms) : 1452, 1501
.   : milestone, 1476,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.352 ms [1.332 ms, 1.372 ms] -
appsec 1.734 ms [1.711 ms, 1.757 ms] 381.763 µs (28.2%)
appsec_no_iast 1.706 ms [1.682 ms, 1.73 ms] 353.953 µs (26.2%)
iast 1.474 ms [1.452 ms, 1.496 ms] 121.659 µs (9.0%)
profiling 1.5 ms [1.475 ms, 1.524 ms] 147.518 µs (10.9%)
tracing 1.502 ms [1.477 ms, 1.527 ms] 149.574 µs (11.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.355 ms [1.337 ms, 1.374 ms] -
appsec 1.729 ms [1.705 ms, 1.752 ms] 373.162 µs (27.5%)
appsec_no_iast 1.713 ms [1.689 ms, 1.738 ms] 358.079 µs (26.4%)
iast 1.489 ms [1.466 ms, 1.512 ms] 133.757 µs (9.9%)
profiling 1.546 ms [1.52 ms, 1.571 ms] 190.228 µs (14.0%)
tracing 1.476 ms [1.452 ms, 1.501 ms] 120.992 µs (8.9%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master dougqh/sampling-provenance
git_commit_date 1715017090 1715017556
git_commit_sha 7b141be 4025045
release_version 1.34.0-SNAPSHOT~7b141beb4e 1.34.0-SNAPSHOT~402504505c
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1715019819 1715019819
ci_job_id 505343675 505343675
ci_pipeline_id 33690570 33690570
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.34.0-SNAPSHOT~402504505c, baseline=1.34.0-SNAPSHOT~7b141beb4e
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.458 ms) : 1447, 1470
.   : milestone, 1458,
appsec (2.193 ms) : 2160, 2227
.   : milestone, 2193,
iast (1.872 ms) : 1837, 1907
.   : milestone, 1872,
iast_GLOBAL (1.905 ms) : 1869, 1940
.   : milestone, 1905,
profiling (2.305 ms) : 2125, 2485
.   : milestone, 2305,
tracing (1.818 ms) : 1787, 1850
.   : milestone, 1818,
section candidate
no_agent (1.458 ms) : 1446, 1469
.   : milestone, 1458,
appsec (2.184 ms) : 2150, 2218
.   : milestone, 2184,
iast (1.866 ms) : 1831, 1901
.   : milestone, 1866,
iast_GLOBAL (1.912 ms) : 1877, 1948
.   : milestone, 1912,
profiling (1.839 ms) : 1806, 1872
.   : milestone, 1839,
tracing (1.814 ms) : 1782, 1846
.   : milestone, 1814,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.458 ms [1.447 ms, 1.47 ms] -
appsec 2.193 ms [2.16 ms, 2.227 ms] 735.381 µs (50.4%)
iast 1.872 ms [1.837 ms, 1.907 ms] 413.726 µs (28.4%)
iast_GLOBAL 1.905 ms [1.869 ms, 1.94 ms] 446.582 µs (30.6%)
profiling 2.305 ms [2.125 ms, 2.485 ms] 846.984 µs (58.1%)
tracing 1.818 ms [1.787 ms, 1.85 ms] 360.161 µs (24.7%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.458 ms [1.446 ms, 1.469 ms] -
appsec 2.184 ms [2.15 ms, 2.218 ms] 726.361 µs (49.8%)
iast 1.866 ms [1.831 ms, 1.901 ms] 408.175 µs (28.0%)
iast_GLOBAL 1.912 ms [1.877 ms, 1.948 ms] 454.593 µs (31.2%)
profiling 1.839 ms [1.806 ms, 1.872 ms] 381.119 µs (26.1%)
tracing 1.814 ms [1.782 ms, 1.846 ms] 356.489 µs (24.5%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.34.0-SNAPSHOT~402504505c, baseline=1.34.0-SNAPSHOT~7b141beb4e
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.048 s) : 15048000, 15048000
.   : milestone, 15048000,
appsec (14.805 s) : 14805000, 14805000
.   : milestone, 14805000,
iast (18.992 s) : 18992000, 18992000
.   : milestone, 18992000,
iast_GLOBAL (17.856 s) : 17856000, 17856000
.   : milestone, 17856000,
profiling (15.113 s) : 15113000, 15113000
.   : milestone, 15113000,
tracing (15.031 s) : 15031000, 15031000
.   : milestone, 15031000,
section candidate
no_agent (15.521 s) : 15521000, 15521000
.   : milestone, 15521000,
appsec (15.032 s) : 15032000, 15032000
.   : milestone, 15032000,
iast (18.88 s) : 18880000, 18880000
.   : milestone, 18880000,
iast_GLOBAL (17.963 s) : 17963000, 17963000
.   : milestone, 17963000,
profiling (15.292 s) : 15292000, 15292000
.   : milestone, 15292000,
tracing (14.989 s) : 14989000, 14989000
.   : milestone, 14989000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.048 s [15.048 s, 15.048 s] -
appsec 14.805 s [14.805 s, 14.805 s] -243.0 ms (-1.6%)
iast 18.992 s [18.992 s, 18.992 s] 3.944 s (26.2%)
iast_GLOBAL 17.856 s [17.856 s, 17.856 s] 2.808 s (18.7%)
profiling 15.113 s [15.113 s, 15.113 s] 65.0 ms (0.4%)
tracing 15.031 s [15.031 s, 15.031 s] -17.0 ms (-0.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.521 s [15.521 s, 15.521 s] -
appsec 15.032 s [15.032 s, 15.032 s] -489.0 ms (-3.2%)
iast 18.88 s [18.88 s, 18.88 s] 3.359 s (21.6%)
iast_GLOBAL 17.963 s [17.963 s, 17.963 s] 2.442 s (15.7%)
profiling 15.292 s [15.292 s, 15.292 s] -229.0 ms (-1.5%)
tracing 14.989 s [14.989 s, 14.989 s] -532.0 ms (-3.4%)

@bm1549 bm1549 merged commit dd4d2fe into master May 6, 2024
@bm1549 bm1549 deleted the dougqh/sampling-provenance branch May 6, 2024 19:12
@github-actions github-actions bot added this to the 1.34.0 milestone May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcculls mcculls mcculls approved these changes

@PerfectSlayer PerfectSlayer Awaiting requested review from PerfectSlayer PerfectSlayer is a code owner automatically assigned from DataDog/apm-java

@ygree ygree Awaiting requested review from ygree ygree is a code owner automatically assigned from DataDog/apm-java

@am312 am312 Awaiting requested review from am312

Assignees

No one assigned

Labels

comp: core Tracer core type: feature request

Projects

None yet

Milestone

1.34.0

Development

Successfully merging this pull request may close these issues.

4 participants

@dougqh @mcculls @bm1549