Skip to content

Exclude otel 0.9.0 that started failing muzzle #1954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2020
Merged

Exclude otel 0.9.0 that started failing muzzle #1954

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion dd-java-agent/instrumentation/opentelemetry/opentelemetry.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,10 @@ muzzle {
group = 'io.opentelemetry'
versions = "[$otelVersion,0.8.0)"
assertInverse = true
skipVersions = ['0.2.2', '0.2.3']
// I have no idea why gradle doesn't respect the version range above
// but I also have no time to figure it out for an instrumentation
// that is experimental
Comment on lines +10 to +12
Copy link
Contributor

@tylerbenson tylerbenson Oct 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason for this is we have assertInverse=true, so it still tries to check against versions outside that range.

Copy link
Contributor Author

@bantonsson bantonsson Oct 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we have assertInverse=true?

skipVersions = ['0.2.2', '0.2.3', '0.9.0']
}
}

Expand Down