Skip to content

Conversation

@bantonsson
Copy link
Contributor

No description provided.

@bantonsson bantonsson requested a review from a team as a code owner October 6, 2020 09:09
@bantonsson bantonsson self-assigned this Oct 6, 2020
@bantonsson bantonsson added the tag: no release notes Changes to exclude from release notes label Oct 6, 2020
@bantonsson bantonsson merged commit 1706a91 into master Oct 6, 2020
@bantonsson bantonsson deleted the ban/muzzle-otel branch October 6, 2020 09:51
@github-actions github-actions bot added this to the 0.65.0 milestone Oct 6, 2020
Comment on lines +10 to +12
// I have no idea why gradle doesn't respect the version range above
// but I also have no time to figure it out for an instrumentation
// that is experimental
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason for this is we have assertInverse=true, so it still tries to check against versions outside that range.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we have assertInverse=true?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tag: no release notes Changes to exclude from release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants