Fix CI Memory and HttpClient Test #159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gradle was using too much memory when testing and building in the same step, causing CI to kill the process forcefully. Separating them out resolves the problem.
realark
added
comp: testing
tylerbenson
approved these changes
Nov 29, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far there have been two problems identified.
Cassandra integration tests run out of memory.New project dependencies cause gradle to use too much memory.Pulling in new dependencies was increasing gradle's memory usage to the point where CI was forcefully killing it (exit 137). Fixed by creating a separate step for building. This guarantees the test step will use the cached dependencies instead of fetching new ones.
The byteman bug is alarming, as it suggests that there are certain configurations our byteman instrumentation will not apply on. However, this instrumentation is currently being replaced by an entirely different strategy, so a workaround in the test should be acceptable for now.
https://trello.com/c/NdTKWrUU/201-improve-byteman-or-find-a-good-replacement
Latest changes to this branch have passed all CI runs (three runs total, one with caching disabled).