cassandra bytebuddy #157
cassandra bytebuddy #157
Conversation
realark
force-pushed
the
ark/cassandra_bytebuddy
branch
2 times, most recently
from
e25d399 to
ea503ab
Compare
realark
force-pushed
the
ark/cassandra_bytebuddy
branch
from
ea503ab to
463cd97
Compare
|
@tylerbenson Anything else you want to add? |
There was a problem hiding this comment.
Since you're not checking for the presence of particular classes, this could instrument on versions of the library you might not intend. If you're ok with that, or this is something you want to deal with later, then I'm ok with merging.
There was a problem hiding this comment.
Good point. I'll add some extra checks for particular classes used by the instrumentation before merging this.
|
It'd be nice if we could rebase after #159 is merged to see a clean build. |
realark
force-pushed
the
ark/cassandra_bytebuddy
branch
from
463cd97 to
7298b0a
Compare
Now you can run `./gradlew :dd-java-agent:integrations:datastax-cassandra-3.2::scanVersionsReport -PshowClasses` to show you the classes you can use for that version range.
| .type( | ||
| named("com.datastax.driver.core.Cluster$Manager"), | ||
| classLoaderHasClasses( | ||
| "com.datastax.driver.core.BoundStatement", |
There was a problem hiding this comment.
I don't think you need to list all of these... a subset of classes should be enough. I would also suggest only including classes that are tested with the verifier (and include all of them): https://github.com/DataDog/dd-trace-java/blob/master/dd-java-agent/integrations/datastax-cassandra-3.2/datastax-cassandra-3.2.gradle#L11
Uh oh!
There was an error while loading. Please reload this page.