-
Notifications
You must be signed in to change notification settings - Fork 151
[Config inversion] inversion check configurationkeys are in json #7556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: anna/config-inversion-supported-config-file
Are you sure you want to change the base?
[Config inversion] inversion check configurationkeys are in json #7556
Conversation
7dbf345
to
8d4256d
Compare
65fbbec
to
3bb22a8
Compare
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat X
axisFormat %s
todayMarker off
section Bailout
This PR (7556) - mean (75ms) : 73, 77
. : milestone, 75,
master - mean (72ms) : 71, 73
. : milestone, 72,
section Baseline
This PR (7556) - mean (71ms) : 69, 73
. : milestone, 71,
master - mean (68ms) : 66, 71
. : milestone, 68,
section CallTarget+Inlining+NGEN
This PR (7556) - mean (1,066ms) : 1017, 1116
. : milestone, 1066,
master - mean (1,047ms) : 997, 1097
. : milestone, 1047,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Bailout
This PR (7556) - mean (111ms) : 110, 113
. : milestone, 111,
master - mean (106ms) : 105, 107
. : milestone, 106,
section Baseline
This PR (7556) - mean (110ms) : 106, 113
. : milestone, 110,
master - mean (106ms) : 103, 108
. : milestone, 106,
section CallTarget+Inlining+NGEN
This PR (7556) - mean (755ms) : 737, 774
. : milestone, 755,
master - mean (741ms) : 719, 764
. : milestone, 741,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Bailout
This PR (7556) - mean (106ms) : crit, 103, 108
. : crit, milestone, 106,
master - mean (94ms) : 93, 95
. : milestone, 94,
section Baseline
This PR (7556) - mean (105ms) : 102, 108
. : milestone, 105,
master - mean (94ms) : 91, 96
. : milestone, 94,
section CallTarget+Inlining+NGEN
This PR (7556) - mean (794ms) : crit, 749, 839
. : crit, milestone, 794,
master - mean (701ms) : 684, 719
. : milestone, 701,
gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat X
axisFormat %s
todayMarker off
section Bailout
This PR (7556) - mean (97ms) : 96, 99
. : milestone, 97,
master - mean (92ms) : 91, 94
. : milestone, 92,
section Baseline
This PR (7556) - mean (96ms) : 94, 98
. : milestone, 96,
master - mean (92ms) : 90, 94
. : milestone, 92,
section CallTarget+Inlining+NGEN
This PR (7556) - mean (671ms) : 656, 687
. : milestone, 671,
master - mean (666ms) : 648, 683
. : milestone, 666,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat X
axisFormat %s
todayMarker off
section Bailout
This PR (7556) - mean (201ms) : 195, 206
. : milestone, 201,
master - mean (199ms) : 195, 202
. : milestone, 199,
section Baseline
This PR (7556) - mean (197ms) : 193, 201
. : milestone, 197,
master - mean (196ms) : 191, 201
. : milestone, 196,
section CallTarget+Inlining+NGEN
This PR (7556) - mean (1,174ms) : 1122, 1226
. : milestone, 1174,
master - mean (1,180ms) : 1114, 1246
. : milestone, 1180,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Bailout
This PR (7556) - mean (283ms) : 276, 290
. : milestone, 283,
master - mean (282ms) : 276, 287
. : milestone, 282,
section Baseline
This PR (7556) - mean (284ms) : 273, 295
. : milestone, 284,
master - mean (282ms) : 277, 286
. : milestone, 282,
section CallTarget+Inlining+NGEN
This PR (7556) - mean (958ms) : 910, 1006
. : milestone, 958,
master - mean (943ms) : 905, 982
. : milestone, 943,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Bailout
This PR (7556) - mean (288ms) : 280, 295
. : milestone, 288,
master - mean (275ms) : 270, 280
. : milestone, 275,
section Baseline
This PR (7556) - mean (287ms) : 280, 294
. : milestone, 287,
master - mean (276ms) : 270, 281
. : milestone, 276,
section CallTarget+Inlining+NGEN
This PR (7556) - mean (1,003ms) : crit, 961, 1045
. : crit, milestone, 1003,
master - mean (931ms) : 891, 971
. : milestone, 931,
gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat X
axisFormat %s
todayMarker off
section Bailout
This PR (7556) - mean (275ms) : 270, 281
. : milestone, 275,
master - mean (276ms) : 269, 282
. : milestone, 276,
section Baseline
This PR (7556) - mean (275ms) : 269, 282
. : milestone, 275,
master - mean (273ms) : 268, 278
. : milestone, 273,
section CallTarget+Inlining+NGEN
This PR (7556) - mean (860ms) : 840, 880
. : milestone, 860,
master - mean (863ms) : 843, 883
. : milestone, 863,
|
3bb22a8
to
cbb3593
Compare
d340651
to
aef9602
Compare
8d4256d
to
afa84af
Compare
57a0761
to
437db7e
Compare
This comment has been minimized.
This comment has been minimized.
afa84af
to
05247c7
Compare
437db7e
to
e4fb133
Compare
05247c7
to
c50a9c1
Compare
e4fb133
to
bc2ad02
Compare
c50a9c1
to
7dbfceb
Compare
5a9a712
to
6d51e76
Compare
7dbfceb
to
56b17eb
Compare
6d51e76
to
f9bb5ba
Compare
56b17eb
to
7fb125e
Compare
f9bb5ba
to
1bc1b38
Compare
7fb125e
to
25fa9a0
Compare
1bc1b38
to
d72acce
Compare
…f ConfigurationKeys class doesnt list config keys not present in the json
3ab9889
to
e31264e
Compare
Summary of changes
Reason for change
Implementation details
Test coverage
Other details