Skip to content

Commit aef9602

Browse files
anna-gitanna-git
committed
Adapt platform key usage in tests
1 parent 9551e2d commit aef9602

11 files changed

+56
-56
lines changed

‎tracer/test/Datadog.Trace.TestHelpers/PlatformHelpers/AzureAppServiceHelper.cs‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -50,10 +50,10 @@ public static IConfigurationSource GetRequiredAasConfigurationValues(
5050
{
5151
var vars = Environment.GetEnvironmentVariables();
5252

53-
if (vars.Contains(ConfigurationKeys.AzureAppService.InstanceNameKey))
53+
if (vars.Contains(PlatformKeys.AzureAppService.InstanceNameKey))
5454
{
5555
// This is the COMPUTERNAME key which we'll remove for consistent testing
56-
vars.Remove(ConfigurationKeys.AzureAppService.InstanceNameKey);
56+
vars.Remove(PlatformKeys.AzureAppService.InstanceNameKey);
5757
}
5858

5959
if (vars.Contains(ConfigurationKeys.DebugEnabled))
@@ -73,22 +73,22 @@ public static IConfigurationSource GetRequiredAasConfigurationValues(
7373
vars.Add(ConfigurationKeys.AzureAppService.SiteExtensionVersionKey, "3.0.0");
7474
}
7575

76-
vars.Add(ConfigurationKeys.AzureAppService.WebsiteOwnerNameKey, $"{subscriptionId}+{planResourceGroup}-EastUSwebspace");
77-
vars.Add(ConfigurationKeys.AzureAppService.ResourceGroupKey, siteResourceGroup);
78-
vars.Add(ConfigurationKeys.AzureAppService.SiteNameKey, deploymentId);
79-
vars.Add(ConfigurationKeys.AzureAppService.OperatingSystemKey, RuntimeInformation.IsOSPlatform(OSPlatform.Windows) ? "windows" : "linux");
80-
vars.Add(ConfigurationKeys.AzureAppService.InstanceIdKey, "instance_id");
81-
vars.Add(ConfigurationKeys.AzureAppService.InstanceNameKey, "instance_name");
76+
vars.Add(PlatformKeys.AzureAppService.WebsiteOwnerNameKey, $"{subscriptionId}+{planResourceGroup}-EastUSwebspace");
77+
vars.Add(PlatformKeys.AzureAppService.ResourceGroupKey, siteResourceGroup);
78+
vars.Add(PlatformKeys.AzureAppService.SiteNameKey, deploymentId);
79+
vars.Add(PlatformKeys.AzureAppService.OperatingSystemKey, RuntimeInformation.IsOSPlatform(OSPlatform.Windows) ? "windows" : "linux");
80+
vars.Add(PlatformKeys.AzureAppService.InstanceIdKey, "instance_id");
81+
vars.Add(PlatformKeys.AzureAppService.InstanceNameKey, "instance_name");
8282
vars.Add(ConfigurationKeys.DebugEnabled, ddTraceDebug);
8383

8484
if (functionsVersion != null)
8585
{
86-
vars.Add(ConfigurationKeys.AzureFunctions.FunctionsExtensionVersion, functionsVersion);
86+
vars.Add(PlatformKeys.AzureFunctions.FunctionsExtensionVersion, functionsVersion);
8787
}
8888

8989
if (functionsRuntime != null)
9090
{
91-
vars.Add(ConfigurationKeys.AzureFunctions.FunctionsWorkerRuntime, functionsRuntime);
91+
vars.Add(PlatformKeys.AzureFunctions.FunctionsWorkerRuntime, functionsRuntime);
9292
}
9393

9494
vars.Add(ConfigurationKeys.AzureAppService.AasEnableCustomTracing, enableCustomTracing ?? "false");

‎tracer/test/Datadog.Trace.Tests/Configuration/ImmutableAzureAppServiceSettingsTests.cs‎

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ public void IsUnsafeToTrace(string value, bool expected)
3636
[InlineData("test1+test2", "test1")]
3737
public void SubscriptionId(string value, string expected)
3838
{
39-
var source = CreateConfigurationSource((ConfigurationKeys.AzureAppService.WebsiteOwnerNameKey, value));
39+
var source = CreateConfigurationSource((PlatformKeys.AzureAppService.WebsiteOwnerNameKey, value));
4040
var settings = new ImmutableAzureAppServiceSettings(source, NullConfigurationTelemetry.Instance);
4141

4242
settings.SubscriptionId.Should().Be(expected);
@@ -46,7 +46,7 @@ public void SubscriptionId(string value, string expected)
4646
[MemberData(nameof(StringTestCases))]
4747
public void ResourceGroup(string value, string expected)
4848
{
49-
var source = CreateConfigurationSource((ConfigurationKeys.AzureAppService.ResourceGroupKey, value));
49+
var source = CreateConfigurationSource((PlatformKeys.AzureAppService.ResourceGroupKey, value));
5050
var settings = new ImmutableAzureAppServiceSettings(source, NullConfigurationTelemetry.Instance);
5151

5252
settings.ResourceGroup.Should().Be(expected);
@@ -56,7 +56,7 @@ public void ResourceGroup(string value, string expected)
5656
[MemberData(nameof(StringTestCases))]
5757
public void SiteName(string value, string expected)
5858
{
59-
var source = CreateConfigurationSource((ConfigurationKeys.AzureAppService.SiteNameKey, value));
59+
var source = CreateConfigurationSource((PlatformKeys.AzureAppService.SiteNameKey, value));
6060
var settings = new ImmutableAzureAppServiceSettings(source, NullConfigurationTelemetry.Instance);
6161

6262
settings.SiteName.Should().Be(expected);
@@ -72,9 +72,9 @@ public void SiteName(string value, string expected)
7272
public void ResourceId(string subscriptionId, string siteName, string resourceGroup, string expected)
7373
{
7474
var source = CreateConfigurationSource(
75-
(ConfigurationKeys.AzureAppService.SiteNameKey, siteName),
76-
(ConfigurationKeys.AzureAppService.ResourceGroupKey, resourceGroup),
77-
(ConfigurationKeys.AzureAppService.WebsiteOwnerNameKey, subscriptionId));
75+
(PlatformKeys.AzureAppService.SiteNameKey, siteName),
76+
(PlatformKeys.AzureAppService.ResourceGroupKey, resourceGroup),
77+
(PlatformKeys.AzureAppService.WebsiteOwnerNameKey, subscriptionId));
7878

7979
var settings = new ImmutableAzureAppServiceSettings(source, NullConfigurationTelemetry.Instance);
8080

@@ -85,7 +85,7 @@ public void ResourceId(string subscriptionId, string siteName, string resourceGr
8585
[MemberData(nameof(StringTestCases), "unknown", Strings.AllowEmpty)]
8686
public void InstanceId(string value, string expected)
8787
{
88-
var source = CreateConfigurationSource((ConfigurationKeys.AzureAppService.InstanceIdKey, value));
88+
var source = CreateConfigurationSource((PlatformKeys.AzureAppService.InstanceIdKey, value));
8989
var settings = new ImmutableAzureAppServiceSettings(source, NullConfigurationTelemetry.Instance);
9090

9191
settings.InstanceId.Should().Be(expected);
@@ -95,7 +95,7 @@ public void InstanceId(string value, string expected)
9595
[MemberData(nameof(StringTestCases), "unknown", Strings.AllowEmpty)]
9696
public void InstanceName(string value, string expected)
9797
{
98-
var source = CreateConfigurationSource((ConfigurationKeys.AzureAppService.InstanceNameKey, value));
98+
var source = CreateConfigurationSource((PlatformKeys.AzureAppService.InstanceNameKey, value));
9999
var settings = new ImmutableAzureAppServiceSettings(source, NullConfigurationTelemetry.Instance);
100100

101101
settings.InstanceName.Should().Be(expected);
@@ -105,7 +105,7 @@ public void InstanceName(string value, string expected)
105105
[MemberData(nameof(StringTestCases), "unknown", Strings.AllowEmpty)]
106106
public void OperatingSystem(string value, string expected)
107107
{
108-
var source = CreateConfigurationSource((ConfigurationKeys.AzureAppService.OperatingSystemKey, value));
108+
var source = CreateConfigurationSource((PlatformKeys.AzureAppService.OperatingSystemKey, value));
109109
var settings = new ImmutableAzureAppServiceSettings(source, NullConfigurationTelemetry.Instance);
110110

111111
settings.OperatingSystem.Should().Be(expected);
@@ -125,7 +125,7 @@ public void SiteExtensionVersion(string value, string expected)
125125
[MemberData(nameof(StringTestCases))]
126126
public void FunctionsWorkerRuntime(string value, string expected)
127127
{
128-
var source = CreateConfigurationSource((ConfigurationKeys.AzureFunctions.FunctionsWorkerRuntime, value));
128+
var source = CreateConfigurationSource((PlatformKeys.AzureFunctions.FunctionsWorkerRuntime, value));
129129
var settings = new ImmutableAzureAppServiceSettings(source, NullConfigurationTelemetry.Instance);
130130

131131
settings.FunctionsWorkerRuntime.Should().Be(expected);
@@ -135,7 +135,7 @@ public void FunctionsWorkerRuntime(string value, string expected)
135135
[MemberData(nameof(StringTestCases))]
136136
public void FunctionsExtensionVersion(string value, string expected)
137137
{
138-
var source = CreateConfigurationSource((ConfigurationKeys.AzureFunctions.FunctionsExtensionVersion, value));
138+
var source = CreateConfigurationSource((PlatformKeys.AzureFunctions.FunctionsExtensionVersion, value));
139139
var settings = new ImmutableAzureAppServiceSettings(source, NullConfigurationTelemetry.Instance);
140140

141141
settings.FunctionsExtensionVersion.Should().Be(expected);
@@ -150,8 +150,8 @@ public void FunctionsExtensionVersion(string value, string expected)
150150
public void IsFunctionsApp(string functionsWorkerRuntime, string functionsExtensionVersion, bool expected)
151151
{
152152
var source = CreateConfigurationSource(
153-
(ConfigurationKeys.AzureFunctions.FunctionsWorkerRuntime, functionsWorkerRuntime),
154-
(ConfigurationKeys.AzureFunctions.FunctionsExtensionVersion, functionsExtensionVersion));
153+
(PlatformKeys.AzureFunctions.FunctionsWorkerRuntime, functionsWorkerRuntime),
154+
(PlatformKeys.AzureFunctions.FunctionsExtensionVersion, functionsExtensionVersion));
155155
var settings = new ImmutableAzureAppServiceSettings(source, NullConfigurationTelemetry.Instance);
156156

157157
settings.IsFunctionsApp.Should().Be(expected);

‎tracer/test/Datadog.Trace.Tests/Configuration/ImmutableGCPFunctionSettingsTests.cs‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@ public class ImmutableGCPFunctionSettingsTests : SettingsTestsBase
1919
public void GetIsGCPFunctionTrueWhenDeprecatedFunctionsEnvVarsExist()
2020
{
2121
var source = CreateConfigurationSource(
22-
(ConfigurationKeys.GCPFunction.DeprecatedFunctionNameKey, "value"),
23-
(ConfigurationKeys.GCPFunction.DeprecatedProjectKey, "value"));
22+
(PlatformKeys.GCPFunction.DeprecatedFunctionNameKey, "value"),
23+
(PlatformKeys.GCPFunction.DeprecatedProjectKey, "value"));
2424

2525
var settings = new ImmutableGCPFunctionSettings(source, NullConfigurationTelemetry.Instance);
2626
settings.IsDeprecatedFunction.Should().BeTrue();
@@ -32,8 +32,8 @@ public void GetIsGCPFunctionTrueWhenDeprecatedFunctionsEnvVarsExist()
3232
public void GetIsGCPFunctionTrueWhenNonDeprecatedFunctionsEnvVarsExist()
3333
{
3434
var source = CreateConfigurationSource(
35-
(ConfigurationKeys.GCPFunction.FunctionNameKey, "value"),
36-
(ConfigurationKeys.GCPFunction.FunctionTargetKey, "value"));
35+
(PlatformKeys.GCPFunction.FunctionNameKey, "value"),
36+
(PlatformKeys.GCPFunction.FunctionTargetKey, "value"));
3737

3838
var settings = new ImmutableGCPFunctionSettings(source, NullConfigurationTelemetry.Instance);
3939
settings.IsNewerFunction.Should().BeTrue();

‎tracer/test/Datadog.Trace.Tests/Configuration/IntegrationSettingsTests.cs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ public void SettingsRespectsOverride(bool initiallyEnabled)
9090
var name = nameof(IntegrationId.Kafka);
9191
var source = new NameValueConfigurationSource(new()
9292
{
93-
{ string.Format(ConfigurationKeys.Integrations.Enabled, name), initiallyEnabled.ToString() },
93+
{ string.Format(IntegrationSettings.IntegrationEnabled, name), initiallyEnabled.ToString() },
9494
});
9595

9696
var settings = new IntegrationSettings(name, source: source, isExplicitlyDisabled: true);
@@ -105,7 +105,7 @@ public void SettingsRespectsOriginalIfNotOverridden(bool initiallyEnabled)
105105
var name = nameof(IntegrationId.Kafka);
106106
var source = new NameValueConfigurationSource(new()
107107
{
108-
{ string.Format(ConfigurationKeys.Integrations.Enabled, name), initiallyEnabled.ToString() },
108+
{ string.Format(IntegrationSettings.IntegrationEnabled, name), initiallyEnabled.ToString() },
109109
});
110110

111111
var settings = new IntegrationSettings(name, source: source, isExplicitlyDisabled: false);

‎tracer/test/Datadog.Trace.Tests/Configuration/MutableSettingsTests.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -518,7 +518,7 @@ public void KafkaCreateConsumerScopeEnabled(string value, bool expected)
518518
[Fact]
519519
public void DisableTracerIfNoApiKeyInAas()
520520
{
521-
var source = CreateConfigurationSource((ConfigurationKeys.AzureAppService.SiteNameKey, "site-name"));
521+
var source = CreateConfigurationSource((PlatformKeys.AzureAppService.SiteNameKey, "site-name"));
522522
var settings = new TracerSettings(source);
523523
var mutable = GetMutableSettings(source, settings);
524524

‎tracer/test/Datadog.Trace.Tests/Configuration/TracerSettingsServerlessTests.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ public void HttpClientExcludedUrlSubstrings_AzureAppServices(string value, bool
6262

6363
if (isRunningInAppService)
6464
{
65-
configPairs.Add((ConfigurationKeys.AzureAppService.SiteNameKey, "site-name"));
65+
configPairs.Add((PlatformKeys.AzureAppService.SiteNameKey, "site-name"));
6666
}
6767

6868
var settings = new TracerSettings(CreateConfigurationSource(configPairs.ToArray()));

‎tracer/test/Datadog.Trace.Tests/Configuration/TracerSettingsTests.cs‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -582,7 +582,7 @@ public void IsRareSamplerEnabled(string value, bool expected)
582582
[InlineData(null, false)]
583583
public void IsRunningInAzureAppService(string value, bool expected)
584584
{
585-
var source = CreateConfigurationSource((ConfigurationKeys.AzureAppService.SiteNameKey, value));
585+
var source = CreateConfigurationSource((PlatformKeys.AzureAppService.SiteNameKey, value));
586586
var settings = new TracerSettings(source);
587587

588588
settings.IsRunningInAzureAppService.Should().Be(expected);
@@ -595,9 +595,9 @@ public void IsRunningInAzureAppService(string value, bool expected)
595595
public void IsRunningInAzureFunctions(string value, bool expected)
596596
{
597597
var source = CreateConfigurationSource(
598-
(ConfigurationKeys.AzureAppService.SiteNameKey, value),
599-
(ConfigurationKeys.AzureFunctions.FunctionsWorkerRuntime, value),
600-
(ConfigurationKeys.AzureFunctions.FunctionsExtensionVersion, value));
598+
(PlatformKeys.AzureAppService.SiteNameKey, value),
599+
(PlatformKeys.AzureFunctions.FunctionsWorkerRuntime, value),
600+
(PlatformKeys.AzureFunctions.FunctionsExtensionVersion, value));
601601

602602
var settings = new TracerSettings(source);
603603

@@ -667,7 +667,7 @@ public void IsRemoteConfigurationAvailable_AzureAppService(bool? overrideValue,
667667

668668
if (isRunningInAas)
669669
{
670-
configPairs.Add((ConfigurationKeys.AzureAppService.SiteNameKey, "site-name"));
670+
configPairs.Add((PlatformKeys.AzureAppService.SiteNameKey, "site-name"));
671671
}
672672

673673
var settings = new TracerSettings(CreateConfigurationSource(configPairs.ToArray()));

‎tracer/test/Datadog.Trace.Tests/ContinuousProfiler/ProfilerAvailabilityHelperTests.cs‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,9 @@ namespace Datadog.Trace.Tests.ContinuousProfiler;
1717
[EnvironmentRestorer(
1818
"DD_INTERNAL_PROFILING_NATIVE_ENGINE_PATH",
1919
LambdaMetadata.FunctionNameEnvVar,
20-
ConfigurationKeys.AzureAppService.SiteNameKey,
21-
ConfigurationKeys.AzureFunctions.FunctionsWorkerRuntime,
22-
ConfigurationKeys.AzureFunctions.FunctionsExtensionVersion,
20+
PlatformKeys.AzureAppService.SiteNameKey,
21+
PlatformKeys.AzureFunctions.FunctionsWorkerRuntime,
22+
PlatformKeys.AzureFunctions.FunctionsExtensionVersion,
2323
ConfigurationKeys.AzureAppService.AzureAppServicesContextKey)]
2424
public class ProfilerAvailabilityHelperTests
2525
{
@@ -80,9 +80,9 @@ public void IsContinuousProfilerAvailable_InLambda_IgnoresAttachment_ReturnsFals
8080
public void IsContinuousProfilerAvailable_InAzureFunctions_IgnoresAttachment_ReturnsFalse()
8181
{
8282
SkipUnsupported();
83-
Environment.SetEnvironmentVariable(ConfigurationKeys.AzureAppService.SiteNameKey, "MyApp");
84-
Environment.SetEnvironmentVariable(ConfigurationKeys.AzureFunctions.FunctionsWorkerRuntime, "dotnet");
85-
Environment.SetEnvironmentVariable(ConfigurationKeys.AzureFunctions.FunctionsExtensionVersion, "v6.0");
83+
Environment.SetEnvironmentVariable(PlatformKeys.AzureAppService.SiteNameKey, "MyApp");
84+
Environment.SetEnvironmentVariable(PlatformKeys.AzureFunctions.FunctionsWorkerRuntime, "dotnet");
85+
Environment.SetEnvironmentVariable(PlatformKeys.AzureFunctions.FunctionsExtensionVersion, "v6.0");
8686
ProfilerAvailabilityHelper.IsContinuousProfilerAvailable_TestingOnly(ClrProfilerIsAttached).Should().BeFalse();
8787
}
8888

‎tracer/test/Datadog.Trace.Tests/ManualInstrumentation/ManualInstrumentationLegacyConfigurationSourceTests.cs‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ public void GetIntegrationEnabled_SupportedValues_ReturnsExpectedValues(int id)
3131
{
3232
var integrationId = (IntegrationId)id;
3333
var name = IntegrationRegistry.GetName(integrationId).ToUpperInvariant();
34-
var enabledKey = string.Format(ConfigurationKeys.Integrations.Enabled, name);
34+
var enabledKey = string.Format(IntegrationSettings.IntegrationEnabled, name);
3535

3636
var actual = ManualInstrumentationLegacyConfigurationSource.GetIntegrationEnabled(enabledKey);
3737

@@ -44,7 +44,7 @@ public void GetIntegrationAnalyticsEnabled_SupportedValues_ReturnsExpectedValues
4444
{
4545
var integrationId = (IntegrationId)id;
4646
var name = IntegrationRegistry.GetName(integrationId).ToUpperInvariant();
47-
var enabledKey = string.Format(ConfigurationKeys.Integrations.AnalyticsEnabled, name);
47+
var enabledKey = string.Format(IntegrationSettings.AnalyticsEnabledKey, name);
4848

4949
var actual = ManualInstrumentationLegacyConfigurationSource.GetIntegrationAnalyticsEnabled(enabledKey);
5050

@@ -57,7 +57,7 @@ public void GetIntegrationEnabled_ForUnsupportedValues_ReturnsNull(int id)
5757
{
5858
var integrationId = (IntegrationId)id;
5959
var name = IntegrationRegistry.GetName(integrationId).ToUpperInvariant();
60-
var enabledKey = string.Format(ConfigurationKeys.Integrations.Enabled, name);
60+
var enabledKey = string.Format(IntegrationSettings.IntegrationEnabled, name);
6161

6262
var actual = ManualInstrumentationLegacyConfigurationSource.GetIntegrationEnabled(enabledKey);
6363

@@ -70,7 +70,7 @@ public void GetIntegrationAnalyticsEnabled_ForUnsupportedValues_ReturnsNull(int
7070
{
7171
var integrationId = (IntegrationId)id;
7272
var name = IntegrationRegistry.GetName(integrationId).ToUpperInvariant();
73-
var enabledKey = string.Format(ConfigurationKeys.Integrations.AnalyticsEnabled, name);
73+
var enabledKey = string.Format(IntegrationSettings.AnalyticsEnabledKey, name);
7474

7575
var actual = ManualInstrumentationLegacyConfigurationSource.GetIntegrationAnalyticsEnabled(enabledKey);
7676

@@ -83,7 +83,7 @@ public void GetIntegrationAnalyticsSampleRate_ForUnsupportedValues_ReturnsNull(i
8383
{
8484
var integrationId = (IntegrationId)id;
8585
var name = IntegrationRegistry.GetName(integrationId).ToUpperInvariant();
86-
var enabledKey = string.Format(ConfigurationKeys.Integrations.AnalyticsSampleRate, name);
86+
var enabledKey = string.Format(IntegrationSettings.AnalyticsSampleRateKey, name);
8787

8888
var actual = ManualInstrumentationLegacyConfigurationSource.GetIntegrationAnalyticsSampleRate(enabledKey);
8989

‎tracer/test/Datadog.Trace.Tests/ManualInstrumentation/SettingsInstrumentationTests.cs‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -341,9 +341,9 @@ private static TracerSettings GetAndAssertAutomaticTracerSettings()
341341
{ ConfigurationKeys.TraceEnabled, false },
342342
{ ConfigurationKeys.TracerMetricsEnabled, true },
343343
{ ConfigurationKeys.AgentUri, "http://localhost:1234" },
344-
{ string.Format(ConfigurationKeys.Integrations.Enabled, nameof(IntegrationId.Aerospike)), "false" },
345-
{ string.Format(ConfigurationKeys.Integrations.AnalyticsEnabled, nameof(IntegrationId.Grpc)), "true" },
346-
{ string.Format(ConfigurationKeys.Integrations.AnalyticsSampleRate, nameof(IntegrationId.Couchbase)), 0.5 },
344+
{ string.Format(IntegrationSettings.IntegrationEnabled, nameof(IntegrationId.Aerospike)), "false" },
345+
{ string.Format(IntegrationSettings.AnalyticsEnabledKey, nameof(IntegrationId.Grpc)), "true" },
346+
{ string.Format(IntegrationSettings.AnalyticsSampleRateKey, nameof(IntegrationId.Couchbase)), 0.5 },
347347
});
348348

349349
// verify that all the settings are as expected

0 commit comments

Comments
 (0)