RUM-917 Fix type mistmatch error #2092
Open
+20
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciejburda
changed the title
|
Seems like it's reverting #1967, wouldn't this introduce a regression? |
Datadog ReportBranch report: ✅ 0 Failed, 3347 Passed, 188 Skipped, 2m 4.18s Total duration (46.67s time saved) |
|
Also, I think we should target the release branch, WDYT? |
maciejburda
force-pushed
the
RUM-917/fix-typemismatch-bug
branch
from
cbf9ef9
to
70a4058
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Fixes the issues of type mismatch error which was causing full snapshot enforcement in some cases.
How?
We've been wrongly passing identifier of the parent recorder to it's children which was causing in some cases issue where two views would be recorded with different type but the same id. It's because
NodeIDGeneratordepends on the identifier of the recorder.Review checklist
make api-surface