Fix: Session Replay TabBar Recorder id generation #1967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariedm
previously approved these changes
Jul 24, 2024
ncreated
previously approved these changes
Jul 24, 2024
maciejburda
force-pushed
the
maciey/fix-sr-tabbar-recorder
branch
from
765e5c7
to
b207518
Compare
ncreated
approved these changes
Jul 25, 2024
This was referenced Jul 25, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Fixes an issue where TabBar recorder subviews ID generation was inconsistent.
How?
It was caused by the fact that subtree recorders in the TabBarRecorder where created inline with different UUID each time. I refactored the entire setup and provided additional documentation about providing identifiers.
Review checklist