-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new UnmarshalKey in a few locations. Fix edge cases. #29225
Merged
Merged
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
6f821c0
Use new UnmarshalKey in a few locations. Fix edge cases.
dustmop 3bd1a14
Update go modules for tests
dustmop 350fc62
Merge branch 'main' into dustin.long/unmarshalkey-usages
dustmop a0a1e31
Merge branch 'main' into dustin.long/unmarshalkey-usages
dustmop ddb0c47
Option to support empty strings as nil slices. Fix tests.
dustmop e2c4fc9
Fix up go.mod replace directives
dustmop 16e2632
Merge branch 'main' into dustin.long/unmarshalkey-usages
dustmop b6b1041
Handle child key using case-insensitive comparisons
dustmop aa28a52
Update go mod files and serverless deps
dustmop 092b242
Add replace directives to go.mod
dustmop 3a6fcb5
Remove config_keys_test change now that case-insensitivity is supported
dustmop 2ab5bbf
Merge branch 'main' into dustin.long/unmarshalkey-usages
dustmop 621b064
Merge branch 'main' into dustin.long/unmarshalkey-usages
dustmop 2e7bd83
Fix replace directives, make linter happy
dustmop 6326f78
Rearrange declarations for UnmarshalKey
dustmop b2f7390
UnmarshalKey returns early and returns no error if cfg data is nil
dustmop File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
setupAutoDiscovery
incmd/agent/common/autodiscovery.go
expects a nil config setting to return no error. Adding this fix gets thenew-e2e-aml
test to pass.