Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new UnmarshalKey in a few locations. Fix edge cases. #29225

Merged
merged 16 commits into from
Sep 24, 2024
Merged

Use new UnmarshalKey in a few locations. Fix edge cases. #29225

merged 16 commits into from
Sep 24, 2024

Commits on Sep 11, 2024

  1. Use new UnmarshalKey in a few locations. Fix edge cases. 

    Some edge cases are fixed. In order to narrow and simplify the API of the config, only allow these edge case behaviors if certain Options are passed to UnmarshalKey.

UnmarshalKey behavior changes:

- The mapstructure "squash" feature requires EnableSquash
- Case sensitive field matching is always allowed, might become an Option
- Empty strings can be parsed as empty lists, might become an Option
    @dustmop
    dustmop committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    6f821c0 View commit details
    Browse the repository at this point in the history

  2. Update go modules for tests

    @dustmop
    dustmop committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    3bd1a14 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. Merge branch 'main' into dustin.long/unmarshalkey-usages

    @dustmop
    dustmop committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    350fc62 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into dustin.long/unmarshalkey-usages

    @dustmop
    dustmop committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    a0a1e31 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Option to support empty strings as nil slices. Fix tests. 

    The Host/Port tests in config_keys_test reveal that the config should be handlin
g keys using case-insensitive comparisons. Implementing this is tricky and will
be done in a future PR.
    @dustmop
    dustmop committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    ddb0c47 View commit details
    Browse the repository at this point in the history

  2. Fix up go.mod replace directives

    @dustmop
    dustmop committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    e2c4fc9 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into dustin.long/unmarshalkey-usages

    @dustmop
    dustmop committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    16e2632 View commit details
    Browse the repository at this point in the history

  4. Handle child key using case-insensitive comparisons

    @dustmop
    dustmop committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    b6b1041 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. Update go mod files and serverless deps

    @dustmop
    dustmop committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    aa28a52 View commit details
    Browse the repository at this point in the history

  2. Add replace directives to go.mod

    @dustmop
    dustmop committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    092b242 View commit details
    Browse the repository at this point in the history

  3. Remove config_keys_test change now that case-insensitivity is supported

    @dustmop
    dustmop committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    3a6fcb5 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into dustin.long/unmarshalkey-usages

    @dustmop
    dustmop committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    2ab5bbf View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. Merge branch 'main' into dustin.long/unmarshalkey-usages

    @dustmop
    dustmop committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    621b064 View commit details
    Browse the repository at this point in the history

  2. Fix replace directives, make linter happy

    @dustmop
    dustmop committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    2e7bd83 View commit details
    Browse the repository at this point in the history

  3. Rearrange declarations for UnmarshalKey

    @dustmop
    dustmop committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    6326f78 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. UnmarshalKey returns early and returns no error if cfg data is nil

    @dustmop
    dustmop committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    b2f7390 View commit details
    Browse the repository at this point in the history