Skip to content

Conversation

@bcaudan
Copy link
Collaborator

@bcaudan bcaudan commented Dec 9, 2025

Motivation

Following #4009, renovate can't install test apps that rely on packages tarball:

"dependencies": {
  "@datadog/browser-logs": "file:../../../packages/logs/package.tgz",
  "@datadog/browser-rum": "file:../../../packages/rum/package.tgz"
},

as the tarball have not been generated.

Changes

Run yarn build && yarn run pack in postinstall to generate tarballs before installing test apps

Test instructions

Checklist

  • Tested locally
  • Tested on staging
  • Added unit tests for this change.
  • Added e2e/integration tests for this change.

@cit-pr-commenter
Copy link

cit-pr-commenter bot commented Dec 9, 2025

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 164.30 KiB 164.30 KiB 0 B 0.00%
Rum Profiler 4.84 KiB 4.84 KiB 0 B 0.00%
Rum Recorder 19.74 KiB 19.74 KiB 0 B 0.00%
Logs 56.14 KiB 56.14 KiB 0 B 0.00%
Flagging 944 B 944 B 0 B 0.00%
Rum Slim 121.57 KiB 121.57 KiB 0 B 0.00%
Worker 23.63 KiB 23.63 KiB 0 B 0.00%
🚀 CPU Performance

Pending...

🧠 Memory Performance

Pending...

🔗 RealWorld

@bcaudan bcaudan marked this pull request as ready for review December 9, 2025 16:19
@bcaudan bcaudan requested a review from a team as a code owner December 9, 2025 16:19
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Dec 9, 2025

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage
Patch Coverage: 100.00%
Total Coverage: 92.64% (+0.00%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 30a297c | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@bcaudan bcaudan force-pushed the bcaudan/test-apps-deps branch 3 times, most recently from c87ad48 to ba14b2a Compare December 9, 2025 16:37
to allow renovate to install test apps
@bcaudan bcaudan force-pushed the bcaudan/test-apps-deps branch from ba14b2a to c7a9925 Compare December 9, 2025 16:43
@bcaudan bcaudan changed the title 👷 Ensure to have packages built at install 👷 Ensure to have tarballs built at install Dec 9, 2025
@bcaudan bcaudan merged commit d20837f into main Dec 10, 2025
21 checks passed
@bcaudan bcaudan deleted the bcaudan/test-apps-deps branch December 10, 2025 09:56
@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants