Skip to content

Conversation

@bcaudan
Copy link
Collaborator

@bcaudan bcaudan commented Dec 8, 2025

Motivation

Test apps are currently not scanned by renovate:

Screenshot 2025-12-08 at 16 35 43

So their dependencies are not updated and can lead to dependabot alerts that won't be resolved by lock files maintenance

Changes

Remove :ignoreModulesAndTests preset to scan the test directory

Test instructions

Let's see if everything is scanned properly after the merge

Checklist

  • Tested locally
  • Tested on staging
  • Added unit tests for this change.
  • Added e2e/integration tests for this change.

@bcaudan bcaudan marked this pull request as ready for review December 8, 2025 15:45
@bcaudan bcaudan requested a review from a team as a code owner December 8, 2025 15:45
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@cit-pr-commenter
Copy link

cit-pr-commenter bot commented Dec 8, 2025

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 164.30 KiB 164.30 KiB 0 B 0.00%
Rum Profiler 4.84 KiB 4.84 KiB 0 B 0.00%
Rum Recorder 19.74 KiB 19.74 KiB 0 B 0.00%
Logs 56.14 KiB 56.14 KiB 0 B 0.00%
Flagging 944 B 944 B 0 B 0.00%
Rum Slim 121.57 KiB 121.57 KiB 0 B 0.00%
Worker 23.63 KiB 23.63 KiB 0 B 0.00%
🚀 CPU Performance

Pending...

🧠 Memory Performance
Action Name Base Memory Consumption Local Memory Consumption 𝚫
RUM - add global context 25.90 KiB 25.46 KiB -451 B
RUM - add action 47.53 KiB 48.72 KiB +1.20 KiB
RUM - add timing 24.28 KiB 23.90 KiB -395 B
RUM - add error 54.63 KiB 53.93 KiB -716 B
RUM - start/stop session replay recording 23.68 KiB 23.75 KiB +69 B
RUM - start view 426.69 KiB 423.72 KiB -2.97 KiB
Logs - log message 45.31 KiB 44.55 KiB -781 B

🔗 RealWorld

@datadog-official
Copy link

datadog-official bot commented Dec 8, 2025

⚠️ Tests

⚠️ Warnings

❄️ 1 New flaky test detected

record captures stylesheet rules from Chrome Headless 139.0.0.0 (Linux 0.0.0) (Datadog)
Expected $.source = undefined to equal 8.
Expected $.adds = undefined to equal [ Object({ rule: 'body { color: #ccc; }', index: undefined }) ].
Error: Expected $.source = undefined to equal 8.
Expected $.adds = undefined to equal [ Object({ rule: 'body { color: #ccc; }', index: undefined }) ].
    at <Jasmine>
    at UserContext.<anonymous> (/go/src/github.com/DataDog/browser-sdk/packages/rum/src/domain/record/record.spec.ts:109:69 <- /tmp/_karma_webpack_800315/commons.js:315049:35)

ℹ️ Info

🧪 All tests passed

🎯 Code Coverage
Patch Coverage: 100.00%
Total Coverage: 92.64% (+0.00%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: c129ffa | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@bcaudan bcaudan merged commit 9a9e9df into main Dec 8, 2025
21 checks passed
@bcaudan bcaudan deleted the bcaudan/workspaces branch December 8, 2025 16:47
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants