Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WOR-1321 - Disable WorkspaceContainer polling #4394

Merged
merged 3 commits into from
Oct 25, 2023
Merged

WOR-1321 - Disable WorkspaceContainer polling #4394

merged 3 commits into from
Oct 25, 2023

Conversation

blakery
Copy link
Contributor

@blakery blakery commented Oct 25, 2023

Jira Ticket: https://broadworkbench.atlassian.net/browse/WOR-1321

Summary of changes:

Only poll to refresh the dashboard if the workspace is in a deleting state.

Refreshing the workspace was causing the calls to get the apps and runtimes to re-fire, creating a lot of excess API calls.
This PR causes them to go from every 30 seconds, back to their original frequency of every 2 minutes.

@blakery blakery requested a review from a team as a code owner October 25, 2023 14:57
@mlilynolting
Copy link
Contributor

I don't want to slow the turnaround time, but do unit tests cover this case?

rtitle
rtitle approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@rtitle rtitle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@broadbot broadbot temporarily deployed to pr-5 October 25, 2023 15:04 Inactive
@cahrens
Copy link
Contributor

cahrens commented Oct 25, 2023

I don't want to slow the turnaround time, but do unit tests cover this case?

I agree, let's add some unit test coverage.

cahrens
cahrens suggested changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@cahrens cahrens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried out the PR site, and I don't see that the auto-refresh is happening for a deleting Azure workspace.

@broadbot broadbot temporarily deployed to pr-5 October 25, 2023 15:45 Inactive
@mlilynolting mlilynolting mentioned this pull request Oct 25, 2023
Merged
2 tasks
@mlilynolting
Copy link
Contributor

back-linking to #4382

@blakery blakery requested a review from cahrens October 25, 2023 16:27
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell C 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@broadbot broadbot temporarily deployed to pr-5 October 25, 2023 16:35 Inactive
@cahrens cahrens changed the title WOR-1321 - only poll to update the dashboard if the workspace is deleting WOR-1321 - Disable WorkspaceContainer polling Oct 25, 2023
@blakery blakery added this pull request to the merge queue Oct 25, 2023
Merged via the queue into dev with commit 45b27a3 Oct 25, 2023
@blakery blakery deleted the WOR-1321 branch October 25, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cahrens cahrens cahrens approved these changes

@rtitle rtitle rtitle approved these changes

@Ghost-in-a-Jar Ghost-in-a-Jar Ghost-in-a-Jar approved these changes

@marctalbott marctalbott Awaiting requested review from marctalbott marctalbott was automatically assigned from DataBiosphere/broadworkspaces-terra-ui

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@blakery @mlilynolting @cahrens @rtitle @Ghost-in-a-Jar @broadbot