-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WOR-703 Part 1: changes to existing GCP billing project wizard #3777
Conversation
578844b
to
9de42a5
Compare
23f6542
to
da3ea65
Compare
@blakery I'm seeing the first text for Step 2 appear to the right of Step 2 instead of below it. |
Since the BillingProjectWizard is rapidly becoming less "new", could we just call the directory "BillingProjectWizard"? Ugh, I just realized that "New" referred to "BillingProject", not "BillingProjectWizard". So nevermind. |
src/pages/billing/NewBillingProjectWizard/GCPBillingProjectWizard/GCPBillingProjectWizard.ts
Outdated
Show resolved
Hide resolved
...ages/billing/NewBillingProjectWizard/GCPBillingProjectWizard/GCPBillingProjectWizard.test.ts
Outdated
Show resolved
Hide resolved
...ages/billing/NewBillingProjectWizard/GCPBillingProjectWizard/GCPBillingProjectWizard.test.ts
Outdated
Show resolved
Hide resolved
...ages/billing/NewBillingProjectWizard/GCPBillingProjectWizard/GCPBillingProjectWizard.test.ts
Show resolved
Hide resolved
all usages now use StepHeader explicitly
turns out, a list with in a list is perfectly ok: so my concern about that restricting the usage of the components was unfounded
it works without it, now
…mprove button placement
c5dcfa9
to
fec273a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's currently only tests for the AddTerraAsBillingAccountUserStep
, do we need tests for each step? Tested it out locally though and everything looks good
.../billing/NewBillingProjectWizard/GCPBillingProjectWizard/AddTerraAsBillingAccountUserStep.ts
Outdated
Show resolved
Hide resolved
src/pages/billing/NewBillingProjectWizard/GCPBillingProjectWizard/GoToGCPConsoleStep.ts
Show resolved
Hide resolved
src/pages/billing/NewBillingProjectWizard/GCPBillingProjectWizard/GCPBillingProjectWizard.ts
Show resolved
Hide resolved
The was an extensive pre-existing unit test for the whole wizard that is still running. I'm not sure what @blakery's plan was with regard to testing each individual step in isolation, but we certainly haven't lost any coverage with this PR. |
Kudos, SonarCloud Quality Gate passed! |
WOR-703
This PR is the changes the existing step wizard for GCP, in order to extract it into a separate component.
Original PR here