[DT-1654] Add scripts #1975
Open
[DT-1654] Add scripts #1975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-rubenstein
requested review from
pshapiro4broad and
rjohanek
and removed request for
a team
|
pshapiro4broad
approved these changes
May 30, 2025
There was a problem hiding this comment.
I would expect these files to be excluded by the .gitignore entry
tools/migrateInheritSteward/*.json
If you add a file that is later .gitignore'd then any further changes won't be picked up, so this doesn't seem correct. Having an example input seems like a good idea, but it could be added in a comment in the script instead of committed as a file.
| print(f"Waiting for job {job_model.id} to finish") | ||
| result = clients.jobs_api.retrieve_job(job_model.id) | ||
| elif result.job_status == "failed": | ||
| print(job_model.id) |
There was a problem hiding this comment.
Is this for debugging? Or should it have a Failed message?
Suggested change
| print(job_model.id) | |
| print(f"Job {job_model.id} failed") |
rjohanek
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: https://broadworkbench.atlassian.net/browse/dt-1654
Addresses
Summary of changes
Testing Strategy