Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DUOS-877][risk=no] Remove unused dev dependencies #744

Merged
merged 3 commits into from
Dec 10, 2020
Merged

Conversation

rushtong
Copy link
Contributor

@rushtong rushtong commented Dec 9, 2020

Addresses

https://broadinstitute.atlassian.net/browse/DUOS-877

Changes

Removed only the unused dev dependencies. Others will be addressed in other stories


Have you read Terra's Contributing Guide lately? If not, do that first.

I, the developer opening this PR, do solemnly pinky swear that:

  • PR is labeled with a Jira ticket number and includes a link to the ticket
  • PR is labeled with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes

In all cases:

  • Get a minimum of one thumbs worth of review, preferably 2 if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Squash and merge; you can delete your branch after this
  • Test this change deployed correctly and works on dev environment after deployment

@rushtong rushtong requested a review from a team as a code owner December 9, 2020 15:33
@JVThomas
Copy link
Contributor

JVThomas commented Dec 9, 2020

Just curious, the package.json file has a comment on how handlebars and js-yaml are "security related updates for indirect dependencies". What was that about?

@rushtong
Copy link
Contributor Author

rushtong commented Dec 9, 2020

@JVThomas

Just curious, the package.json file has a comment on how handlebars and js-yaml are "security related updates for indirect dependencies". What was that about?

Great question ... and I missed that. I added that back in #168 and I am hoping they do not trigger a new security check. At the time, I think we were using source clear for these checks, but now we're pretty reliant on either dependabot or github.

@rushtong
Copy link
Contributor Author

rushtong commented Dec 9, 2020

Also, we run npm audit on every PR - now that we know it's passing, there is no longer a security issue with these libraries.

@rushtong rushtong merged commit b2ef862 into develop Dec 10, 2020
@rushtong rushtong deleted the DUOS-877 branch December 10, 2020 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants