Repository navigation
[DT-4196] Upgrade to jsdom 30.1.1 and Vitest 5.0.3, drop the Dependabot jsdom ignore - #3986
Merged
Merged
Conversation
…ot jsdom ignore Vitest 5.0.3 includes vitest-dev/vitest#11379, which restores the URL.createObjectURL Blob shim on jsdom 30.1. jsdom now reports computed font-weight numerically, so four assertions move from keywords to 400/700. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Contributor
Coverage Report for DUOS Coverage Report
File CoverageNo changed files found. |
kevinmarete
marked this pull request as ready for review
October 2, 2026 17:00
kevinmarete
requested review from
fboulnois,
otchet-broad and
rushtong
and removed request for
a team
October 2, 2026 17:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses
https://broadworkbench.atlassian.net/browse/DT-4196
Security risk: no — test-only dependency upgrade; jsdom and Vitest are dev dependencies and nothing in the shipped bundle changes.
Summary
Unpins jsdom so Dependabot can keep it current. jsdom goes to 30.1.1 and the
jsdomignore in.github/dependabot.ymlis removed.The ticket was waiting on vitest-dev/vitest#11295, but that alone wasn't enough: develop already has it (Vitest 5.0.2), and the
EditDacDAA upload tests still failed. jsdom 30.1 no longer exposes a Blob's impl through an own Symbol, so the shim found no impl at all. vitest-dev/vitest#11379 fixes that and ships in 5.0.3, sovitestand@vitest/*move to 5.0.3 in both the root andserverworkspaces.jsdom now reports computed
font-weightnumerically per spec, so four assertions change fromnormal/boldto400/700. The negativenot.toHaveStyle({ fontWeight: 'bold' })inCloseoutReviewbecomes a positive400check, since the negative form would pass vacuously.No Blob-shim workaround and no
focus/FocusTrap mocks. Root (4937), browser (15) and server (705) suites pass locally; flipping each changed expectation makes its test fail.Have you read Terra's Contributing Guide lately? If not, do that first.
🤖 Generated with Claude Code