Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DCJ-163: Auth Design Overview #2662

Merged
merged 9 commits into from
Oct 4, 2024
Merged

Conversation

rushtong
Copy link
Contributor

@rushtong rushtong commented Sep 3, 2024

Addresses

https://broadworkbench.atlassian.net/browse/DCJ-163

Summary

Reviewer notes:

  • I suggest enabling the "Display the rich diff" option for the markdown file. That will show you what the mermaid diagrams look like: Screenshot 2024-09-03 at 11 52 31 AM

  • If you're viewing this in intellij, look for the Mermaid plugin which supports sequence diagrams.

Notes

The DUOS-branded sign in page still needs to be configured in Consent, but this PR is not blocked on that feature. The customized page is implemented here: https://github.com/broadinstitute/terraform-ap-deployments/pull/1713


Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you 👍

@rushtong rushtong marked this pull request as ready for review October 3, 2024 19:26
@rushtong rushtong requested a review from a team as a code owner October 3, 2024 19:26
@rushtong rushtong requested review from okotsopoulos and removed request for a team October 3, 2024 19:26
Copy link
Contributor

@s-rubenstein s-rubenstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me!

@rushtong rushtong merged commit 517f5b3 into develop Oct 4, 2024
9 checks passed
@rushtong rushtong deleted the gr-DCJ-163-auth-design-overview branch October 4, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants