Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DCJ-11][risk=no] duos-ui runs all PR checks on Dependabot PRs #2531

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

okotsopoulos
Copy link
Collaborator

Addresses

https://broadworkbench.atlassian.net/browse/DCJ-11

Summary

Dependabot was added to duos-ui before there was a way for Dependabot to access repository secrets. The workaround was to skip UI integration tests in Dependabot PRs, along with any other task requiring secret access.

Once the changes from https://github.com/broadinstitute/terraform-ap-deployments/pull/1486 we can change PR checks so that they all run on Dependabot PRs.


Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

Dependabot was added to duos-ui before there was a way for Dependabot to access repository secrets. The workaround was to skip UI integration tests in Dependabot PRs, along with any other task requiring secret access.

Once the changes from broadinstitute/terraform-ap-deployments#1486 we can change PR checks so that they all run on Dependabot PRs.
@okotsopoulos okotsopoulos marked this pull request as ready for review April 8, 2024 14:59
@okotsopoulos okotsopoulos requested a review from a team as a code owner April 8, 2024 14:59
@okotsopoulos okotsopoulos marked this pull request as draft April 8, 2024 15:23
@okotsopoulos
Copy link
Collaborator Author

Moving to draft: these integration tests are configured to run on Alpha, and have been disabled for the past 5 months. We should decide whether we want to update them to run on a different environment as part of PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant