Skip to content

Conversation

@mrtopsyt
Copy link
Contributor

@mrtopsyt mrtopsyt commented Feb 18, 2025

Ticket

Closes #4378 .

Reviewers

@hunterckx .

Changes

  • Added landing pages df functions to the analytics package
  • Refactored lower level functions to private _sheets_utils.py to allow them to be changed in the future for breaking changes
  • Reduced code duplication for change df functions
  • Created constant definitions for all analytics related variables and titles in entities.py, renaming the existing fields.py
  • Changed the names of certain spreadsheet headers to clarify definitions
  • Added docstrings for all functions

Known Issues

  • A large portion of sessions have (not set) as their landing page, which occurs when a session times out and restarts as documented here. This value will be replaced with a blank value for reports starting in March 2025 as per an email sent out to GA4 account holders

@mrtopsyt mrtopsyt linked an issue Feb 18, 2025 that may be closed by this pull request
@mrtopsyt mrtopsyt changed the title Jonah/4378 add landing pages to analytics package feat:4378 add landing pages to analytics package Feb 18, 2025
@mrtopsyt mrtopsyt changed the title feat:4378 add landing pages to analytics package feat: add landing pages to analytics package (#4378) Feb 18, 2025
@mrtopsyt mrtopsyt requested a review from hunterckx February 18, 2025 17:47
Copy link
Contributor

@hunterckx hunterckx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@hunterckx hunterckx merged commit 5a7502f into main Feb 19, 2025
3 of 4 checks passed
@MillenniumFalconMechanic MillenniumFalconMechanic deleted the jonah/4378-add-landing-pages-to-analytics-package branch February 28, 2025 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Landing Pages to analytics package

3 participants