Skip to content

Added track by to tab component. Resolves #1224. #1226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2020
Merged

Added track by to tab component. Resolves #1224. #1226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion spa/src/app/shared/hca-tab/hca-tab.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
<div class="wrapper">
<ng-container *ngIf="tabs">
<div class="hca-tabs">
<div [ngClass]="getTabClass(activeTab.key, tab.key)" *ngFor="let tab of tabs" (click)="onClickTab(tab)">
<div *ngFor="let tab of tabs;trackBy: trackByFn"
[ngClass]="getTabClass(activeTab.key, tab.key)"
(click)="onClickTab(tab)">
{{tab.displayName}}
</div>
</div>
Expand Down
18 changes: 12 additions & 6 deletions spa/src/app/shared/hca-tab/hca-tab.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@ import {
// App dependencies
import EntitySpec from "../../files/shared/entity-spec";

// App dependencies

@Component({
selector: "hca-tab",
templateUrl: "./hca-tab.component.html",
Expand All @@ -32,10 +30,6 @@ export class HCATabComponent {
// Outputs
@Output() tabSelected = new EventEmitter<EntitySpec[]>();

/**
* Public API
*/

/**
* Return the set of CSS class names that are applicable to the tab.
*
Expand All @@ -61,4 +55,16 @@ export class HCATabComponent {
this.tabSelected.emit(tab);
}

/**
* Track by function used when displaying the set of tabs.
*
* @param {number} index
* @param {EntitySpec} tab
* @returns {string}
*/
public trackByFn(index: number, tab: EntitySpec): string {

return tab.key;
}

}