Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect WP and skip the area on users request #6

Merged
merged 5 commits into from
Sep 28, 2022
Merged

Detect WP and skip the area on users request #6

merged 5 commits into from
Sep 28, 2022

Conversation

SergiiDmytruk
Copy link
Member

A simple test can look like this:

truncate --size=16M rom
./flashrom -p dummy:emulate=W25Q128FV,spi_status=0x00ec,hwwp=yes --write rom

@github-actions
Copy link

github-actions bot commented Aug 3, 2022

Thank you for your contribution. The flashrom project does not handle GitHub issues or pull requests, since this repository on GitHub is just a mirror of our actual repository. Thus, we would like to encourage you to have a look at on our development guidelines and submit your patch to review.coreboot.org. Issues are handled over our ticket system. If you have questions, feel free to reach out to us. There are multiple ways to contact us.

@github-actions github-actions bot closed this Aug 3, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 3, 2022
@macpijan
Copy link

macpijan commented Aug 3, 2022

oh, we certainly do not want github bot close our PRs here automatically

@macpijan macpijan reopened this Aug 3, 2022
@Dasharo Dasharo unlocked this conversation Aug 3, 2022
@macpijan macpijan requested a review from tlaurion August 5, 2022 10:11
krystian-hebel
krystian-hebel reviewed Aug 9, 2022
View reviewed changes
Documentation/heads-and-wp.md Outdated Show resolved Hide resolved
Documentation/heads-and-wp.md Show resolved Hide resolved
cli_classic.c Outdated Show resolved Hide resolved
@SergiiDmytruk SergiiDmytruk force-pushed the wp-detection branch 2 times, most recently from 648c78a to f5b65a2 Compare August 9, 2022 21:20
@SergiiDmytruk
flashrom.c: automatically exclude write-protected area from write/erase
48e42c6 
Change-Id: I971a07d9d8b16f5c0ead9a9b6de1efe0b69288c9
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
@SergiiDmytruk
Add FLASHROM_FLAG_SKIP_WP_AREA flag
cccc242 
Used to control skipping of write-protected part of a chip.

Change-Id: Icdc56cb1876aab8f8229cd1a485aa297d8b7b1e9
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
@SergiiDmytruk
Add --skip-wp-area CLI parameter
a39d087 
Change-Id: I73c9a1a1e348820cc438f347a5e09f348e397fe6
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
@SergiiDmytruk
Documentation/heads-and-wp.md: add
d047111 
Change-Id: I5848ea57ec389f2830e92d972ce6fe6c38737509
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
@tlaurion tlaurion mentioned this pull request Sep 2, 2022
Open
@SergiiDmytruk @macpijan
Add list of chips for which we intend to have WP
2338576 
Change-Id: Ifcd6cffa22dffd05241515fc30e0f550f89b5b16
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
@macpijan
Copy link

@krystian-hebel Any more comments to that?

Generally, it looks good to me.

@tlaurion Do you have any more comments to that? I know you have mentioned somewhere else that in the end it might be difficult to apply this approach to heads.

But this MR was focusing on the goal:

Have flashrom deal properly with that (WP) region when upgrading full ROM internally

which seems to be covered.

krystian-hebel
krystian-hebel approved these changes Sep 28, 2022
View reviewed changes
Copy link

@krystian-hebel krystian-hebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Depending on where this will land eventually, notes column in chips.md may require redacting.

@macpijan macpijan merged commit d09a6c6 into wp_integration Sep 28, 2022
@macpijan macpijan deleted the wp-detection branch September 28, 2022 15:43
@tlaurion
Copy link
Collaborator

tlaurion commented Sep 28, 2022 •
edited
Loading

@macpijan @krystian-hebel

I can only speak from past experience here, but from current documentation, it seems that the user would receive a warning saying that bootblock region is going to have some changes applied PRIOR of applying them, requiring the user to adapt its command line arguments to apply explicitly do the change.

As for Heads, or any internal upgrade (think FWUPD) I'm still unsure how that would be implemented.

The ideal would be for the user to not do the obviously stupid move of flashing the whole SPI if bootblock region was not expected to change from internal flash upgrade.

And I guess some wrapper telling to the user to stay on a same coreboot version branch from GUI output, and/or to externally flash the firmware image on the platform.

@tlaurion tlaurion mentioned this pull request Aug 2, 2024
Closed
@tlaurion
Copy link
Collaborator

@macpijan @krystian-hebel ping on #6 (comment)

Also, looking to find chips.md which seems to have been lost in master/upstream; 94083d0

Was that intended?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krystian-hebel krystian-hebel krystian-hebel approved these changes

@macpijan macpijan Awaiting requested review from macpijan

@tlaurion tlaurion Awaiting requested review from tlaurion

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SergiiDmytruk @macpijan @tlaurion @krystian-hebel